All of lore.kernel.org
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/10] Marvell Berlin full clock support
Date: Mon, 19 May 2014 21:46:13 +0200	[thread overview]
Message-ID: <537A5F85.4090709@gmail.com> (raw)
In-Reply-To: <1400517811-24668-1-git-send-email-sebastian.hesselbarth@gmail.com>

On 05/19/2014 06:43 PM, Sebastian Hesselbarth wrote:
> Mike,
> 
> this is v2 of the Berlin SoC clock driver [1] but with a reworked DT
> binding as requested [2]. We decided to not even try to split up the chip
> control registers that deal with pinmux, padmux, clock, reset, and evil
> stuff we haven't even looked at. Instead we keep a single node that clock
> driver will remap early, while proper platform_drivers use a regmap
> instead. Although clock and other drivers share the same register range,
> they use individual registers exclusively.
> 
> There are some functional fixes in the single clock drivers, I noticed
> while retesting each individial driver. There will be more to fixup but
> without any drivers actually using the clocks, it is hard to tell what
> isn't working now.
> 
> Anyway, the current binding should match what you requested and having
> a clock driver for v3.16 will really be a huge benefit for us to work
> on more driver support.
> 
> If you are fine with it, please take patches 2-7 and I'll pick up
> 1,8-10 in berlin branch.

nit: I also take patch 2 as it is the required DT include. Makes 3-7
to pick up for you.

Sebastian

> [1] https://lkml.kernel.org/r/1399839881-29895-1-git-send-email-sebastian.hesselbarth at gmail.com
> [2] https://lkml.kernel.org/r/20140515044106.19795.57249 at quantum
> 
> Alexandre Belloni (4):
>   clk: berlin: add driver for BG2x simple PLLs
>   clk: berlin: add driver for BG2x complex divider cells
>   clk: berlin: add core clock driver for BG2Q
>   ARM: dts: berlin: convert BG2Q to DT clock nodes
> 
> Sebastian Hesselbarth (6):
>   dt-binding: ARM: add clock binding docs for Marvell Berlin2 SoCs
>   clk: berlin: add binding include for Berlin SoC clock ids
>   clk: berlin: add driver for BG2x audio/video PLL
>   clk: berlin: add core clock driver for BG2/BG2CD
>   ARM: dts: berlin: convert BG2CD to DT clock nodes
>   ARM: dts: berlin: convert BG2 to DT clock nodes
> 
>  .../devicetree/bindings/arm/marvell,berlin.txt     |  47 ++
>  arch/arm/boot/dts/berlin2.dtsi                     |  56 +-
>  arch/arm/boot/dts/berlin2cd.dtsi                   |  53 +-
>  arch/arm/boot/dts/berlin2q.dtsi                    |  54 +-
>  drivers/clk/Makefile                               |   1 +
>  drivers/clk/berlin/Makefile                        |   4 +
>  drivers/clk/berlin/berlin2-avpll.c                 | 393 ++++++++++++
>  drivers/clk/berlin/berlin2-avpll.h                 |  36 ++
>  drivers/clk/berlin/berlin2-div.c                   | 265 ++++++++
>  drivers/clk/berlin/berlin2-div.h                   |  89 +++
>  drivers/clk/berlin/berlin2-pll.c                   | 117 ++++
>  drivers/clk/berlin/berlin2-pll.h                   |  37 ++
>  drivers/clk/berlin/bg2.c                           | 691 +++++++++++++++++++++
>  drivers/clk/berlin/bg2q.c                          | 389 ++++++++++++
>  drivers/clk/berlin/common.h                        |  29 +
>  include/dt-bindings/clock/berlin2.h                |  45 ++
>  include/dt-bindings/clock/berlin2q.h               |  31 +
>  17 files changed, 2240 insertions(+), 97 deletions(-)
>  create mode 100644 drivers/clk/berlin/Makefile
>  create mode 100644 drivers/clk/berlin/berlin2-avpll.c
>  create mode 100644 drivers/clk/berlin/berlin2-avpll.h
>  create mode 100644 drivers/clk/berlin/berlin2-div.c
>  create mode 100644 drivers/clk/berlin/berlin2-div.h
>  create mode 100644 drivers/clk/berlin/berlin2-pll.c
>  create mode 100644 drivers/clk/berlin/berlin2-pll.h
>  create mode 100644 drivers/clk/berlin/bg2.c
>  create mode 100644 drivers/clk/berlin/bg2q.c
>  create mode 100644 drivers/clk/berlin/common.h
>  create mode 100644 include/dt-bindings/clock/berlin2.h
>  create mode 100644 include/dt-bindings/clock/berlin2q.h
> 
> ---
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mike Turquette <mturquette@linaro.org>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Jisheng Zhang <jszhang@marvell.com>
> Cc: devicetree at vger.kernel.org
> Cc: linux-doc at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> 

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Mike Turquette <mturquette@linaro.org>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Jisheng Zhang <jszhang@marvell.com>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/10] Marvell Berlin full clock support
Date: Mon, 19 May 2014 21:46:13 +0200	[thread overview]
Message-ID: <537A5F85.4090709@gmail.com> (raw)
In-Reply-To: <1400517811-24668-1-git-send-email-sebastian.hesselbarth@gmail.com>

On 05/19/2014 06:43 PM, Sebastian Hesselbarth wrote:
> Mike,
> 
> this is v2 of the Berlin SoC clock driver [1] but with a reworked DT
> binding as requested [2]. We decided to not even try to split up the chip
> control registers that deal with pinmux, padmux, clock, reset, and evil
> stuff we haven't even looked at. Instead we keep a single node that clock
> driver will remap early, while proper platform_drivers use a regmap
> instead. Although clock and other drivers share the same register range,
> they use individual registers exclusively.
> 
> There are some functional fixes in the single clock drivers, I noticed
> while retesting each individial driver. There will be more to fixup but
> without any drivers actually using the clocks, it is hard to tell what
> isn't working now.
> 
> Anyway, the current binding should match what you requested and having
> a clock driver for v3.16 will really be a huge benefit for us to work
> on more driver support.
> 
> If you are fine with it, please take patches 2-7 and I'll pick up
> 1,8-10 in berlin branch.

nit: I also take patch 2 as it is the required DT include. Makes 3-7
to pick up for you.

Sebastian

> [1] https://lkml.kernel.org/r/1399839881-29895-1-git-send-email-sebastian.hesselbarth@gmail.com
> [2] https://lkml.kernel.org/r/20140515044106.19795.57249@quantum
> 
> Alexandre Belloni (4):
>   clk: berlin: add driver for BG2x simple PLLs
>   clk: berlin: add driver for BG2x complex divider cells
>   clk: berlin: add core clock driver for BG2Q
>   ARM: dts: berlin: convert BG2Q to DT clock nodes
> 
> Sebastian Hesselbarth (6):
>   dt-binding: ARM: add clock binding docs for Marvell Berlin2 SoCs
>   clk: berlin: add binding include for Berlin SoC clock ids
>   clk: berlin: add driver for BG2x audio/video PLL
>   clk: berlin: add core clock driver for BG2/BG2CD
>   ARM: dts: berlin: convert BG2CD to DT clock nodes
>   ARM: dts: berlin: convert BG2 to DT clock nodes
> 
>  .../devicetree/bindings/arm/marvell,berlin.txt     |  47 ++
>  arch/arm/boot/dts/berlin2.dtsi                     |  56 +-
>  arch/arm/boot/dts/berlin2cd.dtsi                   |  53 +-
>  arch/arm/boot/dts/berlin2q.dtsi                    |  54 +-
>  drivers/clk/Makefile                               |   1 +
>  drivers/clk/berlin/Makefile                        |   4 +
>  drivers/clk/berlin/berlin2-avpll.c                 | 393 ++++++++++++
>  drivers/clk/berlin/berlin2-avpll.h                 |  36 ++
>  drivers/clk/berlin/berlin2-div.c                   | 265 ++++++++
>  drivers/clk/berlin/berlin2-div.h                   |  89 +++
>  drivers/clk/berlin/berlin2-pll.c                   | 117 ++++
>  drivers/clk/berlin/berlin2-pll.h                   |  37 ++
>  drivers/clk/berlin/bg2.c                           | 691 +++++++++++++++++++++
>  drivers/clk/berlin/bg2q.c                          | 389 ++++++++++++
>  drivers/clk/berlin/common.h                        |  29 +
>  include/dt-bindings/clock/berlin2.h                |  45 ++
>  include/dt-bindings/clock/berlin2q.h               |  31 +
>  17 files changed, 2240 insertions(+), 97 deletions(-)
>  create mode 100644 drivers/clk/berlin/Makefile
>  create mode 100644 drivers/clk/berlin/berlin2-avpll.c
>  create mode 100644 drivers/clk/berlin/berlin2-avpll.h
>  create mode 100644 drivers/clk/berlin/berlin2-div.c
>  create mode 100644 drivers/clk/berlin/berlin2-div.h
>  create mode 100644 drivers/clk/berlin/berlin2-pll.c
>  create mode 100644 drivers/clk/berlin/berlin2-pll.h
>  create mode 100644 drivers/clk/berlin/bg2.c
>  create mode 100644 drivers/clk/berlin/bg2q.c
>  create mode 100644 drivers/clk/berlin/common.h
>  create mode 100644 include/dt-bindings/clock/berlin2.h
>  create mode 100644 include/dt-bindings/clock/berlin2q.h
> 
> ---
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mike Turquette <mturquette@linaro.org>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Jisheng Zhang <jszhang@marvell.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-doc@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> 


WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Mike Turquette <mturquette@linaro.org>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Jisheng Zhang <jszhang@marvell.com>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/10] Marvell Berlin full clock support
Date: Mon, 19 May 2014 21:46:13 +0200	[thread overview]
Message-ID: <537A5F85.4090709@gmail.com> (raw)
In-Reply-To: <1400517811-24668-1-git-send-email-sebastian.hesselbarth@gmail.com>

On 05/19/2014 06:43 PM, Sebastian Hesselbarth wrote:
> Mike,
> 
> this is v2 of the Berlin SoC clock driver [1] but with a reworked DT
> binding as requested [2]. We decided to not even try to split up the chip
> control registers that deal with pinmux, padmux, clock, reset, and evil
> stuff we haven't even looked at. Instead we keep a single node that clock
> driver will remap early, while proper platform_drivers use a regmap
> instead. Although clock and other drivers share the same register range,
> they use individual registers exclusively.
> 
> There are some functional fixes in the single clock drivers, I noticed
> while retesting each individial driver. There will be more to fixup but
> without any drivers actually using the clocks, it is hard to tell what
> isn't working now.
> 
> Anyway, the current binding should match what you requested and having
> a clock driver for v3.16 will really be a huge benefit for us to work
> on more driver support.
> 
> If you are fine with it, please take patches 2-7 and I'll pick up
> 1,8-10 in berlin branch.

nit: I also take patch 2 as it is the required DT include. Makes 3-7
to pick up for you.

Sebastian

> [1] https://lkml.kernel.org/r/1399839881-29895-1-git-send-email-sebastian.hesselbarth@gmail.com
> [2] https://lkml.kernel.org/r/20140515044106.19795.57249@quantum
> 
> Alexandre Belloni (4):
>   clk: berlin: add driver for BG2x simple PLLs
>   clk: berlin: add driver for BG2x complex divider cells
>   clk: berlin: add core clock driver for BG2Q
>   ARM: dts: berlin: convert BG2Q to DT clock nodes
> 
> Sebastian Hesselbarth (6):
>   dt-binding: ARM: add clock binding docs for Marvell Berlin2 SoCs
>   clk: berlin: add binding include for Berlin SoC clock ids
>   clk: berlin: add driver for BG2x audio/video PLL
>   clk: berlin: add core clock driver for BG2/BG2CD
>   ARM: dts: berlin: convert BG2CD to DT clock nodes
>   ARM: dts: berlin: convert BG2 to DT clock nodes
> 
>  .../devicetree/bindings/arm/marvell,berlin.txt     |  47 ++
>  arch/arm/boot/dts/berlin2.dtsi                     |  56 +-
>  arch/arm/boot/dts/berlin2cd.dtsi                   |  53 +-
>  arch/arm/boot/dts/berlin2q.dtsi                    |  54 +-
>  drivers/clk/Makefile                               |   1 +
>  drivers/clk/berlin/Makefile                        |   4 +
>  drivers/clk/berlin/berlin2-avpll.c                 | 393 ++++++++++++
>  drivers/clk/berlin/berlin2-avpll.h                 |  36 ++
>  drivers/clk/berlin/berlin2-div.c                   | 265 ++++++++
>  drivers/clk/berlin/berlin2-div.h                   |  89 +++
>  drivers/clk/berlin/berlin2-pll.c                   | 117 ++++
>  drivers/clk/berlin/berlin2-pll.h                   |  37 ++
>  drivers/clk/berlin/bg2.c                           | 691 +++++++++++++++++++++
>  drivers/clk/berlin/bg2q.c                          | 389 ++++++++++++
>  drivers/clk/berlin/common.h                        |  29 +
>  include/dt-bindings/clock/berlin2.h                |  45 ++
>  include/dt-bindings/clock/berlin2q.h               |  31 +
>  17 files changed, 2240 insertions(+), 97 deletions(-)
>  create mode 100644 drivers/clk/berlin/Makefile
>  create mode 100644 drivers/clk/berlin/berlin2-avpll.c
>  create mode 100644 drivers/clk/berlin/berlin2-avpll.h
>  create mode 100644 drivers/clk/berlin/berlin2-div.c
>  create mode 100644 drivers/clk/berlin/berlin2-div.h
>  create mode 100644 drivers/clk/berlin/berlin2-pll.c
>  create mode 100644 drivers/clk/berlin/berlin2-pll.h
>  create mode 100644 drivers/clk/berlin/bg2.c
>  create mode 100644 drivers/clk/berlin/bg2q.c
>  create mode 100644 drivers/clk/berlin/common.h
>  create mode 100644 include/dt-bindings/clock/berlin2.h
>  create mode 100644 include/dt-bindings/clock/berlin2q.h
> 
> ---
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mike Turquette <mturquette@linaro.org>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Jisheng Zhang <jszhang@marvell.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-doc@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> 


  parent reply	other threads:[~2014-05-19 19:46 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 16:43 [PATCH v2 00/10] Marvell Berlin full clock support Sebastian Hesselbarth
2014-05-19 16:43 ` Sebastian Hesselbarth
2014-05-19 16:43 ` Sebastian Hesselbarth
2014-05-19 16:43 ` [PATCH v2 01/10] dt-binding: ARM: add clock binding docs for Marvell Berlin2 SoCs Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 21:05   ` Alexandre Belloni
2014-05-19 21:05     ` Alexandre Belloni
2014-05-19 16:43 ` [PATCH v2 02/10] clk: berlin: add binding include for Berlin SoC clock ids Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 16:43 ` [PATCH v2 03/10] clk: berlin: add driver for BG2x audio/video PLL Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 16:43 ` [PATCH v2 04/10] clk: berlin: add driver for BG2x simple PLLs Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 16:43 ` [PATCH v2 05/10] clk: berlin: add driver for BG2x complex divider cells Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 16:43 ` [PATCH v2 06/10] clk: berlin: add core clock driver for BG2/BG2CD Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 21:06   ` Alexandre Belloni
2014-05-19 21:06     ` Alexandre Belloni
2014-05-19 16:43 ` [PATCH v2 07/10] clk: berlin: add core clock driver for BG2Q Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 16:43 ` [PATCH v2 08/10] ARM: dts: berlin: convert BG2CD to DT clock nodes Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 21:07   ` Alexandre Belloni
2014-05-19 21:07     ` Alexandre Belloni
2014-05-19 16:43 ` [PATCH v2 09/10] ARM: dts: berlin: convert BG2 " Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 21:13   ` Alexandre Belloni
2014-05-19 21:13     ` Alexandre Belloni
2014-05-19 16:43 ` [PATCH v2 10/10] ARM: dts: berlin: convert BG2Q " Sebastian Hesselbarth
2014-05-19 16:43   ` Sebastian Hesselbarth
2014-05-19 19:46 ` Sebastian Hesselbarth [this message]
2014-05-19 19:46   ` [PATCH v2 00/10] Marvell Berlin full clock support Sebastian Hesselbarth
2014-05-19 19:46   ` Sebastian Hesselbarth
2014-05-29  0:07 ` Mike Turquette
2014-05-29  0:07   ` Mike Turquette
2014-05-29  0:07   ` Mike Turquette
2014-05-29  9:20   ` Sebastian Hesselbarth
2014-05-29  9:20     ` Sebastian Hesselbarth
2014-05-29 16:30     ` Mike Turquette
2014-05-29 16:30       ` Mike Turquette
  -- strict thread matches above, loose matches on Subject: below --
2014-05-11 20:24 [PATCH 0/8] " Sebastian Hesselbarth
2014-05-14 20:15 ` [PATCH v2 00/10] " Sebastian Hesselbarth
2014-05-14 20:15   ` Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537A5F85.4090709@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.