From: Oleksij Rempel <linux@rempel-privat.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k_htc: use 'struct ath_htc_rx_status *' in call to ath9k_htc_err_stat_rx
Date: Mon, 19 May 2014 23:28:42 +0200 [thread overview]
Message-ID: <537A778A.5050205@rempel-privat.de> (raw)
In-Reply-To: <1400533670-23340-1-git-send-email-linville@tuxdriver.com>
Am 19.05.2014 23:07, schrieb John W. Linville:
> CC [M] drivers/net/wireless/ath/ath9k/htc_drv_txrx.o
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c: In function ?ath9k_rx_prepare?:
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:1006:2: warning: passing argument 2 of ?ath9k_htc_err_stat_rx? from incompatible pointer type [enabled by default]
> ath9k_htc_err_stat_rx(priv, &rx_stats);
> ^
> In file included from drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:17:0:
> drivers/net/wireless/ath/ath9k/htc.h:380:20: note: expected ?struct ath_htc_rx_status *? but argument is of type ?struct ath_rx_status *?
> static inline void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv,
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> Compile-test only...seems reasonable?
Hm... that is incorrect. Some missing patch?
"[PATCH 06/10] ath9k & ath9k_htc: move ath_rx_stats to cmn" did correct
change.
your patch will brake it.
>
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> index bb86eb2ffc95..c1490ddc2965 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> @@ -1003,7 +1003,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
> /* Copy everything from ath_htc_rx_status (HTC_RX_FRAME_HEADER).
> * After this, we can drop this part of skb. */
> rx_status_htc_to_ath(&rx_stats, rxstatus);
> - ath9k_htc_err_stat_rx(priv, &rx_stats);
> + ath9k_htc_err_stat_rx(priv, rxstatus);
> rx_status->mactime = be64_to_cpu(rxstatus->rs_tstamp);
> skb_pull(skb, HTC_RX_FRAME_HEADER_SIZE);
>
>
--
Regards,
Oleksij
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 278 bytes
Desc: OpenPGP digital signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20140519/3703bcbf/attachment.pgp
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <linux@rempel-privat.de>
To: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Cc: ath9k-devel@venema.h4ckr.net,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
Subject: Re: [ath9k-devel] [PATCH] ath9k_htc: use 'struct ath_htc_rx_status *' in call to ath9k_htc_err_stat_rx
Date: Mon, 19 May 2014 23:28:42 +0200 [thread overview]
Message-ID: <537A778A.5050205@rempel-privat.de> (raw)
In-Reply-To: <1400533670-23340-1-git-send-email-linville@tuxdriver.com>
[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]
Am 19.05.2014 23:07, schrieb John W. Linville:
> CC [M] drivers/net/wireless/ath/ath9k/htc_drv_txrx.o
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c: In function ‘ath9k_rx_prepare’:
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:1006:2: warning: passing argument 2 of ‘ath9k_htc_err_stat_rx’ from incompatible pointer type [enabled by default]
> ath9k_htc_err_stat_rx(priv, &rx_stats);
> ^
> In file included from drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:17:0:
> drivers/net/wireless/ath/ath9k/htc.h:380:20: note: expected ‘struct ath_htc_rx_status *’ but argument is of type ‘struct ath_rx_status *’
> static inline void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv,
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> Compile-test only...seems reasonable?
Hm... that is incorrect. Some missing patch?
"[PATCH 06/10] ath9k & ath9k_htc: move ath_rx_stats to cmn" did correct
change.
your patch will brake it.
>
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> index bb86eb2ffc95..c1490ddc2965 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> @@ -1003,7 +1003,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
> /* Copy everything from ath_htc_rx_status (HTC_RX_FRAME_HEADER).
> * After this, we can drop this part of skb. */
> rx_status_htc_to_ath(&rx_stats, rxstatus);
> - ath9k_htc_err_stat_rx(priv, &rx_stats);
> + ath9k_htc_err_stat_rx(priv, rxstatus);
> rx_status->mactime = be64_to_cpu(rxstatus->rs_tstamp);
> skb_pull(skb, HTC_RX_FRAME_HEADER_SIZE);
>
>
--
Regards,
Oleksij
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 278 bytes --]
next prev parent reply other threads:[~2014-05-19 21:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 21:07 [ath9k-devel] [PATCH] ath9k_htc: use 'struct ath_htc_rx_status *' in call to ath9k_htc_err_stat_rx John W. Linville
2014-05-19 21:07 ` John W. Linville
2014-05-19 21:28 ` Oleksij Rempel [this message]
2014-05-19 21:28 ` [ath9k-devel] " Oleksij Rempel
2014-05-19 21:41 ` John W. Linville
2014-05-19 21:41 ` John W. Linville
2014-05-19 22:00 ` Oleksij Rempel
2014-05-19 22:00 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A778A.5050205@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.