From: Richard Hansen <rhansen@bbn.com>
To: Junio C Hamano <gitster@pobox.com>,
"Jason St. John" <jstjohn@purdue.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] RelNotes/2.0.0.txt: Fix several grammar issues, notably a lack of hyphens, double quotes, or articles
Date: Tue, 20 May 2014 00:14:17 -0400 [thread overview]
Message-ID: <537AD699.8070503@bbn.com> (raw)
In-Reply-To: <xmqq1tvpuyas.fsf@gitster.dls.corp.google.com>
On 2014-05-19 19:46, Junio C Hamano wrote:
> "Jason St. John" <jstjohn@purdue.edu> writes:
>> @@ -53,7 +53,7 @@ Updates since v1.9 series
>> UI, Workflows & Features
>>
>> * The "multi-mail" post-receive hook (in contrib/) has been updated
>> - to a more recent version from the upstream.
>> + to a more recent version from upstream.
>
> Hmph, I have only one multi-mail upstream; shouldn't I call it "the"
> upstream from my point of view?
Plain "upstream" (without "the") is correct because it's an adverb, not
a noun. (Alternatively, this could be written "from the upstream
repository" or "from the upstream project".)
>> @@ -217,7 +218,7 @@ notes for details).
>> * "git diff --no-index -Mq a b" fell into an infinite loop.
>> (merge ad1c3fb jc/fix-diff-no-index-diff-opt-parse later to maint).
>>
>> - * "git fetch --prune", when the right-hand-side of multiple fetch
>> + * "git fetch --prune", when the right-hand side of multiple fetch
>> refspecs overlap (e.g. storing "refs/heads/*" to
>
> Hmph, I read this as a "right-hand", a multi-word adjective, is used
> to describe one "side" (the other side being the "left-hand side").
> Otherwise, you would be writing command-line-option, no?
Are you reading the diff backwards? (The second hyphen is being
removed, not added.)
-Richard
next prev parent reply other threads:[~2014-05-20 4:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 3:30 [PATCH] RelNotes/2.0.0.txt: Fix several grammar issues, notably a lack of hyphens, double quotes, or articles Jason St. John
2014-05-19 23:46 ` Junio C Hamano
2014-05-20 4:14 ` Richard Hansen [this message]
2014-05-20 4:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537AD699.8070503@bbn.com \
--to=rhansen@bbn.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jstjohn@purdue.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.