From: Junio C Hamano <gitster@pobox.com>
To: "Jason St. John" <jstjohn@purdue.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] RelNotes/2.0.0.txt: Fix several grammar issues, notably a lack of hyphens, double quotes, or articles
Date: Mon, 19 May 2014 16:46:35 -0700 [thread overview]
Message-ID: <xmqq1tvpuyas.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1400297434-30254-1-git-send-email-jstjohn@purdue.edu> (Jason St. John's message of "Fri, 16 May 2014 23:30:34 -0400")
"Jason St. John" <jstjohn@purdue.edu> writes:
> Signed-off-by: Jason St. John <jstjohn@purdue.edu>
> ---
Please accept "Thanks" for all the hunks I won't comment below; they
looked correct to me.
> @@ -53,7 +53,7 @@ Updates since v1.9 series
> UI, Workflows & Features
>
> * The "multi-mail" post-receive hook (in contrib/) has been updated
> - to a more recent version from the upstream.
> + to a more recent version from upstream.
Hmph, I have only one multi-mail upstream; shouldn't I call it "the"
upstream from my point of view?
> @@ -63,12 +63,13 @@ UI, Workflows & Features
> single strand-of-pearls is broken in its output.
>
> * The "rev-parse --parseopt" mechanism used by scripted Porcelains to
> - parse command line options and to give help text learned to take
> + parse command-line options and to give help text learned to take
We seem to have 30 "command line option" in Documentation/ vs 16
"command-line option", but this is two words used as an adjective,
and it may read better with the dash in between.
Thanks.
> @@ -190,20 +191,20 @@ notes for details).
>
> * The remote-helper interface to fast-import/fast-export via the
> transport-helper has been tightened to avoid leaving the import
> - marks file from a failed/crashed run, as such a file that is out of
> - sync with the reality confuses a later invocation of itself.
> + marks file from a failed/crashed run, as such a file that is out-of-
> + sync with reality confuses a later invocation of itself.
Likewise, but I somehow think this is borderline; the spelling
without hyphen is used frequently enough.
> @@ -217,7 +218,7 @@ notes for details).
> * "git diff --no-index -Mq a b" fell into an infinite loop.
> (merge ad1c3fb jc/fix-diff-no-index-diff-opt-parse later to maint).
>
> - * "git fetch --prune", when the right-hand-side of multiple fetch
> + * "git fetch --prune", when the right-hand side of multiple fetch
> refspecs overlap (e.g. storing "refs/heads/*" to
Hmph, I read this as a "right-hand", a multi-word adjective, is used
to describe one "side" (the other side being the "left-hand side").
Otherwise, you would be writing command-line-option, no?
> - * Codepaths that parse timestamps in commit objects have been
> + * Code paths that parse timestamps in commit objects have been
> tightened.
> (merge f80d1f9 jk/commit-dates-parsing-fix later to maint).
We seem to spell this as one-word in the documentation too often,
but "Code path" is the right form, I agree.
next prev parent reply other threads:[~2014-05-19 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 3:30 [PATCH] RelNotes/2.0.0.txt: Fix several grammar issues, notably a lack of hyphens, double quotes, or articles Jason St. John
2014-05-19 23:46 ` Junio C Hamano [this message]
2014-05-20 4:14 ` Richard Hansen
2014-05-20 4:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tvpuyas.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jstjohn@purdue.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.