All of lore.kernel.org
 help / color / mirror / Atom feed
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC V6 2/2] clk: Add handling of clk parent and rate assigned from DT
Date: Tue, 20 May 2014 13:49:39 +0200	[thread overview]
Message-ID: <537B4153.8030203@samsung.com> (raw)
In-Reply-To: <1400520171-6698-3-git-send-email-s.nawrocki@samsung.com>

On 19/05/14 19:22, Sylwester Nawrocki wrote:
> @@ -2620,7 +2639,10 @@ void __init of_clk_init(const struct of_device_id *matches)
>  		list_for_each_entry_safe(clk_provider, next,
>  					&clk_provider_list, node) {
>  			if (force || parent_ready(clk_provider->np)) {
> +
>  				clk_provider->clk_init_cb(clk_provider->np);
> +				of_clk_set_defaults(np, true);

There is an error in this patch, this line should read:

+				of_clk_set_defaults(clk_provider->np, true);

>  				list_del(&clk_provider->node);
>  				kfree(clk_provider);
>  				is_init_done = true;

WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH/RFC V6 2/2] clk: Add handling of clk parent and rate assigned from DT
Date: Tue, 20 May 2014 13:49:39 +0200	[thread overview]
Message-ID: <537B4153.8030203@samsung.com> (raw)
In-Reply-To: <1400520171-6698-3-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

On 19/05/14 19:22, Sylwester Nawrocki wrote:
> @@ -2620,7 +2639,10 @@ void __init of_clk_init(const struct of_device_id *matches)
>  		list_for_each_entry_safe(clk_provider, next,
>  					&clk_provider_list, node) {
>  			if (force || parent_ready(clk_provider->np)) {
> +
>  				clk_provider->clk_init_cb(clk_provider->np);
> +				of_clk_set_defaults(np, true);

There is an error in this patch, this line should read:

+				of_clk_set_defaults(clk_provider->np, true);

>  				list_del(&clk_provider->node);
>  				kfree(clk_provider);
>  				is_init_done = true;

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: mturquette@linaro.org, linux@arm.linux.org.uk,
	robh+dt@kernel.org, grant.likely@linaro.org,
	mark.rutland@arm.com, galak@codeaurora.org, pawel.moll@arm.com,
	kyungmin.park@samsung.com, sw0312.kim@samsung.com,
	m.szyprowski@samsung.com, t.figa@samsung.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC V6 2/2] clk: Add handling of clk parent and rate assigned from DT
Date: Tue, 20 May 2014 13:49:39 +0200	[thread overview]
Message-ID: <537B4153.8030203@samsung.com> (raw)
In-Reply-To: <1400520171-6698-3-git-send-email-s.nawrocki@samsung.com>

On 19/05/14 19:22, Sylwester Nawrocki wrote:
> @@ -2620,7 +2639,10 @@ void __init of_clk_init(const struct of_device_id *matches)
>  		list_for_each_entry_safe(clk_provider, next,
>  					&clk_provider_list, node) {
>  			if (force || parent_ready(clk_provider->np)) {
> +
>  				clk_provider->clk_init_cb(clk_provider->np);
> +				of_clk_set_defaults(np, true);

There is an error in this patch, this line should read:

+				of_clk_set_defaults(clk_provider->np, true);

>  				list_del(&clk_provider->node);
>  				kfree(clk_provider);
>  				is_init_done = true;


  reply	other threads:[~2014-05-20 11:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 17:22 [PATCH/RFC V6 0/2] clk: Default clk parents and rates assigned in DT Sylwester Nawrocki
2014-05-19 17:22 ` Sylwester Nawrocki
2014-05-19 17:22 ` Sylwester Nawrocki
2014-05-19 17:22 ` [PATCH/RFC V6 1/2] clk: Add of_clk_get_by_clkspec() helper Sylwester Nawrocki
2014-05-19 17:22   ` Sylwester Nawrocki
2014-05-19 17:22   ` Sylwester Nawrocki
2014-05-19 17:22 ` [PATCH/RFC V6 2/2] clk: Add handling of clk parent and rate assigned from DT Sylwester Nawrocki
2014-05-19 17:22   ` Sylwester Nawrocki
2014-05-19 17:22   ` Sylwester Nawrocki
2014-05-20 11:49   ` Sylwester Nawrocki [this message]
2014-05-20 11:49     ` Sylwester Nawrocki
2014-05-20 11:49     ` Sylwester Nawrocki
2014-05-23  1:35   ` Mike Turquette
2014-05-23  1:35     ` Mike Turquette
2014-05-23  1:35     ` Mike Turquette
2014-05-27 10:28   ` Tushar Behera
2014-05-27 10:28     ` Tushar Behera
2014-05-27 10:28     ` Tushar Behera
2014-06-13 15:08     ` Sylwester Nawrocki
2014-06-13 15:08       ` Sylwester Nawrocki
2014-06-13 15:08       ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537B4153.8030203@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.