* [PATCH 1/4] ARM: dts: exynos4210-trats: Enable USB gadget functionality
2014-05-20 12:46 [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats Marek Szyprowski
@ 2014-05-20 12:46 ` Marek Szyprowski
2014-05-20 12:46 ` [PATCH 2/4] ARM: dts: exynos4210-universal_c210: enable USB functionality Marek Szyprowski
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Marek Szyprowski @ 2014-05-20 12:46 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: Marek Szyprowski, Kukjin Kim, Tomasz Figa
From: Tomasz Figa <t.figa@samsung.com>
This patch adds device tree nodes necessary to enable USB gadget
functionality on Exynos4210-based Trats board.
Signed-off-by: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/boot/dts/exynos4210-trats.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 63aa2bb24a4b..f516da9e8b3a 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -88,6 +88,12 @@
};
};
+ hsotg@12480000 {
+ vusb_d-supply = <&vusb_reg>;
+ vusb_a-supply = <&vusbdac_reg>;
+ status = "okay";
+ };
+
sdhci_emmc: sdhci@12510000 {
bus-width = <8>;
non-removable;
@@ -97,6 +103,10 @@
status = "okay";
};
+ exynos-usbphy@125B0000 {
+ status = "okay";
+ };
+
serial@13800000 {
status = "okay";
};
--
1.9.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/4] ARM: dts: exynos4210-universal_c210: enable USB functionality
2014-05-20 12:46 [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats Marek Szyprowski
2014-05-20 12:46 ` [PATCH 1/4] ARM: dts: exynos4210-trats: Enable USB gadget functionality Marek Szyprowski
@ 2014-05-20 12:46 ` Marek Szyprowski
2014-05-20 22:48 ` Tomasz Figa
2014-05-20 12:47 ` [PATCH 3/4] ARM: dts: exynos4210-universal_c210: add multimedia nodes Marek Szyprowski
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Marek Szyprowski @ 2014-05-20 12:46 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: Marek Szyprowski, Kukjin Kim
This patch adds device tree nodes necessary to enable USB support on
universalc210 board, this includes UDC controller (USB gadget) as well
as EHCI and OHCI host ports. LDO3 and LDO8 regulators are switched to
always on mode until EHCI and OHCI drivers will support them correctly.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/boot/dts/exynos4210-universal_c210.dts | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index 9296dee10e26..0a32b396306c 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -68,6 +68,12 @@
enable-active-high;
};
+ hsotg@12480000 {
+ vusb_d-supply = <&ldo3_reg>;
+ vusb_a-supply = <&ldo8_reg>;
+ status = "okay";
+ };
+
sdhci_emmc: sdhci@12510000 {
bus-width = <8>;
non-removable;
@@ -77,6 +83,18 @@
status = "okay";
};
+ ehci@12580000 {
+ status = "okay";
+ };
+
+ ohci@12590000 {
+ status = "okay";
+ };
+
+ exynos-usbphy@125B0000 {
+ status = "okay";
+ };
+
serial@13800000 {
status = "okay";
};
@@ -216,6 +234,7 @@
regulator-name = "VUSB+MIPI_1.1V";
regulator-min-microvolt = <1100000>;
regulator-max-microvolt = <1100000>;
+ regulator-always-on;
};
ldo4_reg: LDO4 {
@@ -246,6 +265,7 @@
regulator-name = "VUSB+VDAC_3.3V";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
+ regulator-always-on;
};
ldo9_reg: LDO9 {
--
1.9.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/4] ARM: dts: exynos4210-universal_c210: enable USB functionality
2014-05-20 12:46 ` [PATCH 2/4] ARM: dts: exynos4210-universal_c210: enable USB functionality Marek Szyprowski
@ 2014-05-20 22:48 ` Tomasz Figa
0 siblings, 0 replies; 8+ messages in thread
From: Tomasz Figa @ 2014-05-20 22:48 UTC (permalink / raw)
To: Marek Szyprowski, linux-samsung-soc; +Cc: Kukjin Kim
Hi Marek,
On 20.05.2014 14:46, Marek Szyprowski wrote:
> This patch adds device tree nodes necessary to enable USB support on
> universalc210 board, this includes UDC controller (USB gadget) as well
> as EHCI and OHCI host ports. LDO3 and LDO8 regulators are switched to
> always on mode until EHCI and OHCI drivers will support them correctly.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> index 9296dee10e26..0a32b396306c 100644
> --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> @@ -68,6 +68,12 @@
> enable-active-high;
> };
>
> + hsotg@12480000 {
> + vusb_d-supply = <&ldo3_reg>;
> + vusb_a-supply = <&ldo8_reg>;
> + status = "okay";
> + };
> +
> sdhci_emmc: sdhci@12510000 {
> bus-width = <8>;
> non-removable;
> @@ -77,6 +83,18 @@
> status = "okay";
> };
>
> + ehci@12580000 {
> + status = "okay";
Shouldn't you also enable applicable ports here, so that required PHYs
are configured?
> + };
> +
> + ohci@12590000 {
> + status = "okay";
Ditto.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/4] ARM: dts: exynos4210-universal_c210: add multimedia nodes
2014-05-20 12:46 [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats Marek Szyprowski
2014-05-20 12:46 ` [PATCH 1/4] ARM: dts: exynos4210-trats: Enable USB gadget functionality Marek Szyprowski
2014-05-20 12:46 ` [PATCH 2/4] ARM: dts: exynos4210-universal_c210: enable USB functionality Marek Szyprowski
@ 2014-05-20 12:47 ` Marek Szyprowski
2014-05-20 12:47 ` [PATCH 4/4] ARM: dts: exynos4210-universal_c210: add external sd card node Marek Szyprowski
2014-05-20 22:49 ` [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats Tomasz Figa
4 siblings, 0 replies; 8+ messages in thread
From: Marek Szyprowski @ 2014-05-20 12:47 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: Marek Szyprowski, Kukjin Kim
This patch enables support for multimedia blocks - fimc in mem2mem mode,
no camera sensors support yet.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/boot/dts/exynos4210-universal_c210.dts | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index 0a32b396306c..c86a79edf367 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -448,6 +448,29 @@
compatible = "samsung,s5p6440-pwm";
status = "okay";
};
+
+ camera {
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <>;
+
+ fimc_0: fimc@11800000 {
+ status = "okay";
+ };
+
+ fimc_1: fimc@11810000 {
+ status = "okay";
+ };
+
+ fimc_2: fimc@11820000 {
+ status = "okay";
+ };
+
+ fimc_3: fimc@11830000 {
+ status = "okay";
+ };
+ };
};
&mdma1 {
--
1.9.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 4/4] ARM: dts: exynos4210-universal_c210: add external sd card node
2014-05-20 12:46 [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats Marek Szyprowski
` (2 preceding siblings ...)
2014-05-20 12:47 ` [PATCH 3/4] ARM: dts: exynos4210-universal_c210: add multimedia nodes Marek Szyprowski
@ 2014-05-20 12:47 ` Marek Szyprowski
2014-05-20 22:49 ` [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats Tomasz Figa
4 siblings, 0 replies; 8+ messages in thread
From: Marek Szyprowski @ 2014-05-20 12:47 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: Marek Szyprowski, Kukjin Kim
This patch enables support external SD card slot.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/boot/dts/exynos4210-universal_c210.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index c86a79edf367..81a6b1e017c4 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -83,6 +83,16 @@
status = "okay";
};
+ sdhci_sd: sdhci@12530000 {
+ bus-width = <4>;
+ pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4>;
+ pinctrl-names = "default";
+ vmmc-supply = <&ldo5_reg>;
+ cd-gpios = <&gpx3 4 0>;
+ cd-inverted;
+ status = "okay";
+ };
+
ehci@12580000 {
status = "okay";
};
--
1.9.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats
2014-05-20 12:46 [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats Marek Szyprowski
` (3 preceding siblings ...)
2014-05-20 12:47 ` [PATCH 4/4] ARM: dts: exynos4210-universal_c210: add external sd card node Marek Szyprowski
@ 2014-05-20 22:49 ` Tomasz Figa
2014-05-21 13:43 ` Kukjin Kim
4 siblings, 1 reply; 8+ messages in thread
From: Tomasz Figa @ 2014-05-20 22:49 UTC (permalink / raw)
To: Marek Szyprowski, linux-samsung-soc; +Cc: Kukjin Kim
On 20.05.2014 14:46, Marek Szyprowski wrote:
> Hello,
>
> This is a small update for Exynos4210 based UniversalC210 and Trats
> boards. Full USB support requires merging '[PATCHv5 0/4] Enable usbphy
> and hsotg for exynos4' series recently posted by Chanho Park.
>
> Best regards
> Marek Szyprowski
> Samsung R&D Institute Poland
>
> Marek Szyprowski (3):
> ARM: dts: exynos4210-universal_c210: enable USB functionality
> ARM: dts: exynos4210-universal_c210: add multimedia nodes
> ARM: dts: exynos4210-universal_c210: add external sd card node
>
> Tomasz Figa (1):
> ARM: dts: exynos4210-trats: Enable USB gadget functionality
>
> arch/arm/boot/dts/exynos4210-trats.dts | 10 +++++
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 53 +++++++++++++++++++++++++
> 2 files changed, 63 insertions(+)
>
For the whole series, after addressing comments for patch 2/4:
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats
2014-05-20 22:49 ` [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats Tomasz Figa
@ 2014-05-21 13:43 ` Kukjin Kim
0 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2014-05-21 13:43 UTC (permalink / raw)
To: 'Tomasz Figa', 'Marek Szyprowski',
linux-samsung-soc
Tomasz Figa wrote:
>
> On 20.05.2014 14:46, Marek Szyprowski wrote:
> > Hello,
> >
> > This is a small update for Exynos4210 based UniversalC210 and Trats
> > boards. Full USB support requires merging '[PATCHv5 0/4] Enable usbphy
> > and hsotg for exynos4' series recently posted by Chanho Park.
> >
> > Best regards
> > Marek Szyprowski
> > Samsung R&D Institute Poland
> >
> > Marek Szyprowski (3):
> > ARM: dts: exynos4210-universal_c210: enable USB functionality
> > ARM: dts: exynos4210-universal_c210: add multimedia nodes
> > ARM: dts: exynos4210-universal_c210: add external sd card node
> >
> > Tomasz Figa (1):
> > ARM: dts: exynos4210-trats: Enable USB gadget functionality
> >
> > arch/arm/boot/dts/exynos4210-trats.dts | 10 +++++
> > arch/arm/boot/dts/exynos4210-universal_c210.dts | 53
> +++++++++++++++++++++++++
> > 2 files changed, 63 insertions(+)
> >
>
> For the whole series, after addressing comments for patch 2/4:
>
Hi Marek,
Can you please re-spin soon?
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
Then, I will take this whole series.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread