From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 2/2] Documentation: add Broadcom STB Level-2 interrupt controller binding
Date: Tue, 20 May 2014 19:24:16 -0700 [thread overview]
Message-ID: <537C0E50.4050409@gmail.com> (raw)
In-Reply-To: <20140521013027.GD8664@titan.lakedaemon.net>
Le 20/05/2014 18:30, Jason Cooper a ?crit :
> On Tue, May 20, 2014 at 12:13:49PM -0700, Florian Fainelli wrote:
>> This patch adds the Device Tree binding document for the Broadcom
>> Set-top-box Level 2 interrupt controller hardware.
>>
>> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> .../bindings/interrupt-controller/brcm,l2-intc.txt | 29 ++++++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
>> new file mode 100644
>> index 000000000000..448273a30a11
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
>> @@ -0,0 +1,29 @@
>> +Broadcom Generic Level 2 Interrupt Controller
>> +
>> +Required properties:
>> +
>> +- compatible: should be "brcm,l2-intc"
>> +- reg: specifies the base physical address and size of the registers
>> +- interrupt-controller: identifies the node as an interrupt controller
>> +- #interrupt-cells: specifies the number of cells needed to encode an
>> + interrupt source. Should be 1.
>> +- interrupt-parent: specifies the phandle to the parent interrupt controller
>> + this controller is cacaded from
>> +- interrupts: specifies the interrupt line in the interrupt-parent irq space
>> + to be used for cascading
>> +
>> +Optional properties:
>> +
>> +- brcm,irq-can-wake: If present, this means the L2 controller can be used as a
>> + wakeup source for system suspend/resume.
>
> Do we need a vendor-specific property here? I'd much prefer to see a
> generic implementation.
Is there an usable generic property? We came up with a custom one
because there is not a generic one AFAICT.
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Randy Dunlap <rdunlap@infradead.org>,
DOCUMENTATION <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
arm@kernel.org, Kumar Gala <galak@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,
Brian Norris <computersforpeace@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND 2/2] Documentation: add Broadcom STB Level-2 interrupt controller binding
Date: Tue, 20 May 2014 19:24:16 -0700 [thread overview]
Message-ID: <537C0E50.4050409@gmail.com> (raw)
In-Reply-To: <20140521013027.GD8664@titan.lakedaemon.net>
Le 20/05/2014 18:30, Jason Cooper a écrit :
> On Tue, May 20, 2014 at 12:13:49PM -0700, Florian Fainelli wrote:
>> This patch adds the Device Tree binding document for the Broadcom
>> Set-top-box Level 2 interrupt controller hardware.
>>
>> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> .../bindings/interrupt-controller/brcm,l2-intc.txt | 29 ++++++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
>> new file mode 100644
>> index 000000000000..448273a30a11
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
>> @@ -0,0 +1,29 @@
>> +Broadcom Generic Level 2 Interrupt Controller
>> +
>> +Required properties:
>> +
>> +- compatible: should be "brcm,l2-intc"
>> +- reg: specifies the base physical address and size of the registers
>> +- interrupt-controller: identifies the node as an interrupt controller
>> +- #interrupt-cells: specifies the number of cells needed to encode an
>> + interrupt source. Should be 1.
>> +- interrupt-parent: specifies the phandle to the parent interrupt controller
>> + this controller is cacaded from
>> +- interrupts: specifies the interrupt line in the interrupt-parent irq space
>> + to be used for cascading
>> +
>> +Optional properties:
>> +
>> +- brcm,irq-can-wake: If present, this means the L2 controller can be used as a
>> + wakeup source for system suspend/resume.
>
> Do we need a vendor-specific property here? I'd much prefer to see a
> generic implementation.
Is there an usable generic property? We came up with a custom one
because there is not a generic one AFAICT.
next prev parent reply other threads:[~2014-05-21 2:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 19:13 [PATCH RESEND 0/2] irqchip: Broadcom Set Top Box Level-2 interrupt controller Florian Fainelli
2014-05-20 19:13 ` Florian Fainelli
2014-05-20 19:13 ` [PATCH RESEND 1/2] irqchip: add " Florian Fainelli
2014-05-20 19:13 ` Florian Fainelli
2014-05-21 1:27 ` Jason Cooper
2014-05-20 19:13 ` [PATCH RESEND 2/2] Documentation: add Broadcom STB Level-2 interrupt controller binding Florian Fainelli
2014-05-20 19:13 ` Florian Fainelli
2014-05-21 1:30 ` Jason Cooper
2014-05-21 2:24 ` Florian Fainelli [this message]
2014-05-21 2:24 ` Florian Fainelli
2014-05-22 11:53 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537C0E50.4050409@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.