* [PATCH] Mark the generated service file avaliable to be accessed
@ 2014-05-21 7:21 dongmao zhang
2014-05-21 8:13 ` Peter Rajnoha
0 siblings, 1 reply; 2+ messages in thread
From: dongmao zhang @ 2014-05-21 7:21 UTC (permalink / raw)
To: lvm-devel
'journalctl -b' reports this:
May 17 08:21:00 test systemd[1]: Configuration file
/run/systemd/generator/lvm2-activation-early.service is marked
world-inaccessible. This has no effect as configuration data is
accessible via
APIs without restrictions. Proceeding anyway.
So, set the mask to 022 for all the generators
---
scripts/lvm2_activation_generator_systemd_red_hat.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/lvm2_activation_generator_systemd_red_hat.c b/scripts/lvm2_activation_generator_systemd_red_hat.c
index e39f901..6a003f5 100644
--- a/scripts/lvm2_activation_generator_systemd_red_hat.c
+++ b/scripts/lvm2_activation_generator_systemd_red_hat.c
@@ -170,6 +170,7 @@ int main(int argc, char *argv[])
{
const char *dir;
int r = EXIT_SUCCESS;
+ mode_t old_mask;
kmsg_fd = open(KMSG_DEV_PATH, O_WRONLY|O_NOCTTY);
@@ -184,10 +185,13 @@ int main(int argc, char *argv[])
dir = argv[1];
+ /* mark lvm2-activation.*.service as world-accessible */
+ old_mask = umask(0022);
if (!generate_unit(dir, UNIT_EARLY) ||
!generate_unit(dir, UNIT_MAIN) ||
!generate_unit(dir, UNIT_NET))
r = EXIT_FAILURE;
+ umask(old_mask);
out:
if (r)
kmsg(LOG_ERR, "LVM: Activation generator failed.\n");
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] Mark the generated service file avaliable to be accessed
2014-05-21 7:21 [PATCH] Mark the generated service file avaliable to be accessed dongmao zhang
@ 2014-05-21 8:13 ` Peter Rajnoha
0 siblings, 0 replies; 2+ messages in thread
From: Peter Rajnoha @ 2014-05-21 8:13 UTC (permalink / raw)
To: lvm-devel
On 05/21/2014 09:21 AM, dongmao zhang wrote:
> 'journalctl -b' reports this:
> May 17 08:21:00 test systemd[1]: Configuration file
> /run/systemd/generator/lvm2-activation-early.service is marked
> world-inaccessible. This has no effect as configuration data is
> accessible via
> APIs without restrictions. Proceeding anyway.
>
> So, set the mask to 022 for all the generators
> ---
> scripts/lvm2_activation_generator_systemd_red_hat.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/lvm2_activation_generator_systemd_red_hat.c b/scripts/lvm2_activation_generator_systemd_red_hat.c
> index e39f901..6a003f5 100644
> --- a/scripts/lvm2_activation_generator_systemd_red_hat.c
> +++ b/scripts/lvm2_activation_generator_systemd_red_hat.c
> @@ -170,6 +170,7 @@ int main(int argc, char *argv[])
> {
> const char *dir;
> int r = EXIT_SUCCESS;
> + mode_t old_mask;
>
> kmsg_fd = open(KMSG_DEV_PATH, O_WRONLY|O_NOCTTY);
>
> @@ -184,10 +185,13 @@ int main(int argc, char *argv[])
>
> dir = argv[1];
>
> + /* mark lvm2-activation.*.service as world-accessible */
> + old_mask = umask(0022);
> if (!generate_unit(dir, UNIT_EARLY) ||
> !generate_unit(dir, UNIT_MAIN) ||
> !generate_unit(dir, UNIT_NET))
> r = EXIT_FAILURE;
> + umask(old_mask);
> out:
> if (r)
> kmsg(LOG_ERR, "LVM: Activation generator failed.\n");
>
Applied. Thanks for the patch!
https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=e9db11f387086787fb1aad5a853990e9e6034ad5
--
Peter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-21 8:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-21 7:21 [PATCH] Mark the generated service file avaliable to be accessed dongmao zhang
2014-05-21 8:13 ` Peter Rajnoha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.