From: Emil Velikov <emil.l.velikov@gmail.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: "mesa-dev@lists.freedesktop.org" <mesa-dev@lists.freedesktop.org>,
emil.l.velikov@gmail.com,
"10.2" <mesa-stable@lists.freedesktop.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>
Subject: Re: [PATCH 02/12] nv50: setup scissors on clear_render_target/depth_stencil
Date: Wed, 21 May 2014 20:06:40 +0100 [thread overview]
Message-ID: <537CF940.7030100@gmail.com> (raw)
In-Reply-To: <CAKb7UviDcjazdQv3S7zz=+eTT1JziWrUCVuYxsSFFmQn3kSMnA@mail.gmail.com>
On 21/05/14 19:59, Ilia Mirkin wrote:
> On Wed, May 21, 2014 at 2:57 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>> On 21/05/14 00:39, Ilia Mirkin wrote:
>>> From: Christoph Bumiller <e0425955@student.tuwien.ac.at>
>>>
>>> [imirkin: add logic to also clear the "regular" scissors]
>> Can you please share why are you've added the "regular" scissors ?
>
> Because I had to when I was implementing the clear_texture and
> clear_buffer hooks (clear_texture didn't end up making it in quite yet
> because I suck at writing piglit tests, but clear_buffer is there
> now). Basically if scissors are set, they will apply to the clear,
> which is not what we want.
>
>> Does it matter if we set the screen scissors before the render target params?
>
> AFAIK, with the exception of a few "go" methods, you can pretty much
> randomize the order in which you set all parameters.
>
Great, thank you.
next prev parent reply other threads:[~2014-05-21 19:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 23:39 [PATCH 00/12] Cherry-pick nv50/nvc0 patches from gallium-nine Ilia Mirkin
2014-05-20 23:39 ` [PATCH 02/12] nv50: setup scissors on clear_render_target/depth_stencil Ilia Mirkin
[not found] ` <1400629206-4447-3-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2014-05-21 18:57 ` [Mesa-dev] " Emil Velikov
[not found] ` <537CF70A.4000905-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-21 18:59 ` Ilia Mirkin
2014-05-21 19:06 ` Emil Velikov [this message]
2014-05-20 23:39 ` [PATCH 03/12] nv50, nvc0: set constbufs dirty on pipe context switch Ilia Mirkin
2014-05-20 23:39 ` [PATCH 05/12] nv50/ir/opt: fix constant folding with saturate modifier Ilia Mirkin
2014-05-20 23:40 ` [PATCH 07/12] nv50/ir/tgsi: optimize KIL Ilia Mirkin
[not found] ` <1400629206-4447-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2014-05-20 23:39 ` [PATCH 01/12] nv50, nvc0: always pull out bufctx on context destruction Ilia Mirkin
2014-05-20 23:39 ` [PATCH 04/12] nv50/ir/tgsi: TGSI_OPCODE_POW replicates its result Ilia Mirkin
2014-05-21 18:51 ` Emil Velikov
[not found] ` <537CF597.4080406-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-21 18:53 ` [Mesa-dev] " Ilia Mirkin
[not found] ` <CAKb7Uvj1EomVeAwqFdguuP9xQ1dDkRGDVc9N7239b8O+aL-VrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-21 19:01 ` Emil Velikov
[not found] ` <537CF7F7.1010504-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-21 19:03 ` Ilia Mirkin
[not found] ` <CAKb7UvgQ3Pz8CUFTGi16x+Ay=0PezJrOuw0kWXLf-rnDeLCgDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-21 19:04 ` Ilia Mirkin
2014-05-20 23:40 ` [PATCH 06/12] nv50/ir: fix lowering of predicated instructions (without defs) Ilia Mirkin
2014-05-20 23:40 ` [PATCH 08/12] nv50,nvc0: handle guard band defines Ilia Mirkin
2014-05-20 23:40 ` [PATCH 09/12] nv50, nvc0: allow 15, 16, 30 bpp display formats Ilia Mirkin
2014-05-20 23:40 ` [PATCH 10/12] nvc0: use PRIxPTR for sizeof() Ilia Mirkin
2014-05-20 23:40 ` [PATCH 11/12] nvc0: assert that we have vertex elements state Ilia Mirkin
2014-05-20 23:40 ` [PATCH 12/12] nv50: count wrapped textures towards the tex_obj count Ilia Mirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537CF940.7030100@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=imirkin@alum.mit.edu \
--cc=mesa-dev@lists.freedesktop.org \
--cc=mesa-stable@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.