All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tushar Behera <tushar.behera@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Kukjin Kim <kgene.kim@samsung.com>, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 1/1] ARM: EXYNOS: Fix compilation warning
Date: Thu, 22 May 2014 08:59:22 +0530	[thread overview]
Message-ID: <537D6F12.7000201@linaro.org> (raw)
In-Reply-To: <CAK9yfHyFEb3hchLLndfqW1xOHD59d_bsFMA4k5MLJ8Hgpx7Ekw@mail.gmail.com>

On 05/21/2014 04:56 PM, Sachin Kamat wrote:
> On 5 May 2014 14:56, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> of_get_flat_dt_prop return type is now const.
>> Fixes the following compilation warning introduced by commit 9d0c4dfedd96
>> ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")
>>
>> arch/arm/mach-exynos/exynos.c:259:6: warning:
>> assignment discards ‘const’ qualifier from pointer target type [enabled by default]
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> ---

Change looks good.

Reviewed-by: Tushar Behera <tushar.behera@linaro.org>

>> Based on linux-next (20140505)
>> ---
>>  arch/arm/mach-exynos/exynos.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
>> index 77293d39dfc9..f356c67a1fa9 100644
>> --- a/arch/arm/mach-exynos/exynos.c
>> +++ b/arch/arm/mach-exynos/exynos.c
>> @@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
>>                                         int depth, void *data)
>>  {
>>         struct map_desc iodesc;
>> -       __be32 *reg;
>> +       const __be32 *reg;
>>         int len;
>>
>>         if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
>> --
>> 1.7.9.5
>>
> 
> Ping. This warning is still seen in latest linux-next.
> 


-- 
Tushar Behera

WARNING: multiple messages have this Message-ID (diff)
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: EXYNOS: Fix compilation warning
Date: Thu, 22 May 2014 08:59:22 +0530	[thread overview]
Message-ID: <537D6F12.7000201@linaro.org> (raw)
In-Reply-To: <CAK9yfHyFEb3hchLLndfqW1xOHD59d_bsFMA4k5MLJ8Hgpx7Ekw@mail.gmail.com>

On 05/21/2014 04:56 PM, Sachin Kamat wrote:
> On 5 May 2014 14:56, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> of_get_flat_dt_prop return type is now const.
>> Fixes the following compilation warning introduced by commit 9d0c4dfedd96
>> ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")
>>
>> arch/arm/mach-exynos/exynos.c:259:6: warning:
>> assignment discards ?const? qualifier from pointer target type [enabled by default]
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> ---

Change looks good.

Reviewed-by: Tushar Behera <tushar.behera@linaro.org>

>> Based on linux-next (20140505)
>> ---
>>  arch/arm/mach-exynos/exynos.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
>> index 77293d39dfc9..f356c67a1fa9 100644
>> --- a/arch/arm/mach-exynos/exynos.c
>> +++ b/arch/arm/mach-exynos/exynos.c
>> @@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
>>                                         int depth, void *data)
>>  {
>>         struct map_desc iodesc;
>> -       __be32 *reg;
>> +       const __be32 *reg;
>>         int len;
>>
>>         if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
>> --
>> 1.7.9.5
>>
> 
> Ping. This warning is still seen in latest linux-next.
> 


-- 
Tushar Behera

  reply	other threads:[~2014-05-22  3:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05  9:26 [PATCH 1/1] ARM: EXYNOS: Fix compilation warning Sachin Kamat
2014-05-05  9:26 ` Sachin Kamat
2014-05-21 11:26 ` Sachin Kamat
2014-05-21 11:26   ` Sachin Kamat
2014-05-22  3:29   ` Tushar Behera [this message]
2014-05-22  3:29     ` Tushar Behera
2014-06-13 14:52     ` Arnd Bergmann
2014-06-13 14:52       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537D6F12.7000201@linaro.org \
    --to=tushar.behera@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.