* Re: [Qemu-ppc] [PATCH] openpic: Initialize destmask at reset [not found] ` <859BC03D-7C6A-434B-87D3-7A51615970FC@suse.de> @ 2014-05-22 10:15 ` Alexander Graf 0 siblings, 0 replies; 2+ messages in thread From: Alexander Graf @ 2014-05-22 10:15 UTC (permalink / raw) To: Paul Janzen; +Cc: Scott Wood, qemu-ppc@nongnu.org, qemu-devel, kvm-ppc On 21.05.14 21:47, Alexander Graf wrote: > >> Am 21.05.2014 um 18:33 schrieb Paul Janzen <pcj@pauljanzen.org>: >> >>> On Wed, May 21, 2014 at 12:45 AM, Alexander Graf <agraf@suse.de> wrote: >>> >>> Or maybe it's safer overall to just call write_IRQreg_idr() instead of >>> setting idr directly? That would update destmask along the way as well and >>> we would catch all subtle corner cases. >> I considered this initially but decided to go with the simpler >> approach. But you have convinced me. Specifically, the current >> implementation does not reset src->output or src->nomask, which >> write_IRQreg_idr() will. I will test this change and re-submit the >> patch. >> >>> Do you have a simple test case for this patch? We seem to have the same bug >>> in the in-kernel KVM MPIC emulation code and I'd like to have it fixed there >>> as well, but I don't really like to do that change blindly. >> I have tested this patch using a proprietary embedded operating system >> which doesn't bother to initialize the IDR registers. > Do you think it'd be possible for you to test whether it works with kvm when I give you a patch? Do you have real hardware to run kvm on? :) I just checked - we don't properly implement reset at all in the in-kernel MPIC we do in KVM. So it's merely something to keep in mind for now until someone sits down and implements proper reset support ;). Alex ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH] openpic: Initialize destmask at reset @ 2014-05-22 10:15 ` Alexander Graf 0 siblings, 0 replies; 2+ messages in thread From: Alexander Graf @ 2014-05-22 10:15 UTC (permalink / raw) To: Paul Janzen; +Cc: Scott Wood, qemu-ppc@nongnu.org, qemu-devel, kvm-ppc On 21.05.14 21:47, Alexander Graf wrote: > >> Am 21.05.2014 um 18:33 schrieb Paul Janzen <pcj@pauljanzen.org>: >> >>> On Wed, May 21, 2014 at 12:45 AM, Alexander Graf <agraf@suse.de> wrote: >>> >>> Or maybe it's safer overall to just call write_IRQreg_idr() instead of >>> setting idr directly? That would update destmask along the way as well and >>> we would catch all subtle corner cases. >> I considered this initially but decided to go with the simpler >> approach. But you have convinced me. Specifically, the current >> implementation does not reset src->output or src->nomask, which >> write_IRQreg_idr() will. I will test this change and re-submit the >> patch. >> >>> Do you have a simple test case for this patch? We seem to have the same bug >>> in the in-kernel KVM MPIC emulation code and I'd like to have it fixed there >>> as well, but I don't really like to do that change blindly. >> I have tested this patch using a proprietary embedded operating system >> which doesn't bother to initialize the IDR registers. > Do you think it'd be possible for you to test whether it works with kvm when I give you a patch? Do you have real hardware to run kvm on? :) I just checked - we don't properly implement reset at all in the in-kernel MPIC we do in KVM. So it's merely something to keep in mind for now until someone sits down and implements proper reset support ;). Alex ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-22 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CACjCS-9i6AueCvmY7AFmCHx4kPimjcnDon2d=JEc5b7q_btQQw@mail.gmail.com>
[not found] ` <859BC03D-7C6A-434B-87D3-7A51615970FC@suse.de>
2014-05-22 10:15 ` [Qemu-ppc] [PATCH] openpic: Initialize destmask at reset Alexander Graf
2014-05-22 10:15 ` [Qemu-devel] " Alexander Graf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.