From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
michael@ellerman.id.au, mingo@redhat.com, paulus@samba.org,
imunsie@au1.ibm.com, acme@ghostprotocols.net,
scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations
Date: Thu, 22 May 2014 15:43:47 -0700 [thread overview]
Message-ID: <537E7DA3.6030705@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140523083847.4e039ddb@canb.auug.org.au>
On 05/22/2014 03:38 PM, Stephen Rothwell wrote:
> Hi Cody,
>
> On Thu, 22 May 2014 15:29:08 -0700 Cody P Schafer <cody@linux.vnet.ibm.com> wrote:
>>
>> - *res = be64_to_cpu(result_buffer.result);
>> + *res = be64_to_cpu(result_buffer->result);
>> + kfree(result_buffer);
>> + kfree(request_buffer);
>> + return ret;
>
> Why not just fall through here by removing the above 3 lines?
No reason except me not noticing it.
>> +
>> +out_hcall:
>> + kfree(result_buffer);
>> +out_resb:
>> + kfree(request_buffer);
>> +out_reqb:
>> return ret;
>> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
peterz@infradead.org, linux-kernel@vger.kernel.org,
michael@ellerman.id.au, mingo@redhat.com, paulus@samba.org,
imunsie@au1.ibm.com, acme@ghostprotocols.net,
scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations
Date: Thu, 22 May 2014 15:43:47 -0700 [thread overview]
Message-ID: <537E7DA3.6030705@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140523083847.4e039ddb@canb.auug.org.au>
On 05/22/2014 03:38 PM, Stephen Rothwell wrote:
> Hi Cody,
>
> On Thu, 22 May 2014 15:29:08 -0700 Cody P Schafer <cody@linux.vnet.ibm.com> wrote:
>>
>> - *res = be64_to_cpu(result_buffer.result);
>> + *res = be64_to_cpu(result_buffer->result);
>> + kfree(result_buffer);
>> + kfree(request_buffer);
>> + return ret;
>
> Why not just fall through here by removing the above 3 lines?
No reason except me not noticing it.
>> +
>> +out_hcall:
>> + kfree(result_buffer);
>> +out_resb:
>> + kfree(request_buffer);
>> +out_reqb:
>> return ret;
>> }
>
next prev parent reply other threads:[~2014-05-22 22:43 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 0:00 [PATCH v4 00/11] powerpc: Add support for Power Hypervisor supplied performance counters Cody P Schafer
2014-03-06 0:00 ` Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 01/11] sysfs: create bin_attributes under the requested group Cody P Schafer
2014-03-06 0:01 ` Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 02/11] perf: add PMU_FORMAT_RANGE() helper for use by sw-like pmus Cody P Schafer
2014-03-06 0:01 ` Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 03/11] perf: provide a common perf_event_nop_0() for use with .event_idx Cody P Schafer
2014-03-06 0:01 ` Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 04/11] powerpc: add hvcalls for 24x7 and gpci (get performance counter info) Cody P Schafer
2014-03-06 0:01 ` Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 05/11] powerpc/perf: add hv_gpci interface header Cody P Schafer
2014-03-06 0:01 ` Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 06/11] powerpc/perf: add 24x7 interface headers Cody P Schafer
2014-03-06 0:01 ` Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 07/11] powerpc/perf: add a shared interface to get gpci version and capabilities Cody P Schafer
2014-03-06 0:01 ` Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 08/11] powerpc/perf: add support for the hv gpci (get performance counter info) interface Cody P Schafer
2014-03-06 0:01 ` Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 09/11] powerpc/perf: add support for the hv 24x7 interface Cody P Schafer
2014-03-06 0:01 ` Cody P Schafer
2014-03-25 10:43 ` Anton Blanchard
2014-03-25 10:43 ` Anton Blanchard
2014-03-25 18:19 ` Cody P Schafer
2014-03-25 18:19 ` Cody P Schafer
2014-03-25 18:32 ` Cody P Schafer
2014-03-25 18:32 ` Cody P Schafer
2014-03-26 9:43 ` David Laight
2014-03-26 9:43 ` David Laight
2014-05-22 8:19 ` Ian Munsie
2014-05-22 8:19 ` Ian Munsie
2014-05-22 22:22 ` Cody P Schafer
2014-05-22 22:22 ` Cody P Schafer
2014-05-22 22:29 ` [PATCH] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations Cody P Schafer
2014-05-22 22:29 ` Cody P Schafer
2014-05-22 22:38 ` Stephen Rothwell
2014-05-22 22:38 ` Stephen Rothwell
2014-05-22 22:43 ` Cody P Schafer [this message]
2014-05-22 22:43 ` Cody P Schafer
2014-05-22 22:44 ` [PATCH v2] " Cody P Schafer
2014-05-22 22:44 ` Cody P Schafer
2014-05-22 23:49 ` Stephen Rothwell
2014-05-22 23:49 ` Stephen Rothwell
2014-05-22 23:54 ` Cody P Schafer
2014-05-22 23:54 ` Cody P Schafer
2014-05-23 0:20 ` Stephen Rothwell
2014-05-23 0:20 ` Stephen Rothwell
2014-03-06 0:01 ` [PATCH v4 10/11] powerpc/perf: add kconfig option for hypervisor provided counters Cody P Schafer
2014-03-06 0:01 ` Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 11/11] powerpc/perf/hv_{gpci, 24x7}: add documentation of device attributes Cody P Schafer
2014-03-06 0:01 ` [PATCH v4 11/11] powerpc/perf/hv_{gpci,24x7}: " Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537E7DA3.6030705@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=acme@ghostprotocols.net \
--cc=imunsie@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=scottwood@freescale.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.