All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: 3.15.0-rc6: VM_BUG_ON_PAGE(PageTail(page), page)
Date: Fri, 23 May 2014 11:45:06 +0200	[thread overview]
Message-ID: <537F18A2.4010709@suse.cz> (raw)
In-Reply-To: <20140522154100.GA30273@redhat.com>

On 05/22/2014 05:41 PM, Dave Jones wrote:
> On Thu, May 22, 2014 at 05:08:09PM +0200, Vlastimil Babka wrote:
>
>   > > RIP: 0010:[<ffffffffbb718d98>]  [<ffffffffbb718d98>] PageTransHuge.part.23+0xb/0xd
>   > > Call Trace:
>   > >   [<ffffffffbb1728a3>] isolate_migratepages_range+0x7a3/0x870
>   > >   [<ffffffffbb172d90>] compact_zone+0x370/0x560
>   > >   [<ffffffffbb173022>] compact_zone_order+0xa2/0x110
>   > >   [<ffffffffbb1733f1>] try_to_compact_pages+0x101/0x130
>   > > ...
>   > > Code: 75 1d 55 be 6c 00 00 00 48 c7 c7 8a 2f a2 bb 48 89 e5 e8 6c 49 95 ff 5d c6 05 74 16 65 00 01 c3 55 31 f6 48 89 e5 e8 28 bd a3 ff <0f> 0b 0f 1f 44 00 00 55 48 89 e5 41 57 45 31 ff 41 56 49 89 fe
>   > > RIP  [<ffffffffbb718d98>]
>   > >
>   > > That BUG is..
>   > >
>   > > 413 static inline int PageTransHuge(struct page *page)
>   > > 414 {
>   > > 415         VM_BUG_ON_PAGE(PageTail(page), page);
>   > > 416         return PageHead(page);
>   > > 417 }
>   >
>   > Any idea which of the two PageTransHuge() calls in
>   > isolate_migratepages_range() that is? Offset far in the function suggest
>   > it's where the lru lock is already held, but I'm not sure as decodecode
>   > of your dump and objdump of my own compile look widely different.
>
> Yeah, the only thing the code: matches is the BUG() which is in another section.

Oh right, it's not a simple BUG_ON that would be inlined.

> (see end of file at http://paste.fedoraproject.org/104155/40077293/raw/)
>
> Maybe you can make more sense of that disassembly than I can..

Could you try adding -r to objdump, as now I have no idea where all 
those calls go :/

> 	Dave
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: 3.15.0-rc6: VM_BUG_ON_PAGE(PageTail(page), page)
Date: Fri, 23 May 2014 11:45:06 +0200	[thread overview]
Message-ID: <537F18A2.4010709@suse.cz> (raw)
In-Reply-To: <20140522154100.GA30273@redhat.com>

On 05/22/2014 05:41 PM, Dave Jones wrote:
> On Thu, May 22, 2014 at 05:08:09PM +0200, Vlastimil Babka wrote:
>
>   > > RIP: 0010:[<ffffffffbb718d98>]  [<ffffffffbb718d98>] PageTransHuge.part.23+0xb/0xd
>   > > Call Trace:
>   > >   [<ffffffffbb1728a3>] isolate_migratepages_range+0x7a3/0x870
>   > >   [<ffffffffbb172d90>] compact_zone+0x370/0x560
>   > >   [<ffffffffbb173022>] compact_zone_order+0xa2/0x110
>   > >   [<ffffffffbb1733f1>] try_to_compact_pages+0x101/0x130
>   > > ...
>   > > Code: 75 1d 55 be 6c 00 00 00 48 c7 c7 8a 2f a2 bb 48 89 e5 e8 6c 49 95 ff 5d c6 05 74 16 65 00 01 c3 55 31 f6 48 89 e5 e8 28 bd a3 ff <0f> 0b 0f 1f 44 00 00 55 48 89 e5 41 57 45 31 ff 41 56 49 89 fe
>   > > RIP  [<ffffffffbb718d98>]
>   > >
>   > > That BUG is..
>   > >
>   > > 413 static inline int PageTransHuge(struct page *page)
>   > > 414 {
>   > > 415         VM_BUG_ON_PAGE(PageTail(page), page);
>   > > 416         return PageHead(page);
>   > > 417 }
>   >
>   > Any idea which of the two PageTransHuge() calls in
>   > isolate_migratepages_range() that is? Offset far in the function suggest
>   > it's where the lru lock is already held, but I'm not sure as decodecode
>   > of your dump and objdump of my own compile look widely different.
>
> Yeah, the only thing the code: matches is the BUG() which is in another section.

Oh right, it's not a simple BUG_ON that would be inlined.

> (see end of file at http://paste.fedoraproject.org/104155/40077293/raw/)
>
> Maybe you can make more sense of that disassembly than I can..

Could you try adding -r to objdump, as now I have no idea where all 
those calls go :/

> 	Dave
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>


  reply	other threads:[~2014-05-23  9:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 13:58 3.15.0-rc6: VM_BUG_ON_PAGE(PageTail(page), page) Dave Jones
2014-05-22 13:58 ` Dave Jones
2014-05-22 15:08 ` Vlastimil Babka
2014-05-22 15:08   ` Vlastimil Babka
2014-05-22 15:41   ` Dave Jones
2014-05-22 15:41     ` Dave Jones
2014-05-23  9:45     ` Vlastimil Babka [this message]
2014-05-23  9:45       ` Vlastimil Babka
2014-05-23  4:21 ` Sasha Levin
2014-05-23  4:21   ` Sasha Levin
2014-05-23  5:54   ` Vlastimil Babka
2014-05-23  5:54     ` Vlastimil Babka
2014-05-23  9:16   ` Kirill A. Shutemov
2014-05-23  9:16     ` Kirill A. Shutemov
2014-05-23 13:54     ` Sasha Levin
2014-05-23 13:54       ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537F18A2.4010709@suse.cz \
    --to=vbabka@suse.cz \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.