From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: mikey@neuling.org, avagin@openvz.org,
linux-kernel@vger.kernel.org, oleg@redhat.com,
michael@ellerman.id.au, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH V2 2/3] powerpc, ptrace: Enable support for transactional memory register sets
Date: Fri, 23 May 2014 19:27:18 +0530 [thread overview]
Message-ID: <537F53BE.8030105@linux.vnet.ibm.com> (raw)
In-Reply-To: <537D8641.8090600@linux.vnet.ibm.com>
On 05/22/2014 10:38 AM, Anshuman Khandual wrote:
> I agree.
>
>> >
>> > Maybe we should leave this for another day, and have tm_spr_active
>> > return 0 instead of -ENODEV when the machine doesn't have the hardware,
>> > or not install that hook at all. Seems like the effect will be the same,
>> > as the note isn't output if ->get fails.
> Agree. Active hooks which return 0 in case of -ENODEV sounds good to me and shall
> incorporate this in the next version.
>
But from "user_regset_active_fn" definition point of view -ENODEV is the right thing
to do even if we dont use it specifically compared to the return value of 0.
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: mikey@neuling.org, avagin@openvz.org, oleg@redhat.com,
linux-kernel@vger.kernel.org, michael@ellerman.id.au,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH V2 2/3] powerpc, ptrace: Enable support for transactional memory register sets
Date: Fri, 23 May 2014 19:27:18 +0530 [thread overview]
Message-ID: <537F53BE.8030105@linux.vnet.ibm.com> (raw)
In-Reply-To: <537D8641.8090600@linux.vnet.ibm.com>
On 05/22/2014 10:38 AM, Anshuman Khandual wrote:
> I agree.
>
>> >
>> > Maybe we should leave this for another day, and have tm_spr_active
>> > return 0 instead of -ENODEV when the machine doesn't have the hardware,
>> > or not install that hook at all. Seems like the effect will be the same,
>> > as the note isn't output if ->get fails.
> Agree. Active hooks which return 0 in case of -ENODEV sounds good to me and shall
> incorporate this in the next version.
>
But from "user_regset_active_fn" definition point of view -ENODEV is the right thing
to do even if we dont use it specifically compared to the return value of 0.
next prev parent reply other threads:[~2014-05-23 13:59 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 7:54 [PATCH V2 0/3] Add new PowerPC specific ELF core notes Anshuman Khandual
2014-05-05 7:54 ` Anshuman Khandual
2014-05-05 7:54 ` [PATCH V2 1/3] elf: Add some new PowerPC specifc note sections Anshuman Khandual
2014-05-05 7:54 ` Anshuman Khandual
2014-05-05 7:54 ` [PATCH V2 2/3] powerpc, ptrace: Enable support for transactional memory register sets Anshuman Khandual
2014-05-05 7:54 ` Anshuman Khandual
2014-05-13 17:13 ` Pedro Alves
2014-05-14 5:46 ` Anshuman Khandual
2014-05-14 5:46 ` Anshuman Khandual
2014-05-14 11:15 ` Pedro Alves
2014-05-14 11:15 ` Pedro Alves
2014-05-14 11:18 ` Michael Neuling
2014-05-14 11:22 ` Pedro Alves
2014-05-14 11:22 ` Pedro Alves
2014-05-15 8:25 ` Anshuman Khandual
2014-05-15 8:25 ` Anshuman Khandual
2014-05-15 12:08 ` Pedro Alves
2014-05-15 12:08 ` Pedro Alves
2014-05-16 0:26 ` Michael Neuling
2014-05-16 0:26 ` Michael Neuling
2014-05-19 9:12 ` Anshuman Khandual
2014-05-19 9:12 ` Anshuman Khandual
2014-05-19 11:46 ` Anshuman Khandual
2014-05-19 11:46 ` Anshuman Khandual
2014-05-19 14:43 ` Pedro Alves
2014-05-19 14:43 ` Pedro Alves
2014-05-20 8:14 ` Anshuman Khandual
2014-05-20 8:14 ` Anshuman Khandual
2014-05-20 10:33 ` Pedro Alves
2014-05-20 10:33 ` Pedro Alves
2014-05-22 5:08 ` Anshuman Khandual
2014-05-22 5:08 ` Anshuman Khandual
2014-05-23 13:57 ` Anshuman Khandual [this message]
2014-05-23 13:57 ` Anshuman Khandual
2014-05-13 17:21 ` Pedro Alves
2014-05-13 17:21 ` Pedro Alves
2014-05-14 5:49 ` Anshuman Khandual
2014-05-14 5:49 ` Anshuman Khandual
2014-05-22 5:30 ` Michael Ellerman
2014-05-22 5:30 ` Michael Ellerman
2014-05-05 7:54 ` [PATCH V2 3/3] powerpc, ptrace: Enable support for miscellaneous registers Anshuman Khandual
2014-05-05 7:54 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537F53BE.8030105@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=avagin@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mikey@neuling.org \
--cc=oleg@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.