[meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Maciej Borzecki]

Enable CONFIG_FHANDLE so that systemd can autostart
getty on serial interfaces like /dev/ttymxc*

Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
Signed-off-by: Maciej Borzecki <maciek.borzecki@gmail.com>
---
 recipes-kernel/linux/linux-imx-3.10.17/mx6/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/recipes-kernel/linux/linux-imx-3.10.17/mx6/defconfig b/recipes-kernel/linux/linux-imx-3.10.17/mx6/defconfig
index b8d6ceb..fa2eada 100644
--- a/recipes-kernel/linux/linux-imx-3.10.17/mx6/defconfig
+++ b/recipes-kernel/linux/linux-imx-3.10.17/mx6/defconfig
@@ -355,3 +355,4 @@ CONFIG_CRC_CCITT=m
 CONFIG_CRC_T10DIF=y
 CONFIG_CRC7=m
 CONFIG_LIBCRC32C=m
+CONFIG_FHANDLE=y
-- 
1.9.0

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Daiane Angolini]

> Enable CONFIG_FHANDLE so that systemd can autostart
> getty on serial interfaces like /dev/ttymxc*

How many imx6 boards/chips did you tested it?

Daiane

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Fabio Estevam]

On Fri, May 23, 2014 at 9:00 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>> Enable CONFIG_FHANDLE so that systemd can autostart
>> getty on serial interfaces like /dev/ttymxc*
>
> How many imx6 boards/chips did you tested it?

It seems that CONFIG_FHANDLE is needed when systemd version >= 210 is used.

Thiis is not mx6 specific.

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Maciej Borzecki]

On 05/23 09:00, Daiane Angolini wrote:
> > Enable CONFIG_FHANDLE so that systemd can autostart
> > getty on serial interfaces like /dev/ttymxc*
>
> How many imx6 boards/chips did you tested it?
I've tried mx6q and mx6dl. Both on custom as well as GENIVI builds
(gemini-image to be exact).

--
Maciej Borzęcki
Senior Software Developer at Open-RnD Sp. z o.o., Poland
www.open-rnd.pl
mobile: +48 889 117 365, fax: +48 42 657 9079


Niniejsza wiadomość wraz z załącznikami może
zawierać chronione prawem lub poufne informacje i została
wysłana wyłącznie do wiadomości i użytku osób, do których
została zaadresowana. Jeśli wiadomość została otrzymana
przypadkowo zabrania się jej kopiowania lub rozsyłania do osób
trzecich. W takim przypadku uprasza się o natychmiastowe
zniszczenie wiadomości oraz poinformowanie nadawcy o
zaistniałej sytuacji za pomocą wiadomości zwrotnej.
Dziękujemy.

This message, including any attachments hereto,
may contain privileged or confidential information and is sent
solely for the attention and use of the intended addressee(s).
If you are not an intended addressee, you may neither use this
message nor copy or deliver it to anyone. In such case, you
should immediately destroy this message and kindly notify the
sender by reply email. Thank you.

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Maciej Borzecki]

On 05/23 09:24, Fabio Estevam wrote:
> On Fri, May 23, 2014 at 9:00 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
> >> Enable CONFIG_FHANDLE so that systemd can autostart
> >> getty on serial interfaces like /dev/ttymxc*
> >
> > How many imx6 boards/chips did you tested it?
>
> It seems that CONFIG_FHANDLE is needed when systemd version >= 210 is used.
>
> Thiis is not mx6 specific.
It is not, you're right. However, if it's not enabled than using the
system with systemd is a major PITA as getty will be started. No serial,
not access, provided you're using a headless setup.

Also, linux-wandboard and linux-congatec from meta-fsl-arm-extra already
have this enabled in respective defconfigs. Default linux-yocto (at
least 3.14) seemed to work on BeagleBone as well without any changes.

--
Maciej Borzęcki
Senior Software Developer at Open-RnD Sp. z o.o., Poland
www.open-rnd.pl
mobile: +48 889 117 365, fax: +48 42 657 9079


Niniejsza wiadomość wraz z załącznikami może
zawierać chronione prawem lub poufne informacje i została
wysłana wyłącznie do wiadomości i użytku osób, do których
została zaadresowana. Jeśli wiadomość została otrzymana
przypadkowo zabrania się jej kopiowania lub rozsyłania do osób
trzecich. W takim przypadku uprasza się o natychmiastowe
zniszczenie wiadomości oraz poinformowanie nadawcy o
zaistniałej sytuacji za pomocą wiadomości zwrotnej.
Dziękujemy.

This message, including any attachments hereto,
may contain privileged or confidential information and is sent
solely for the attention and use of the intended addressee(s).
If you are not an intended addressee, you may neither use this
message nor copy or deliver it to anyone. In such case, you
should immediately destroy this message and kindly notify the
sender by reply email. Thank you.

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Daiane Angolini]

>> Thiis is not mx6 specific.
> It is not, you're right. However, if it's not enabled than using the
> system with systemd is a major PITA as getty will be started. No serial,
> not access, provided you're using a headless setup.

I understand it´s not related with mx6. But this kind of change makes
our kernel to diverge from "the released kernel from freescale"

And I´m not sure I want this.

>
> Also, linux-wandboard and linux-congatec from meta-fsl-arm-extra already
> have this enabled in respective defconfigs. Default linux-yocto (at
> least 3.14) seemed to work on BeagleBone as well without any changes.

Yes, they have few boards and I´m sure they tested their boards.
For linux-imx we have several boards and we have users depending on
that kernel for their boards.

That´s the reason I asked for test scope :D

Daiane

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Fabio Estevam]

On Fri, May 23, 2014 at 10:11 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>>> Thiis is not mx6 specific.
>> It is not, you're right. However, if it's not enabled than using the
>> system with systemd is a major PITA as getty will be started. No serial,
>> not access, provided you're using a headless setup.
>
> I understand it´s not related with mx6. But this kind of change makes
> our kernel to diverge from "the released kernel from freescale"
>
> And I´m not sure I want this.

If you want a serial console working in Yocto then you want this
option selected :-)

Proabably the issue was not seen with the released kernel from FSL
because it hasn't been used against systemd version >=210.

Maciej's patch is the correct fix.

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Jacob Kroon]

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

On Fri, May 23, 2014 at 3:15 PM, Fabio Estevam <festevam@gmail.com> wrote:

> On Fri, May 23, 2014 at 10:11 AM, Daiane Angolini <daiane.list@gmail.com>
> wrote:
> >>> Thiis is not mx6 specific.
> >> It is not, you're right. However, if it's not enabled than using the
> >> system with systemd is a major PITA as getty will be started. No serial,
> >> not access, provided you're using a headless setup.
> >
> > I understand it´s not related with mx6. But this kind of change makes
> > our kernel to diverge from "the released kernel from freescale"
> >
> > And I´m not sure I want this.
>
> If you want a serial console working in Yocto then you want this
> option selected :-)
>
> Proabably the issue was not seen with the released kernel from FSL
> because it hasn't been used against systemd version >=210.
>
> Maciej's patch is the correct fix.
>

FWIW, +1 on getting Maciej's fix applied

[-- Attachment #2: Type: text/html, Size: 1402 bytes --]

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Daiane Angolini]

>> >>> Thiis is not mx6 specific.
>> >> It is not, you're right. However, if it's not enabled than using the
>> >> system with systemd is a major PITA as getty will be started. No
>> >> serial,
>> >> not access, provided you're using a headless setup.
>> >
>> > I understand it´s not related with mx6. But this kind of change makes
>> > our kernel to diverge from "the released kernel from freescale"
>> >
>> > And I´m not sure I want this.
>>
>> If you want a serial console working in Yocto then you want this
>> option selected :-)
>>
>> Proabably the issue was not seen with the released kernel from FSL
>> because it hasn't been used against systemd version >=210.
>>
>> Maciej's patch is the correct fix.
>
>
> FWIW, +1 on getting Maciej's fix applied

OK =D


(only to be completely clear, I was not *against* the patch. I only
asked how it was tested)


Daiane

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Gary Thomas]

On 2014-05-23 07:26, Daiane Angolini wrote:
>>>>>> Thiis is not mx6 specific.
>>>>> It is not, you're right. However, if it's not enabled than using the
>>>>> system with systemd is a major PITA as getty will be started. No
>>>>> serial,
>>>>> not access, provided you're using a headless setup.
>>>>
>>>> I understand it´s not related with mx6. But this kind of change makes
>>>> our kernel to diverge from "the released kernel from freescale"
>>>>
>>>> And I´m not sure I want this.
>>>
>>> If you want a serial console working in Yocto then you want this
>>> option selected :-)
>>>
>>> Proabably the issue was not seen with the released kernel from FSL
>>> because it hasn't been used against systemd version >=210.
>>>
>>> Maciej's patch is the correct fix.
>>
>>
>> FWIW, +1 on getting Maciej's fix applied
>
> OK =D
>
>
> (only to be completely clear, I was not *against* the patch. I only
> asked how it was tested)

+1 as well - I just tested it on SabreLite and it fixed a problem I was
seeing with no serial ports on login when using systemd.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Otavio Salvador]

On Fri, May 23, 2014 at 10:11 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>>> Thiis is not mx6 specific.
>> It is not, you're right. However, if it's not enabled than using the
>> system with systemd is a major PITA as getty will be started. No serial,
>> not access, provided you're using a headless setup.
>
> I understand it´s not related with mx6. But this kind of change makes
> our kernel to diverge from "the released kernel from freescale"
>
> And I´m not sure I want this.

We don't have many options here. We need to apply it and prepare a
patch for the linux-imx to be send internally for review, I think.

>> Also, linux-wandboard and linux-congatec from meta-fsl-arm-extra already
>> have this enabled in respective defconfigs. Default linux-yocto (at
>> least 3.14) seemed to work on BeagleBone as well without any changes.
>
> Yes, they have few boards and I´m sure they tested their boards.
> For linux-imx we have several boards and we have users depending on
> that kernel for their boards.
>
> That´s the reason I asked for test scope :D

Indeed. We'll need to run some tests, for sure. :-(

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm][PATCH] linux-imx: enable CONFIG_FHANDLE

[Maciek Borzecki]

On Fri, May 23, 2014 at 5:19 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Fri, May 23, 2014 at 10:11 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>>>> Thiis is not mx6 specific.
>>> It is not, you're right. However, if it's not enabled than using the
>>> system with systemd is a major PITA as getty will be started. No serial,
>>> not access, provided you're using a headless setup.
>>
>> I understand it´s not related with mx6. But this kind of change makes
>> our kernel to diverge from "the released kernel from freescale"
>>
>> And I´m not sure I want this.
>
> We don't have many options here. We need to apply it and prepare a
> patch for the linux-imx to be send internally for review, I think.
>
>>> Also, linux-wandboard and linux-congatec from meta-fsl-arm-extra already
>>> have this enabled in respective defconfigs. Default linux-yocto (at
>>> least 3.14) seemed to work on BeagleBone as well without any changes.
>>
>> Yes, they have few boards and I´m sure they tested their boards.
>> For linux-imx we have several boards and we have users depending on
>> that kernel for their boards.
>>
>> That´s the reason I asked for test scope :D
>
> Indeed. We'll need to run some tests, for sure. :-(

FWIW I have not seen any other problems systemd 212 so far.

-- 
Maciek Borzecki