All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ibmvscsi: Abort init sequence during error recovery
@ 2014-05-23 15:47 Brian King
  2014-05-23 15:49 ` Brian King
  0 siblings, 1 reply; 2+ messages in thread
From: Brian King @ 2014-05-23 15:47 UTC (permalink / raw)
  To: James.Bottomley; +Cc: linux-scsi, nfont, brking


If a CRQ reset is triggered for some reason while in the middle
of performing VSCSI adapter initialization, we don't want to
call the done function for the initialization MAD commands as
this will only result in two threads attempting initialization
at the same time, resulting in failures.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---

 drivers/scsi/ibmvscsi/ibmvscsi.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_purge_fix drivers/scsi/ibmvscsi/ibmvscsi.c
--- linux/drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_purge_fix	2014-05-23 10:36:04.000000000 -0500
+++ linux-bjking1/drivers/scsi/ibmvscsi/ibmvscsi.c	2014-05-23 10:36:33.000000000 -0500
@@ -797,7 +797,8 @@ static void purge_requests(struct ibmvsc
 				       evt->hostdata->dev);
 			if (evt->cmnd_done)
 				evt->cmnd_done(evt->cmnd);
-		} else if (evt->done)
+		} else if (tmp_evt->done && tmp_evt->crq.format != VIOSRP_MAD_FORMAT &&
+			   tmp_evt->iu.srp.login_req.opcode != SRP_LOGIN_REQ)
 			evt->done(evt);
 		free_event_struct(&evt->hostdata->pool, evt);
 		spin_lock_irqsave(hostdata->host->host_lock, flags);
_


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] ibmvscsi: Abort init sequence during error recovery
  2014-05-23 15:47 [PATCH 1/2] ibmvscsi: Abort init sequence during error recovery Brian King
@ 2014-05-23 15:49 ` Brian King
  0 siblings, 0 replies; 2+ messages in thread
From: Brian King @ 2014-05-23 15:49 UTC (permalink / raw)
  To: Brian King; +Cc: James.Bottomley, linux-scsi, nfont

Please ignore this, its broken... will resend...

-Brian

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-23 15:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-23 15:47 [PATCH 1/2] ibmvscsi: Abort init sequence during error recovery Brian King
2014-05-23 15:49 ` Brian King

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.