From: Tomasz Figa <tomasz.figa@gmail.com>
To: Tarek Dakhran <t.dakhran@gmail.com>
Cc: Tarek Dakhran <t.dakhran@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Ben Dooks <ben-linux@fluff.org>, Tomasz Figa <t.figa@samsung.com>,
Mike Turquette <mturquette@linaro.org>,
Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Heiko Stuebner <heiko@sntech.de>,
Romain Naour <romain.naour@openwide.fr>,
Chander Kashyap <chander.kashyap@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infrad>
Subject: Re: [PATCH v10 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC
Date: Sat, 24 May 2014 00:48:01 +0200 [thread overview]
Message-ID: <537FD021.2020808@gmail.com> (raw)
In-Reply-To: <CANhyOUd8Q2nzh_bF6LZNuv8keVUB3F45PocYrLP_B=D_Q3tWuQ@mail.gmail.com>
On 24.05.2014 00:44, Tarek Dakhran wrote:
> Hi Tomazs,
>
> On Sat, May 24, 2014 at 1:11 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>> Hi Tarek,
>>
>> With v2 of the series I mentioned in review of previous version [1],
>> this patch can be skipped.
>>
>> [1] http://www.spinics.net/lists/linux-samsung-soc/msg31258.html
>>
>> Best regards,
>> Tomasz
>>
>> On 23.05.2014 12:35, Tarek Dakhran wrote:
> [snip]
>>> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
>>> index 739bdc8..971baf0 100644
>>> --- a/arch/arm/mach-exynos/firmware.c
>>> +++ b/arch/arm/mach-exynos/firmware.c
>>> @@ -50,7 +50,7 @@ static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
>>>
>>> boot_reg = sysram_ns_base_addr + 0x1c;
>>>
>>> - if (!soc_is_exynos4212())
>>> + if (!soc_is_exynos4212() && !soc_is_exynos5410())
>>> boot_reg += 4*cpu;
>>>
>>> __raw_writel(boot_addr, boot_reg);
>>>
>
> I need to define SoC type to set correct bootreg in firmware,
> otherwise only one cpu can be booted.
> So, this stuff is needed.
The patch I referred to in my previous reply changes this condition from
!soc_is_exynos4212() to soc_is_exynos4412(), which makes the 4*cpu
offset being added only in case of Exynos4412 (and so not being added
for Exynos5410). What else is needed?
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC
Date: Sat, 24 May 2014 00:48:01 +0200 [thread overview]
Message-ID: <537FD021.2020808@gmail.com> (raw)
In-Reply-To: <CANhyOUd8Q2nzh_bF6LZNuv8keVUB3F45PocYrLP_B=D_Q3tWuQ@mail.gmail.com>
On 24.05.2014 00:44, Tarek Dakhran wrote:
> Hi Tomazs,
>
> On Sat, May 24, 2014 at 1:11 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>> Hi Tarek,
>>
>> With v2 of the series I mentioned in review of previous version [1],
>> this patch can be skipped.
>>
>> [1] http://www.spinics.net/lists/linux-samsung-soc/msg31258.html
>>
>> Best regards,
>> Tomasz
>>
>> On 23.05.2014 12:35, Tarek Dakhran wrote:
> [snip]
>>> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
>>> index 739bdc8..971baf0 100644
>>> --- a/arch/arm/mach-exynos/firmware.c
>>> +++ b/arch/arm/mach-exynos/firmware.c
>>> @@ -50,7 +50,7 @@ static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
>>>
>>> boot_reg = sysram_ns_base_addr + 0x1c;
>>>
>>> - if (!soc_is_exynos4212())
>>> + if (!soc_is_exynos4212() && !soc_is_exynos5410())
>>> boot_reg += 4*cpu;
>>>
>>> __raw_writel(boot_addr, boot_reg);
>>>
>
> I need to define SoC type to set correct bootreg in firmware,
> otherwise only one cpu can be booted.
> So, this stuff is needed.
The patch I referred to in my previous reply changes this condition from
!soc_is_exynos4212() to soc_is_exynos4412(), which makes the 4*cpu
offset being added only in case of Exynos4412 (and so not being added
for Exynos5410). What else is needed?
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Tarek Dakhran <t.dakhran@gmail.com>
Cc: Tarek Dakhran <t.dakhran@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Ben Dooks <ben-linux@fluff.org>, Tomasz Figa <t.figa@samsung.com>,
Mike Turquette <mturquette@linaro.org>,
Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Heiko Stuebner <heiko@sntech.de>,
Romain Naour <romain.naour@openwide.fr>,
Chander Kashyap <chander.kashyap@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH v10 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC
Date: Sat, 24 May 2014 00:48:01 +0200 [thread overview]
Message-ID: <537FD021.2020808@gmail.com> (raw)
In-Reply-To: <CANhyOUd8Q2nzh_bF6LZNuv8keVUB3F45PocYrLP_B=D_Q3tWuQ@mail.gmail.com>
On 24.05.2014 00:44, Tarek Dakhran wrote:
> Hi Tomazs,
>
> On Sat, May 24, 2014 at 1:11 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>> Hi Tarek,
>>
>> With v2 of the series I mentioned in review of previous version [1],
>> this patch can be skipped.
>>
>> [1] http://www.spinics.net/lists/linux-samsung-soc/msg31258.html
>>
>> Best regards,
>> Tomasz
>>
>> On 23.05.2014 12:35, Tarek Dakhran wrote:
> [snip]
>>> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
>>> index 739bdc8..971baf0 100644
>>> --- a/arch/arm/mach-exynos/firmware.c
>>> +++ b/arch/arm/mach-exynos/firmware.c
>>> @@ -50,7 +50,7 @@ static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
>>>
>>> boot_reg = sysram_ns_base_addr + 0x1c;
>>>
>>> - if (!soc_is_exynos4212())
>>> + if (!soc_is_exynos4212() && !soc_is_exynos5410())
>>> boot_reg += 4*cpu;
>>>
>>> __raw_writel(boot_addr, boot_reg);
>>>
>
> I need to define SoC type to set correct bootreg in firmware,
> otherwise only one cpu can be booted.
> So, this stuff is needed.
The patch I referred to in my previous reply changes this condition from
!soc_is_exynos4212() to soc_is_exynos4412(), which makes the 4*cpu
offset being added only in case of Exynos4412 (and so not being added
for Exynos5410). What else is needed?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-23 22:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 10:35 [PATCH v10 0/3] Exynos 5410 support Tarek Dakhran
2014-05-23 10:35 ` Tarek Dakhran
2014-05-23 10:35 ` [PATCH v10 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC Tarek Dakhran
2014-05-23 10:35 ` Tarek Dakhran
2014-05-23 21:11 ` Tomasz Figa
2014-05-23 21:11 ` Tomasz Figa
2014-05-23 22:44 ` Tarek Dakhran
2014-05-23 22:44 ` Tarek Dakhran
2014-05-23 22:44 ` Tarek Dakhran
2014-05-23 22:48 ` Tomasz Figa [this message]
2014-05-23 22:48 ` Tomasz Figa
2014-05-23 22:48 ` Tomasz Figa
2014-05-23 22:48 ` Tarek Dakhran
2014-05-23 22:48 ` Tarek Dakhran
2014-05-23 22:48 ` Tarek Dakhran
2014-05-23 22:55 ` Tomasz Figa
2014-05-23 22:55 ` Tomasz Figa
2014-05-23 22:55 ` Tomasz Figa
2014-05-24 9:33 ` Tarek Dakhran
2014-05-24 9:33 ` Tarek Dakhran
2014-05-24 17:44 ` Tomasz Figa
2014-05-24 17:44 ` Tomasz Figa
[not found] ` <1400841343-6016-1-git-send-email-t.dakhran-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-23 10:35 ` [PATCH v10 2/3] clk: exynos5410: register clocks using common clock framework Tarek Dakhran
2014-05-23 10:35 ` Tarek Dakhran
2014-05-23 10:35 ` Tarek Dakhran
2014-05-23 18:28 ` Mike Turquette
2014-05-23 18:28 ` Mike Turquette
2014-05-23 18:28 ` Mike Turquette
2014-05-23 21:19 ` Tomasz Figa
2014-05-23 21:19 ` Tomasz Figa
2014-05-23 22:52 ` Tarek Dakhran
2014-05-23 22:52 ` Tarek Dakhran
2014-05-23 22:52 ` Tarek Dakhran
2014-05-23 10:35 ` [PATCH v10 3/3] ARM: dts: Add initial device tree support for EXYNOS5410 Tarek Dakhran
2014-05-23 10:35 ` Tarek Dakhran
2014-05-23 17:02 ` Matthias Brugger
2014-05-23 17:02 ` Matthias Brugger
2014-05-23 17:02 ` Matthias Brugger
2014-05-23 21:15 ` Tomasz Figa
2014-05-23 21:15 ` Tomasz Figa
2014-05-25 20:09 ` Kukjin Kim
2014-05-25 20:09 ` Kukjin Kim
2014-05-25 20:09 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537FD021.2020808@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=ben-linux@fluff.org \
--cc=chander.kashyap@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infrad \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=romain.naour@openwide.fr \
--cc=t.dakhran@gmail.com \
--cc=t.dakhran@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=v.tyrtov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.