From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: sun4i: depend on RESET_CONTROLLER
Date: Sat, 24 May 2014 12:15:21 +0200 [thread overview]
Message-ID: <53807139.6060308@redhat.com> (raw)
In-Reply-To: <1400871088-16894-1-git-send-email-maxime.ripard@free-electrons.com>
Hi,
On 05/23/2014 08:51 PM, Maxime Ripard wrote:
> The driver depend on the reset framework in a mandatory way. Make sure
> reset_control_get is defined by adding this dependency in Kconfig
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
Good catch.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/phy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 16a2f067c242..1d8099a56a91 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -112,6 +112,7 @@ config PHY_EXYNOS5250_SATA
> config PHY_SUN4I_USB
> tristate "Allwinner sunxi SoC USB PHY driver"
> depends on ARCH_SUNXI && HAS_IOMEM && OF
> + depends on RESET_CONTROLLER
> select GENERIC_PHY
> help
> Enable this to support the transceiver that is part of Allwinner
>
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>, kishon@ti.com
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] phy: sun4i: depend on RESET_CONTROLLER
Date: Sat, 24 May 2014 12:15:21 +0200 [thread overview]
Message-ID: <53807139.6060308@redhat.com> (raw)
In-Reply-To: <1400871088-16894-1-git-send-email-maxime.ripard@free-electrons.com>
Hi,
On 05/23/2014 08:51 PM, Maxime Ripard wrote:
> The driver depend on the reset framework in a mandatory way. Make sure
> reset_control_get is defined by adding this dependency in Kconfig
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
Good catch.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/phy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 16a2f067c242..1d8099a56a91 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -112,6 +112,7 @@ config PHY_EXYNOS5250_SATA
> config PHY_SUN4I_USB
> tristate "Allwinner sunxi SoC USB PHY driver"
> depends on ARCH_SUNXI && HAS_IOMEM && OF
> + depends on RESET_CONTROLLER
> select GENERIC_PHY
> help
> Enable this to support the transceiver that is part of Allwinner
>
next prev parent reply other threads:[~2014-05-24 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 18:51 [PATCH] phy: sun4i: depend on RESET_CONTROLLER Maxime Ripard
2014-05-23 18:51 ` Maxime Ripard
2014-05-24 10:15 ` Hans de Goede [this message]
2014-05-24 10:15 ` Hans de Goede
2014-06-11 9:10 ` Maxime Ripard
2014-06-11 9:10 ` Maxime Ripard
2014-06-11 9:44 ` Kishon Vijay Abraham I
2014-06-11 9:44 ` Kishon Vijay Abraham I
2014-06-11 9:46 ` Maxime Ripard
2014-06-11 9:46 ` Maxime Ripard
2014-06-29 14:00 ` Maxime Ripard
2014-06-29 14:00 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53807139.6060308@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.