All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Mergnat <amergnat@baylibre.com>
To: Zheng Wang <zyytlz.wz@163.com>, Kyrie.Wu@mediatek.com
Cc: bin.liu@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com,
	angelogioacchino.delregno@collabora.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, Irui.Wang@mediatek.com,
	security@kernel.org, hackerzheng666@gmail.com,
	1395428693sheep@gmail.com, alex000young@gmail.com
Subject: Re: [RESEND PATCH v2] media: mtk-jpeg: Fix use after free bug due to uncanceled work
Date: Fri, 7 Jul 2023 16:11:32 +0200	[thread overview]
Message-ID: <538096d2-7b24-e1c7-706d-4d4f952d35eb@baylibre.com> (raw)
In-Reply-To: <20230707092414.866760-1-zyytlz.wz@163.com>



On 07/07/2023 11:24, Zheng Wang wrote:
> In mtk_jpeg_probe, &jpeg->job_timeout_work is bound with
> mtk_jpeg_job_timeout_work. Then mtk_jpeg_dec_device_run
> and mtk_jpeg_enc_device_run may be called to start the
> work.
> If we remove the module which will call mtk_jpeg_remove
> to make cleanup, there may be a unfinished work. The
> possible sequence is as follows, which will cause a
> typical UAF bug.
> 
> Fix it by canceling the work before cleanup in the mtk_jpeg_remove
> 
> CPU0                  CPU1
> 
>                      |mtk_jpeg_job_timeout_work
> mtk_jpeg_remove     |
>    v4l2_m2m_release  |
>      kfree(m2m_dev); |
>                      |
>                      | v4l2_m2m_get_curr_priv
>                      |   m2m_dev->curr_ctx //use

Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>

-- 
Regards,
Alexandre


WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Mergnat <amergnat@baylibre.com>
To: Zheng Wang <zyytlz.wz@163.com>, Kyrie.Wu@mediatek.com
Cc: bin.liu@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com,
	angelogioacchino.delregno@collabora.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, Irui.Wang@mediatek.com,
	security@kernel.org, hackerzheng666@gmail.com,
	1395428693sheep@gmail.com, alex000young@gmail.com
Subject: Re: [RESEND PATCH v2] media: mtk-jpeg: Fix use after free bug due to uncanceled work
Date: Fri, 7 Jul 2023 16:11:32 +0200	[thread overview]
Message-ID: <538096d2-7b24-e1c7-706d-4d4f952d35eb@baylibre.com> (raw)
In-Reply-To: <20230707092414.866760-1-zyytlz.wz@163.com>



On 07/07/2023 11:24, Zheng Wang wrote:
> In mtk_jpeg_probe, &jpeg->job_timeout_work is bound with
> mtk_jpeg_job_timeout_work. Then mtk_jpeg_dec_device_run
> and mtk_jpeg_enc_device_run may be called to start the
> work.
> If we remove the module which will call mtk_jpeg_remove
> to make cleanup, there may be a unfinished work. The
> possible sequence is as follows, which will cause a
> typical UAF bug.
> 
> Fix it by canceling the work before cleanup in the mtk_jpeg_remove
> 
> CPU0                  CPU1
> 
>                      |mtk_jpeg_job_timeout_work
> mtk_jpeg_remove     |
>    v4l2_m2m_release  |
>      kfree(m2m_dev); |
>                      |
>                      | v4l2_m2m_get_curr_priv
>                      |   m2m_dev->curr_ctx //use

Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>

-- 
Regards,
Alexandre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-07-07 14:11 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-07  9:24 [RESEND PATCH v2] media: mtk-jpeg: Fix use after free bug due to uncanceled work Zheng Wang
2023-07-07  9:24 ` Zheng Wang
2023-07-07 14:11 ` Alexandre Mergnat [this message]
2023-07-07 14:11   ` Alexandre Mergnat
2023-07-15 16:08   ` Zheng Hacker
2023-07-15 16:08     ` Zheng Hacker
2023-07-18  3:07     ` Zheng Hacker
2023-07-18  3:07       ` Zheng Hacker
2023-07-19 10:17       ` Alexandre Mergnat
2023-07-19 10:17         ` Alexandre Mergnat
2023-07-20  3:17         ` Zheng Hacker
2023-07-20  3:17           ` Zheng Hacker
2023-07-20  3:40 ` Chen-Yu Tsai
2023-07-20  3:40   ` Chen-Yu Tsai
2023-07-20  7:45 ` AngeloGioacchino Del Regno
2023-07-20  7:45   ` AngeloGioacchino Del Regno
2023-07-25  2:39   ` Zheng Hacker
2023-08-22 18:51 ` Dmitry Osipenko
2023-08-22 18:51   ` Dmitry Osipenko
2023-08-24  8:20   ` Zheng Hacker
2023-08-24  8:20     ` Zheng Hacker
2023-08-28  2:04     ` Dmitry Osipenko
2023-08-28  2:04       ` Dmitry Osipenko
2023-08-31  8:18       ` Zheng Hacker
2023-08-31  8:18         ` Zheng Hacker
2023-09-05  4:24         ` Zheng Hacker
2023-09-05  4:24           ` Zheng Hacker
2023-09-12  9:29           ` Zheng Hacker
2023-09-12  9:29             ` Zheng Hacker
2023-09-19 18:24         ` Dmitry Osipenko
2023-09-19 18:24           ` Dmitry Osipenko
2023-09-19 18:25           ` Dmitry Osipenko
2023-09-19 18:25             ` Dmitry Osipenko
2023-10-08  9:13           ` Zheng Hacker
2023-10-08  9:13             ` Zheng Hacker
2023-10-19 19:56             ` Dmitry Osipenko
2023-10-19 19:56               ` Dmitry Osipenko
2023-10-20  2:51               ` Zheng Hacker
2023-10-20  2:51                 ` Zheng Hacker
  -- strict thread matches above, loose matches on Subject: below --
2023-10-11  3:17 Zheng Wang
2023-10-11  4:51 ` kernel test robot
2023-10-11  7:32 Zheng Wang
2023-10-12 17:23 ` Greg KH
2023-10-15 10:32   ` Zheng Hacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538096d2-7b24-e1c7-706d-4d4f952d35eb@baylibre.com \
    --to=amergnat@baylibre.com \
    --cc=1395428693sheep@gmail.com \
    --cc=Irui.Wang@mediatek.com \
    --cc=Kyrie.Wu@mediatek.com \
    --cc=alex000young@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bin.liu@mediatek.com \
    --cc=hackerzheng666@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=security@kernel.org \
    --cc=zyytlz.wz@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.