From: Jan Kiszka <jan.kiszka@web.de>
To: Le Tan <tamlokveer@gmail.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.crosthwaite@xilinx.com,
qemu-trivial@nongnu.org, mjt@tls.msk.ru, stefanha@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-trivial] [PATCH v3] block: replace fprintf(stderr, ...) with error_report()
Date: Sun, 25 May 2014 22:29:11 +0800 [thread overview]
Message-ID: <5381FE37.80904@web.de> (raw)
In-Reply-To: <1400985853-25594-1-git-send-email-tamlokveer@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
On 2014-05-25 10:44, Le Tan wrote:
> Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
> block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument
> have been removed because @fmt of error_report() should not contain newline.
> Also fix some coding style issues.
Let's do the "also" part in a separate patch. It's more than one or two
trivial pass-by style fixes, and some people may like the fprintf
conversion while having different views on the other changes.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Le Tan <tamlokveer@gmail.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.crosthwaite@xilinx.com,
qemu-trivial@nongnu.org, mjt@tls.msk.ru, stefanha@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3] block: replace fprintf(stderr, ...) with error_report()
Date: Sun, 25 May 2014 22:29:11 +0800 [thread overview]
Message-ID: <5381FE37.80904@web.de> (raw)
In-Reply-To: <1400985853-25594-1-git-send-email-tamlokveer@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
On 2014-05-25 10:44, Le Tan wrote:
> Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
> block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument
> have been removed because @fmt of error_report() should not contain newline.
> Also fix some coding style issues.
Let's do the "also" part in a separate patch. It's more than one or two
trivial pass-by style fixes, and some people may like the fprintf
conversion while having different views on the other changes.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2014-05-25 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 2:44 [Qemu-trivial] [PATCH v3] block: replace fprintf(stderr, ...) with error_report() Le Tan
2014-05-25 2:44 ` [Qemu-devel] " Le Tan
2014-05-25 14:29 ` Jan Kiszka [this message]
2014-05-25 14:29 ` Jan Kiszka
2014-05-25 14:36 ` [Qemu-trivial] " Michael Tokarev
2014-05-25 14:36 ` [Qemu-devel] " Michael Tokarev
2014-05-25 14:45 ` Le Tan
2014-05-25 14:45 ` [Qemu-devel] " Le Tan
2014-05-25 14:48 ` Michael Tokarev
2014-05-25 14:48 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5381FE37.80904@web.de \
--to=jan.kiszka@web.de \
--cc=afaerber@suse.de \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tamlokveer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.