* [PATCH] ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static
@ 2014-05-26 15:01 Thomas Petazzoni
2014-05-26 15:05 ` Gregory CLEMENT
2014-06-20 20:44 ` Jason Cooper
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-05-26 15:01 UTC (permalink / raw)
To: linux-arm-kernel
The armada_370_xp_pmsu_idle_prepare() function is only used internally
to pmsu.c, so there's no reason to not use the static qualifier.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
arch/arm/mach-mvebu/pmsu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c
index 53a55c8..6e83d32 100644
--- a/arch/arm/mach-mvebu/pmsu.c
+++ b/arch/arm/mach-mvebu/pmsu.c
@@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void)
}
/* No locking is needed because we only access per-CPU registers */
-void armada_370_xp_pmsu_idle_prepare(bool deepidle)
+static void armada_370_xp_pmsu_idle_prepare(bool deepidle)
{
unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
u32 reg;
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static
2014-05-26 15:01 [PATCH] ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static Thomas Petazzoni
@ 2014-05-26 15:05 ` Gregory CLEMENT
2014-06-20 20:44 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2014-05-26 15:05 UTC (permalink / raw)
To: linux-arm-kernel
On 26/05/2014 17:01, Thomas Petazzoni wrote:
> The armada_370_xp_pmsu_idle_prepare() function is only used internally
> to pmsu.c, so there's no reason to not use the static qualifier.
Indeed, it was exported in the 1st version of the series, and then I forgot
to make it static later.
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> arch/arm/mach-mvebu/pmsu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c
> index 53a55c8..6e83d32 100644
> --- a/arch/arm/mach-mvebu/pmsu.c
> +++ b/arch/arm/mach-mvebu/pmsu.c
> @@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void)
> }
>
> /* No locking is needed because we only access per-CPU registers */
> -void armada_370_xp_pmsu_idle_prepare(bool deepidle)
> +static void armada_370_xp_pmsu_idle_prepare(bool deepidle)
> {
> unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
> u32 reg;
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static
2014-05-26 15:01 [PATCH] ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static Thomas Petazzoni
2014-05-26 15:05 ` Gregory CLEMENT
@ 2014-06-20 20:44 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2014-06-20 20:44 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 26, 2014 at 05:01:14PM +0200, Thomas Petazzoni wrote:
> The armada_370_xp_pmsu_idle_prepare() function is only used internally
> to pmsu.c, so there's no reason to not use the static qualifier.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> arch/arm/mach-mvebu/pmsu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to mvebu/soc with Gregory's Ack.
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-20 20:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-26 15:01 [PATCH] ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static Thomas Petazzoni
2014-05-26 15:05 ` Gregory CLEMENT
2014-06-20 20:44 ` Jason Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.