All of lore.kernel.org
 help / color / mirror / Atom feed
From: boris.brezillon@free-electrons.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] regulator: axp20x: resolve self dependency issue
Date: Mon, 26 May 2014 18:58:00 +0200	[thread overview]
Message-ID: <53837298.5080705@free-electrons.com> (raw)
In-Reply-To: <20140526154356.GZ22111@sirena.org.uk>

Hello Mark,

On 26/05/2014 17:43, Mark Brown wrote:
> On Mon, May 26, 2014 at 04:58:12PM +0200, Boris BREZILLON wrote:
>> Some regulators might take their power supply from other regulators defined
>> by the same PMIC.
>>
>> Retry regulators registration until all regulators are registered or the
>> last iteration didn't manage to register any new regulator (which means
>> there's an external dependency missing and we can thus return
>> EPROBE_DEFER).
> This is going to apply to most PMICs - we should factor this out into
> the core rather than implementing it individual drivers.  It works
> normally because typically the dependency is from DCDCs to LDOs and so
> with common naming schemes alphabetic sorting saves us.

I'm not sure I get what you mean.

AFAIU, we could factorize it by the mean of an helper function (say
devm_regulators_register), which would take a matches table and a
regulator desc table and do pretty much what I'm doing in this patch.

Is that what you had in mind ?

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Mark Brown <broonie@kernel.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Carlo Caione <carlo@caione.org>, Shuge <shuge@allwinnertech.com>,
	kevin@allwinnertech.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, dev@linux-sunxi.org
Subject: Re: [PATCH v2 5/5] regulator: axp20x: resolve self dependency issue
Date: Mon, 26 May 2014 18:58:00 +0200	[thread overview]
Message-ID: <53837298.5080705@free-electrons.com> (raw)
In-Reply-To: <20140526154356.GZ22111@sirena.org.uk>

Hello Mark,

On 26/05/2014 17:43, Mark Brown wrote:
> On Mon, May 26, 2014 at 04:58:12PM +0200, Boris BREZILLON wrote:
>> Some regulators might take their power supply from other regulators defined
>> by the same PMIC.
>>
>> Retry regulators registration until all regulators are registered or the
>> last iteration didn't manage to register any new regulator (which means
>> there's an external dependency missing and we can thus return
>> EPROBE_DEFER).
> This is going to apply to most PMICs - we should factor this out into
> the core rather than implementing it individual drivers.  It works
> normally because typically the dependency is from DCDCs to LDOs and so
> with common naming schemes alphabetic sorting saves us.

I'm not sure I get what you mean.

AFAIU, we could factorize it by the mean of an helper function (say
devm_regulators_register), which would take a matches table and a
regulator desc table and do pretty much what I'm doing in this patch.

Is that what you had in mind ?

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


  reply	other threads:[~2014-05-26 16:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26 14:58 [PATCH v2 0/5] mfd: axp20x: add AXP221 PMIC support Boris BREZILLON
2014-05-26 14:58 ` Boris BREZILLON
2014-05-26 14:58 ` [PATCH v2 1/5] " Boris BREZILLON
2014-05-26 14:58   ` Boris BREZILLON
2014-05-26 15:29   ` Boris BREZILLON
2014-05-26 15:29     ` Boris BREZILLON
2014-05-26 14:58 ` [PATCH v2 2/5] regulator: axp20x: prepare support for multiple AXP chip families Boris BREZILLON
2014-05-26 14:58   ` Boris BREZILLON
2014-05-26 14:58 ` [PATCH v2 3/5] regulator: axp20x: add support for AXP221 regulators Boris BREZILLON
2014-05-26 14:58   ` Boris BREZILLON
2014-05-26 14:58 ` [PATCH v2 4/5] regulator: axp20x: reset probe data before each probe Boris BREZILLON
2014-05-26 14:58   ` Boris BREZILLON
2014-05-26 14:58 ` [PATCH v2 5/5] regulator: axp20x: resolve self dependency issue Boris BREZILLON
2014-05-26 14:58   ` Boris BREZILLON
2014-05-26 15:43   ` Mark Brown
2014-05-26 15:43     ` Mark Brown
2014-05-26 16:58     ` Boris BREZILLON [this message]
2014-05-26 16:58       ` Boris BREZILLON
2014-05-26 18:17       ` Mark Brown
2014-05-26 18:17         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53837298.5080705@free-electrons.com \
    --to=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.