All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: "Marek Olšák" <maraeo@gmail.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: don't allow RADEON_GEM_DOMAIN_CPU for command submission
Date: Tue, 27 May 2014 11:08:12 +0200	[thread overview]
Message-ID: <538455FC.6000100@vodafone.de> (raw)
In-Reply-To: <1401152196-4604-1-git-send-email-maraeo@gmail.com>

Am 27.05.2014 02:56, schrieb Marek Olšák:
> From: Marek Olšák <marek.olsak@amd.com>
>
> It hangs the hardware.
>
> Signed-off-by: Marek Olšák <marek.olsak@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

Maybe CC stable as well? Anyway going to add it to my 3.15 queue.

Christian.

> ---
>   drivers/gpu/drm/radeon/radeon_cs.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
> index 2b6e0eb..2b78191 100644
> --- a/drivers/gpu/drm/radeon/radeon_cs.c
> +++ b/drivers/gpu/drm/radeon/radeon_cs.c
> @@ -152,6 +152,12 @@ static int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
>   			uint32_t domain = r->write_domain ?
>   				r->write_domain : r->read_domains;
>   
> +			if (domain & RADEON_GEM_DOMAIN_CPU) {
> +				DRM_ERROR("RADEON_GEM_DOMAIN_CPU is not valid "
> +					  "for command submission\n");
> +				return -EINVAL;
> +			}
> +
>   			p->relocs[i].domain = domain;
>   			if (domain == RADEON_GEM_DOMAIN_VRAM)
>   				domain |= RADEON_GEM_DOMAIN_GTT;

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-05-27  9:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27  0:56 [PATCH] drm/radeon: don't allow RADEON_GEM_DOMAIN_CPU for command submission Marek Olšák
2014-05-27  9:08 ` Christian König [this message]
2014-05-27 12:32   ` Marek Olšák

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538455FC.6000100@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=maraeo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.