[PATCH 1/5] ARM: dts: Enable RTC node on Origen boards

[PATCH 1/5] ARM: dts: Enable RTC node on Origen boards

[Sachin Kamat]

Enabled RTC node on Origen 4210 and 4412 boards.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4210-origen.dts |    4 ++++
 arch/arm/boot/dts/exynos4412-origen.dts |    4 ++++
 2 files changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index 72fb11f7ea21..95efb1189cf0 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -48,6 +48,10 @@
 		};
 	};
 
+	rtc@10070000 {
+		status = "okay";
+	};
+
 	tmu@100C0000 {
 		status = "okay";
 	};
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index e2c0dcab4d81..934fe7ecca7e 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -48,6 +48,10 @@
 		};
 	};
 
+	rtc@10070000 {
+		status = "okay";
+	};
+
 	pinctrl@11000000 {
 		keypad_rows: keypad-rows {
 			samsung,pins = "gpx2-0", "gpx2-1", "gpx2-2";
-- 
1.7.9.5

[PATCH 2/5] ARM: dts: Enable watchdog node on Origen boards

[Sachin Kamat]

Enabled watchdog nodes on Origen 4210 and 4412 boards.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4210-origen.dts |    4 ++++
 arch/arm/boot/dts/exynos4412-origen.dts |    4 ++++
 2 files changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index 95efb1189cf0..f018e2149168 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -48,6 +48,10 @@
 		};
 	};
 
+	watchdog@10060000 {
+		status = "okay";
+	};
+
 	rtc@10070000 {
 		status = "okay";
 	};
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index 934fe7ecca7e..bd3985b767c4 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -48,6 +48,10 @@
 		};
 	};
 
+	watchdog@10060000 {
+		status = "okay";
+	};
+
 	rtc@10070000 {
 		status = "okay";
 	};
-- 
1.7.9.5

[PATCH 3/5] ARM: dts: Replace numbers with key code macros on Origen boards

[Sachin Kamat]

Key code macros improve readability.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4210-origen.dts |   11 ++++++-----
 arch/arm/boot/dts/exynos4412-origen.dts |   13 +++++++------
 2 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index f018e2149168..f767c425d0b5 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -16,6 +16,7 @@
 
 /dts-v1/;
 #include "exynos4210.dtsi"
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Insignal Origen evaluation board based on Exynos4210";
@@ -259,35 +260,35 @@
 		up {
 			label = "Up";
 			gpios = <&gpx2 0 1>;
-			linux,code = <103>;
+			linux,code = <KEY_UP>;
 			gpio-key,wakeup;
 		};
 
 		down {
 			label = "Down";
 			gpios = <&gpx2 1 1>;
-			linux,code = <108>;
+			linux,code = <KEY_DOWN>;
 			gpio-key,wakeup;
 		};
 
 		back {
 			label = "Back";
 			gpios = <&gpx1 7 1>;
-			linux,code = <158>;
+			linux,code = <KEY_BACK>;
 			gpio-key,wakeup;
 		};
 
 		home {
 			label = "Home";
 			gpios = <&gpx1 6 1>;
-			linux,code = <102>;
+			linux,code = <KEY_HOME>;
 			gpio-key,wakeup;
 		};
 
 		menu {
 			label = "Menu";
 			gpios = <&gpx1 5 1>;
-			linux,code = <139>;
+			linux,code = <KEY_MENU>;
 			gpio-key,wakeup;
 		};
 	};
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index bd3985b767c4..e925c9fbfb07 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -14,6 +14,7 @@
 
 /dts-v1/;
 #include "exynos4412.dtsi"
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Insignal Origen evaluation board based on Exynos4412";
@@ -84,37 +85,37 @@
 		key_home {
 			keypad,row = <0>;
 			keypad,column = <0>;
-			linux,code = <102>;
+			linux,code = <KEY_HOME>;
 		};
 
 		key_down {
 			keypad,row = <0>;
 			keypad,column = <1>;
-			linux,code = <108>;
+			linux,code = <KEY_DOWN>;
 		};
 
 		key_up {
 			keypad,row = <1>;
 			keypad,column = <0>;
-			linux,code = <103>;
+			linux,code = <KEY_UP>;
 		};
 
 		key_menu {
 			keypad,row = <1>;
 			keypad,column = <1>;
-			linux,code = <139>;
+			linux,code = <KEY_MENU>;
 		};
 
 		key_back {
 			keypad,row = <2>;
 			keypad,column = <0>;
-			linux,code = <158>;
+			linux,code = <KEY_BACK>;
 		};
 
 		key_enter {
 			keypad,row = <2>;
 			keypad,column = <1>;
-			linux,code = <28>;
+			linux,code = <KEY_ENTER>;
 		};
 	};
 
-- 
1.7.9.5

[PATCH 4/5] ARM: dts: Replace numbers with key code macros on Arndale board

[Sachin Kamat]

Key code macros improve readability.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos5250-arndale.dts |   13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index cde19c818667..d0de1f50d15b 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -12,6 +12,7 @@
 /dts-v1/;
 #include "exynos5250.dtsi"
 #include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Insignal Arndale evaluation board based on EXYNOS5250";
@@ -445,42 +446,42 @@
 		menu {
 			label = "SW-TACT2";
 			gpios = <&gpx1 4 1>;
-			linux,code = <139>;
+			linux,code = <KEY_MENU>;
 			gpio-key,wakeup;
 		};
 
 		home {
 			label = "SW-TACT3";
 			gpios = <&gpx1 5 1>;
-			linux,code = <102>;
+			linux,code = <KEY_HOME>;
 			gpio-key,wakeup;
 		};
 
 		up {
 			label = "SW-TACT4";
 			gpios = <&gpx1 6 1>;
-			linux,code = <103>;
+			linux,code = <KEY_UP>;
 			gpio-key,wakeup;
 		};
 
 		down {
 			label = "SW-TACT5";
 			gpios = <&gpx1 7 1>;
-			linux,code = <108>;
+			linux,code = <KEY_DOWN>;
 			gpio-key,wakeup;
 		};
 
 		back {
 			label = "SW-TACT6";
 			gpios = <&gpx2 0 1>;
-			linux,code = <158>;
+			linux,code = <KEY_BACK>;
 			gpio-key,wakeup;
 		};
 
 		wakeup {
 			label = "SW-TACT7";
 			gpios = <&gpx2 1 1>;
-			linux,code = <143>;
+			linux,code = <KEY_WAKEUP>;
 			gpio-key,wakeup;
 		};
 	};
-- 
1.7.9.5

[PATCH 5/5] ARM: dts: Update watchdog node name in exynos5440.dtsi

[Sachin Kamat]

Made it as per DT node naming convention <name@reg_addr>.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos5440.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
index 84f77c2fe4d4..ae3a17c791f6 100644
--- a/arch/arm/boot/dts/exynos5440.dtsi
+++ b/arch/arm/boot/dts/exynos5440.dtsi
@@ -176,7 +176,7 @@
 		clock-names = "i2c";
 	};
 
-	watchdog {
+	watchdog@110000 {
 		compatible = "samsung,s3c2410-wdt";
 		reg = <0x110000 0x1000>;
 		interrupts = <0 1 0>;
-- 
1.7.9.5

Re: [PATCH 5/5] ARM: dts: Update watchdog node name in exynos5440.dtsi

[Jingoo Han]

On Friday, May 23, 2014 3:09 PM, Sachin Kamat wrote:
> 
> Made it as per DT node naming convention <name@reg_addr>.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  arch/arm/boot/dts/exynos5440.dtsi |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
> index 84f77c2fe4d4..ae3a17c791f6 100644
> --- a/arch/arm/boot/dts/exynos5440.dtsi
> +++ b/arch/arm/boot/dts/exynos5440.dtsi
> @@ -176,7 +176,7 @@
>  		clock-names = "i2c";
>  	};
> 
> -	watchdog {
> +	watchdog@110000 {
>  		compatible = "samsung,s3c2410-wdt";
>  		reg = <0x110000 0x1000>;
>  		interrupts = <0 1 0>;
> --
> 1.7.9.5

Re: [PATCH 1/5] ARM: dts: Enable RTC node on Origen boards

[Sachin Kamat]

On 23 May 2014 11:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Enabled RTC node on Origen 4210 and 4412 boards.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4210-origen.dts |    4 ++++
>  arch/arm/boot/dts/exynos4412-origen.dts |    4 ++++
>  2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
> index 72fb11f7ea21..95efb1189cf0 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -48,6 +48,10 @@
>                 };
>         };
>
> +       rtc@10070000 {
> +               status = "okay";
> +       };
> +
>         tmu@100C0000 {
>                 status = "okay";
>         };
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> index e2c0dcab4d81..934fe7ecca7e 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -48,6 +48,10 @@
>                 };
>         };
>
> +       rtc@10070000 {
> +               status = "okay";
> +       };
> +
>         pinctrl@11000000 {
>                 keypad_rows: keypad-rows {
>                         samsung,pins = "gpx2-0", "gpx2-1", "gpx2-2";
> --
> 1.7.9.5
>

Kukjin,

The patches in this series are really simple and do not want them to
wait for another
cycle. Please review and send them with your next pull request for
3.16. Also please
look at the 2 patches related to secondary cpu boot sent by Tushar.

-- 
With warm regards,
Sachin

Re: [PATCH 1/5] ARM: dts: Enable RTC node on Origen boards

[Kukjin Kim]

On 05/26/14 12:29, Sachin Kamat wrote:
> On 23 May 2014 11:38, Sachin Kamat<sachin.kamat@linaro.org>  wrote:
>> Enabled RTC node on Origen 4210 and 4412 boards.
>>
>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>> ---
>>   arch/arm/boot/dts/exynos4210-origen.dts |    4 ++++
>>   arch/arm/boot/dts/exynos4412-origen.dts |    4 ++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
>> index 72fb11f7ea21..95efb1189cf0 100644
>> --- a/arch/arm/boot/dts/exynos4210-origen.dts
>> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
>> @@ -48,6 +48,10 @@
>>                  };
>>          };
>>
>> +       rtc@10070000 {
>> +               status = "okay";
>> +       };
>> +
>>          tmu@100C0000 {
>>                  status = "okay";
>>          };
>> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
>> index e2c0dcab4d81..934fe7ecca7e 100644
>> --- a/arch/arm/boot/dts/exynos4412-origen.dts
>> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
>> @@ -48,6 +48,10 @@
>>                  };
>>          };
>>
>> +       rtc@10070000 {
>> +               status = "okay";
>> +       };
>> +
>>          pinctrl@11000000 {
>>                  keypad_rows: keypad-rows {
>>                          samsung,pins = "gpx2-0", "gpx2-1", "gpx2-2";
>> --
>> 1.7.9.5
>>
>
> Kukjin,
>
> The patches in this series are really simple and do not want them to
> wait for another
> cycle. Please review and send them with your next pull request for
> 3.16. Also please
> look at the 2 patches related to secondary cpu boot sent by Tushar.
>
Applied, but I'm not sure this can be sent to upstream in this time, I 
will try to do it though ;-) Because already queued a bunch of exynos 
stuff for arm-soc and this is not really critical at this moment?...

Anyway thanks.
- Kukjin

Re: [PATCH 1/5] ARM: dts: Enable RTC node on Origen boards

[Sachin Kamat]

Hi Kukjin,

On 27 May 2014 21:09, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 05/26/14 12:29, Sachin Kamat wrote:
>>
>> On 23 May 2014 11:38, Sachin Kamat<sachin.kamat@linaro.org>  wrote:
>>>
>>> Enabled RTC node on Origen 4210 and 4412 boards.
>>>
>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>>> ---
>>>   arch/arm/boot/dts/exynos4210-origen.dts |    4 ++++
>>>   arch/arm/boot/dts/exynos4412-origen.dts |    4 ++++
>>>   2 files changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
>>> b/arch/arm/boot/dts/exynos4210-origen.dts
>>> index 72fb11f7ea21..95efb1189cf0 100644
>>> --- a/arch/arm/boot/dts/exynos4210-origen.dts
>>> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
>>> @@ -48,6 +48,10 @@
>>>                  };
>>>          };
>>>
>>> +       rtc@10070000 {
>>> +               status = "okay";
>>> +       };
>>> +
>>>          tmu@100C0000 {
>>>                  status = "okay";
>>>          };
>>> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
>>> b/arch/arm/boot/dts/exynos4412-origen.dts
>>> index e2c0dcab4d81..934fe7ecca7e 100644
>>> --- a/arch/arm/boot/dts/exynos4412-origen.dts
>>> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
>>> @@ -48,6 +48,10 @@
>>>                  };
>>>          };
>>>
>>> +       rtc@10070000 {
>>> +               status = "okay";
>>> +       };
>>> +
>>>          pinctrl@11000000 {
>>>                  keypad_rows: keypad-rows {
>>>                          samsung,pins = "gpx2-0", "gpx2-1", "gpx2-2";
>>> --
>>> 1.7.9.5
>>>
>>
>> Kukjin,
>>
>> The patches in this series are really simple and do not want them to
>> wait for another
>> cycle. Please review and send them with your next pull request for
>> 3.16. Also please
>> look at the 2 patches related to secondary cpu boot sent by Tushar.
>>
> Applied, but I'm not sure this can be sent to upstream in this time, I will
> try to do it though ;-) Because already queued a bunch of exynos stuff for
> arm-soc and this is not really critical at this moment?...

Thanks for applying. These patches are not critical. However there are 2 more
patches posted by Tushar which are critical (have already sent pings for that,
will send once again separately for your reference). You may send these patches
along with those.

[PATCH V2 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode
http://www.spinics.net/lists/linux-samsung-soc/msg31258.html

[PATCH RESEND 2/2] ARM: dts: Add secure firmware support for Arndale-octa
http://www.spinics.net/lists/linux-samsung-soc/msg31259.html

-- 
With warm regards,
Sachin

Re: [PATCH 1/5] ARM: dts: Enable RTC node on Origen boards

[Sachin Kamat]

On 28 May 2014 09:23, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi Kukjin,
>
> On 27 May 2014 21:09, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> On 05/26/14 12:29, Sachin Kamat wrote:
>>>
>>> On 23 May 2014 11:38, Sachin Kamat<sachin.kamat@linaro.org>  wrote:
>>>>
>>>> Enabled RTC node on Origen 4210 and 4412 boards.
>>>>
>>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>>>> ---
>>>>   arch/arm/boot/dts/exynos4210-origen.dts |    4 ++++
>>>>   arch/arm/boot/dts/exynos4412-origen.dts |    4 ++++
>>>>   2 files changed, 8 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
>>>> b/arch/arm/boot/dts/exynos4210-origen.dts
>>>> index 72fb11f7ea21..95efb1189cf0 100644
>>>> --- a/arch/arm/boot/dts/exynos4210-origen.dts
>>>> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
>>>> @@ -48,6 +48,10 @@
>>>>                  };
>>>>          };
>>>>
>>>> +       rtc@10070000 {
>>>> +               status = "okay";
>>>> +       };
>>>> +
>>>>          tmu@100C0000 {
>>>>                  status = "okay";
>>>>          };
>>>> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
>>>> b/arch/arm/boot/dts/exynos4412-origen.dts
>>>> index e2c0dcab4d81..934fe7ecca7e 100644
>>>> --- a/arch/arm/boot/dts/exynos4412-origen.dts
>>>> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
>>>> @@ -48,6 +48,10 @@
>>>>                  };
>>>>          };
>>>>
>>>> +       rtc@10070000 {
>>>> +               status = "okay";
>>>> +       };
>>>> +
>>>>          pinctrl@11000000 {
>>>>                  keypad_rows: keypad-rows {
>>>>                          samsung,pins = "gpx2-0", "gpx2-1", "gpx2-2";
>>>> --
>>>> 1.7.9.5
>>>>
>>>
>>> Kukjin,
>>>
>>> The patches in this series are really simple and do not want them to
>>> wait for another
>>> cycle. Please review and send them with your next pull request for
>>> 3.16. Also please
>>> look at the 2 patches related to secondary cpu boot sent by Tushar.
>>>
>> Applied, but I'm not sure this can be sent to upstream in this time, I will
>> try to do it though ;-) Because already queued a bunch of exynos stuff for
>> arm-soc and this is not really critical at this moment?...
>
> Thanks for applying. These patches are not critical. However there are 2 more
> patches posted by Tushar which are critical (have already sent pings for that,
> will send once again separately for your reference). You may send these patches
> along with those.
>
> [PATCH V2 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode
> http://www.spinics.net/lists/linux-samsung-soc/msg31258.html
>
> [PATCH RESEND 2/2] ARM: dts: Add secure firmware support for Arndale-octa
> http://www.spinics.net/lists/linux-samsung-soc/msg31259.html

Re-sent both the above patches once again after rebasing on your
latest for-next branch.

-- 
With warm regards,
Sachin