* [PATCH 2/2] ARM: shmobile: r8a7790: Add DU and LVDS clocks
@ 2013-08-28 1:43 ` Simon Horman
0 siblings, 0 replies; 24+ messages in thread
From: Simon Horman @ 2013-08-28 1:43 UTC (permalink / raw)
To: linux-arm-kernel
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/clock-r8a7790.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c
index fc36d3d..d99b87b 100644
--- a/arch/arm/mach-shmobile/clock-r8a7790.c
+++ b/arch/arm/mach-shmobile/clock-r8a7790.c
@@ -182,7 +182,7 @@ static struct clk div6_clks[DIV6_NR] = {
/* MSTP */
enum {
MSTP813,
- MSTP721, MSTP720,
+ MSTP726, MSTP725, MSTP724, MSTP723, MSTP722, MSTP721, MSTP720,
MSTP717, MSTP716,
MSTP522,
MSTP315, MSTP314, MSTP313, MSTP312, MSTP311, MSTP305, MSTP304,
@@ -193,6 +193,11 @@ enum {
static struct clk mstp_clks[MSTP_NR] = {
[MSTP813] = SH_CLK_MSTP32(&p_clk, SMSTPCR8, 13, 0), /* Ether */
+ [MSTP726] = SH_CLK_MSTP32(&zx_clk, SMSTPCR7, 26, 0), /* LVDS0 */
+ [MSTP725] = SH_CLK_MSTP32(&zx_clk, SMSTPCR7, 25, 0), /* LVDS1 */
+ [MSTP724] = SH_CLK_MSTP32(&zx_clk, SMSTPCR7, 24, 0), /* DU0 */
+ [MSTP723] = SH_CLK_MSTP32(&zx_clk, SMSTPCR7, 23, 0), /* DU1 */
+ [MSTP722] = SH_CLK_MSTP32(&zx_clk, SMSTPCR7, 22, 0), /* DU2 */
[MSTP721] = SH_CLK_MSTP32(&p_clk, SMSTPCR7, 21, 0), /* SCIF0 */
[MSTP720] = SH_CLK_MSTP32(&p_clk, SMSTPCR7, 20, 0), /* SCIF1 */
[MSTP717] = SH_CLK_MSTP32(&zs_clk, SMSTPCR7, 17, 0), /* HSCIF0 */
@@ -251,6 +256,11 @@ static struct clk_lookup lookups[] = {
CLKDEV_CON_ID("ssprs", &div6_clks[DIV6_SSPRS]),
/* MSTP */
+ CLKDEV_ICK_ID("lvds.0", "rcar-du-r8a7790", &mstp_clks[MSTP726]),
+ CLKDEV_ICK_ID("lvds.1", "rcar-du-r8a7790", &mstp_clks[MSTP725]),
+ CLKDEV_ICK_ID("du.0", "rcar-du-r8a7790", &mstp_clks[MSTP724]),
+ CLKDEV_ICK_ID("du.1", "rcar-du-r8a7790", &mstp_clks[MSTP723]),
+ CLKDEV_ICK_ID("du.2", "rcar-du-r8a7790", &mstp_clks[MSTP722]),
CLKDEV_DEV_ID("sh-sci.0", &mstp_clks[MSTP204]),
CLKDEV_DEV_ID("sh-sci.1", &mstp_clks[MSTP203]),
CLKDEV_DEV_ID("sh-sci.2", &mstp_clks[MSTP206]),
--
1.8.3.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/2] arm: shmobile: r8a7790: Add SATA clock support
2013-08-28 1:43 ` Simon Horman
(?)
@ 2013-12-13 11:52 ` Valentine Barshak
-1 siblings, 0 replies; 24+ messages in thread
From: Valentine Barshak @ 2013-12-13 11:52 UTC (permalink / raw)
To: linux-sh
This adds SATA 0/1 clock support. External 100MHz SATA 0/1
reference clock is supposed to be applied to the following pins:
CICREFP0_SATA/CICREFP1_SATA;
CICREFN0_SATA/CICREFN1_SATA.
Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
---
arch/arm/mach-shmobile/clock-r8a7790.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c
index 3e27200..c4b567b 100644
--- a/arch/arm/mach-shmobile/clock-r8a7790.c
+++ b/arch/arm/mach-shmobile/clock-r8a7790.c
@@ -73,6 +73,18 @@ static struct clk extal_clk = {
.mapping = &cpg_mapping,
};
+/* External SATA0 reference clock: 100MHz fixed */
+static struct clk sata0_clk = {
+ .rate = 100000000,
+ .mapping = &cpg_mapping,
+};
+
+/* External SATA1 reference clock: 100MHz fixed */
+static struct clk sata1_clk = {
+ .rate = 100000000,
+ .mapping = &cpg_mapping,
+};
+
static struct sh_clk_ops followparent_clk_ops = {
.recalc = followparent_recalc,
};
@@ -140,6 +152,8 @@ static struct clk *main_clks[] = {
&ddr_clk,
&mp_clk,
&cp_clk,
+ &sata0_clk,
+ &sata1_clk,
};
/* SDHI (DIV4) clock */
@@ -187,6 +201,7 @@ enum {
MSTP1009, MSTP1008, MSTP1007, MSTP1006, MSTP1005,
MSTP931, MSTP930, MSTP929, MSTP928,
MSTP917,
+ MSTP815, MSTP814,
MSTP813,
MSTP726, MSTP725, MSTP724, MSTP723, MSTP722, MSTP721, MSTP720,
MSTP717, MSTP716,
@@ -215,6 +230,8 @@ static struct clk mstp_clks[MSTP_NR] = {
[MSTP929] = SH_CLK_MSTP32(&p_clk, SMSTPCR9, 29, 0), /* I2C2 */
[MSTP928] = SH_CLK_MSTP32(&p_clk, SMSTPCR9, 28, 0), /* I2C3 */
[MSTP917] = SH_CLK_MSTP32(&qspi_clk, SMSTPCR9, 17, 0), /* QSPI */
+ [MSTP815] = SH_CLK_MSTP32(&sata0_clk, SMSTPCR8, 15, 0), /* SATA0 */
+ [MSTP814] = SH_CLK_MSTP32(&sata1_clk, SMSTPCR8, 14, 0), /* SATA1 */
[MSTP813] = SH_CLK_MSTP32(&p_clk, SMSTPCR8, 13, 0), /* Ether */
[MSTP726] = SH_CLK_MSTP32(&zx_clk, SMSTPCR7, 26, 0), /* LVDS0 */
[MSTP725] = SH_CLK_MSTP32(&zx_clk, SMSTPCR7, 25, 0), /* LVDS1 */
@@ -321,6 +338,8 @@ static struct clk_lookup lookups[] = {
CLKDEV_DEV_ID("pci-rcar-gen2.0", &mstp_clks[MSTP703]),
CLKDEV_DEV_ID("pci-rcar-gen2.1", &mstp_clks[MSTP703]),
CLKDEV_DEV_ID("pci-rcar-gen2.2", &mstp_clks[MSTP703]),
+ CLKDEV_DEV_ID("sata-r8a7790.0", &mstp_clks[MSTP815]),
+ CLKDEV_DEV_ID("sata-r8a7790.1", &mstp_clks[MSTP814]),
/* ICK */
CLKDEV_ICK_ID("usbhs", "usb_phy_rcar_gen2", &mstp_clks[MSTP704]),
--
1.8.3.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/2] ARM: shmobile: r8a7790: add Audio DMAC support
2013-08-28 1:43 ` Simon Horman
(?)
(?)
@ 2014-01-06 8:32 ` Kuninori Morimoto
-1 siblings, 0 replies; 24+ messages in thread
From: Kuninori Morimoto @ 2014-01-06 8:32 UTC (permalink / raw)
To: linux-sh
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
R-Car H2 has many DMACs
(ex SYS-DMAC, 2D-DMAC, Audio-DMAC, USB-DMAC etc)
and, these DMAEngine needs DMA slave IDs to use it.
This patch adds new DMA slave ID list for r8a7790.
There, common part has RCAR_DMA_xxx prefix,
and Audio DMAC part has AUDIO_DMAC_SLAVE_xxx prefix.
Audio DMAC can be controlled via sh-dma-engine
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/mach-shmobile/include/mach/r8a7790.h | 25 +++++++
arch/arm/mach-shmobile/setup-r8a7790.c | 90 +++++++++++++++++++++++++
2 files changed, 115 insertions(+)
diff --git a/arch/arm/mach-shmobile/include/mach/r8a7790.h b/arch/arm/mach-shmobile/include/mach/r8a7790.h
index 5fbfa28..2177325 100644
--- a/arch/arm/mach-shmobile/include/mach/r8a7790.h
+++ b/arch/arm/mach-shmobile/include/mach/r8a7790.h
@@ -3,6 +3,31 @@
#include <mach/rcar-gen2.h>
+/* DMA slave IDs */
+enum {
+ RCAR_DMA_SLAVE_INVALID,
+ AUDIO_DMAC_SLAVE_SSI0_TX,
+ AUDIO_DMAC_SLAVE_SSI0_RX,
+ AUDIO_DMAC_SLAVE_SSI1_TX,
+ AUDIO_DMAC_SLAVE_SSI1_RX,
+ AUDIO_DMAC_SLAVE_SSI2_TX,
+ AUDIO_DMAC_SLAVE_SSI2_RX,
+ AUDIO_DMAC_SLAVE_SSI3_TX,
+ AUDIO_DMAC_SLAVE_SSI3_RX,
+ AUDIO_DMAC_SLAVE_SSI4_TX,
+ AUDIO_DMAC_SLAVE_SSI4_RX,
+ AUDIO_DMAC_SLAVE_SSI5_TX,
+ AUDIO_DMAC_SLAVE_SSI5_RX,
+ AUDIO_DMAC_SLAVE_SSI6_TX,
+ AUDIO_DMAC_SLAVE_SSI6_RX,
+ AUDIO_DMAC_SLAVE_SSI7_TX,
+ AUDIO_DMAC_SLAVE_SSI7_RX,
+ AUDIO_DMAC_SLAVE_SSI8_TX,
+ AUDIO_DMAC_SLAVE_SSI8_RX,
+ AUDIO_DMAC_SLAVE_SSI9_TX,
+ AUDIO_DMAC_SLAVE_SSI9_RX,
+};
+
void r8a7790_add_standard_devices(void);
void r8a7790_add_dt_devices(void);
void r8a7790_clock_init(void);
diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c
index 7800cec..23e5ebc 100644
--- a/arch/arm/mach-shmobile/setup-r8a7790.c
+++ b/arch/arm/mach-shmobile/setup-r8a7790.c
@@ -24,12 +24,100 @@
#include <linux/platform_data/gpio-rcar.h>
#include <linux/platform_data/irq-renesas-irqc.h>
#include <linux/serial_sci.h>
+#include <linux/sh_dma.h>
#include <linux/sh_timer.h>
#include <mach/common.h>
+#include <mach/dma-register.h>
#include <mach/irqs.h>
#include <mach/r8a7790.h>
#include <asm/mach/arch.h>
+/* Audio-DMAC */
+#define AUDIO_DMAC_SLAVE(_id, _addr, t, r) \
+{ \
+ .slave_id = AUDIO_DMAC_SLAVE_## _id ##_TX, \
+ .addr = _addr + 0x8, \
+ .chcr = CHCR_TX(XMIT_SZ_32BIT), \
+ .mid_rid = t, \
+}, { \
+ .slave_id = AUDIO_DMAC_SLAVE_## _id ##_RX, \
+ .addr = _addr + 0xc, \
+ .chcr = CHCR_RX(XMIT_SZ_32BIT), \
+ .mid_rid = r, \
+}
+
+static const struct sh_dmae_slave_config r8a7790_audio_dmac_slaves[] = {
+ AUDIO_DMAC_SLAVE(SSI0, 0xec241000, 0x01, 0x02),
+ AUDIO_DMAC_SLAVE(SSI1, 0xec241040, 0x03, 0x04),
+ AUDIO_DMAC_SLAVE(SSI2, 0xec241080, 0x05, 0x06),
+ AUDIO_DMAC_SLAVE(SSI3, 0xec2410c0, 0x07, 0x08),
+ AUDIO_DMAC_SLAVE(SSI4, 0xec241100, 0x09, 0x0a),
+ AUDIO_DMAC_SLAVE(SSI5, 0xec241140, 0x0b, 0x0c),
+ AUDIO_DMAC_SLAVE(SSI6, 0xec241180, 0x0d, 0x0e),
+ AUDIO_DMAC_SLAVE(SSI7, 0xec2411c0, 0x0f, 0x10),
+ AUDIO_DMAC_SLAVE(SSI8, 0xec241200, 0x11, 0x12),
+ AUDIO_DMAC_SLAVE(SSI9, 0xec241240, 0x13, 0x14),
+};
+
+#define DMAE_CHANNEL(a, b) \
+{ \
+ .offset = (a) - 0x20, \
+ .dmars = (a) - 0x20 + 0x40, \
+ .chclr_bit = (b), \
+ .chclr_offset = 0x80 - 0x20, \
+}
+
+static const struct sh_dmae_channel r8a7790_audio_dmac_channels[] = {
+ DMAE_CHANNEL(0x8000, 0),
+ DMAE_CHANNEL(0x8080, 1),
+ DMAE_CHANNEL(0x8100, 2),
+ DMAE_CHANNEL(0x8180, 3),
+ DMAE_CHANNEL(0x8200, 4),
+ DMAE_CHANNEL(0x8280, 5),
+ DMAE_CHANNEL(0x8300, 6),
+ DMAE_CHANNEL(0x8380, 7),
+ DMAE_CHANNEL(0x8400, 8),
+ DMAE_CHANNEL(0x8480, 9),
+ DMAE_CHANNEL(0x8500, 10),
+ DMAE_CHANNEL(0x8580, 11),
+ DMAE_CHANNEL(0x8600, 12),
+};
+
+static struct sh_dmae_pdata r8a7790_audio_dmac_platform_data = {
+ .slave = r8a7790_audio_dmac_slaves,
+ .slave_num = ARRAY_SIZE(r8a7790_audio_dmac_slaves),
+ .channel = r8a7790_audio_dmac_channels,
+ .channel_num = ARRAY_SIZE(r8a7790_audio_dmac_channels),
+ .ts_low_shift = TS_LOW_SHIFT,
+ .ts_low_mask = TS_LOW_BIT << TS_LOW_SHIFT,
+ .ts_high_shift = TS_HI_SHIFT,
+ .ts_high_mask = TS_HI_BIT << TS_HI_SHIFT,
+ .ts_shift = dma_ts_shift,
+ .ts_shift_num = ARRAY_SIZE(dma_ts_shift),
+ .dmaor_init = DMAOR_DME,
+ .chclr_present = 1,
+ .chclr_bitwise = 1,
+};
+
+static struct resource r8a7790_audio_dmac_resources[] = {
+ /* Channel registers and DMAOR for low */
+ DEFINE_RES_MEM(0xec700020, 0x8663 - 0x20),
+ DEFINE_RES_IRQ(gic_spi(346)),
+ DEFINE_RES_NAMED(gic_spi(320), 13, NULL, IORESOURCE_IRQ),
+
+ /* Channel registers and DMAOR for hi */
+ DEFINE_RES_MEM(0xec720020, 0x8663 - 0x20), /* hi */
+ DEFINE_RES_IRQ(gic_spi(347)),
+ DEFINE_RES_NAMED(gic_spi(333), 13, NULL, IORESOURCE_IRQ),
+};
+
+#define r8a7790_register_audio_dmac(id) \
+ platform_device_register_resndata( \
+ &platform_bus, "sh-dma-engine", id, \
+ &r8a7790_audio_dmac_resources[id * 3], 3, \
+ &r8a7790_audio_dmac_platform_data, \
+ sizeof(r8a7790_audio_dmac_platform_data))
+
static const struct resource pfc_resources[] __initconst = {
DEFINE_RES_MEM(0xe6060000, 0x250),
};
@@ -101,6 +189,8 @@ void __init r8a7790_pinmux_init(void)
r8a7790_register_i2c(1);
r8a7790_register_i2c(2);
r8a7790_register_i2c(3);
+ r8a7790_register_audio_dmac(0);
+ r8a7790_register_audio_dmac(1);
}
#define __R8A7790_SCIF(scif_type, _scscr, index, baseaddr, irq) \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] ARM: shmobile: r8a7790: add Audio DMAC support
2013-08-28 1:43 ` Simon Horman
` (2 preceding siblings ...)
(?)
@ 2014-01-09 8:08 ` Simon Horman
-1 siblings, 0 replies; 24+ messages in thread
From: Simon Horman @ 2014-01-09 8:08 UTC (permalink / raw)
To: linux-sh
On Mon, Jan 06, 2014 at 12:32:54AM -0800, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> R-Car H2 has many DMACs
> (ex SYS-DMAC, 2D-DMAC, Audio-DMAC, USB-DMAC etc)
> and, these DMAEngine needs DMA slave IDs to use it.
>
> This patch adds new DMA slave ID list for r8a7790.
> There, common part has RCAR_DMA_xxx prefix,
> and Audio DMAC part has AUDIO_DMAC_SLAVE_xxx prefix.
>
> Audio DMAC can be controlled via sh-dma-engine
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks, I will queue this up.
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-29 11:00 ` Yoshihiro Shimoda
0 siblings, 0 replies; 24+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-29 11:00 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index e06c486..e6b04f2 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -902,4 +902,14 @@
#size-cells = <0>;
status = "disabled";
};
+
+ xhci: xhci@ee000000 {
+ compatible = "renesas,xhci-r8a7790";
+ reg = <0 0xee000000 0 0xc00>;
+ interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
+ phys = <&usbphy 1 1>;
+ phy-names = "usb";
+ status = "disabled";
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-29 11:00 ` Yoshihiro Shimoda
0 siblings, 0 replies; 24+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-29 11:00 UTC (permalink / raw)
To: Simon Horman, SH-Linux, Rob Herring, pawel.moll, mark.rutland,
ijc+devicetree, galak, devicetree@vger.kernel.org
Cc: Magnus Damm, linux-arm-kernel@lists.infradead.org
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index e06c486..e6b04f2 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -902,4 +902,14 @@
#size-cells = <0>;
status = "disabled";
};
+
+ xhci: xhci@ee000000 {
+ compatible = "renesas,xhci-r8a7790";
+ reg = <0 0xee000000 0 0xc00>;
+ interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
+ phys = <&usbphy 1 1>;
+ phy-names = "usb";
+ status = "disabled";
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-29 11:00 ` Yoshihiro Shimoda
0 siblings, 0 replies; 24+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-29 11:00 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index e06c486..e6b04f2 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -902,4 +902,14 @@
#size-cells = <0>;
status = "disabled";
};
+
+ xhci: xhci at ee000000 {
+ compatible = "renesas,xhci-r8a7790";
+ reg = <0 0xee000000 0 0xc00>;
+ interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
+ phys = <&usbphy 1 1>;
+ phy-names = "usb";
+ status = "disabled";
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
2014-05-29 11:00 ` Yoshihiro Shimoda
(?)
@ 2014-05-29 16:08 ` Sergei Shtylyov
-1 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2014-05-29 16:08 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 05/29/2014 03:00 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index e06c486..e6b04f2 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -902,4 +902,14 @@
> #size-cells = <0>;
> status = "disabled";
> };
> +
> + xhci: xhci@ee000000 {
The node name should be "usb@ee000000", according to section 2.2.2 of the
ePAPR standard [1]:
> + compatible = "renesas,xhci-r8a7790";
> + reg = <0 0xee000000 0 0xc00>;
> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
> + phys = <&usbphy 1 1>;
This part is dependent on the generic PHY support in the USB HCD in order
to work.
> + phy-names = "usb";
> + status = "disabled";
> + };
> };
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-29 16:08 ` Sergei Shtylyov
0 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2014-05-29 16:08 UTC (permalink / raw)
To: Yoshihiro Shimoda, Simon Horman, SH-Linux, Rob Herring,
pawel.moll, mark.rutland, ijc+devicetree, galak,
devicetree@vger.kernel.org
Cc: Magnus Damm, linux-arm-kernel@lists.infradead.org
Hello.
On 05/29/2014 03:00 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index e06c486..e6b04f2 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -902,4 +902,14 @@
> #size-cells = <0>;
> status = "disabled";
> };
> +
> + xhci: xhci@ee000000 {
The node name should be "usb@ee000000", according to section 2.2.2 of the
ePAPR standard [1]:
> + compatible = "renesas,xhci-r8a7790";
> + reg = <0 0xee000000 0 0xc00>;
> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
> + phys = <&usbphy 1 1>;
This part is dependent on the generic PHY support in the USB HCD in order
to work.
> + phy-names = "usb";
> + status = "disabled";
> + };
> };
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-29 16:08 ` Sergei Shtylyov
0 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2014-05-29 16:08 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 05/29/2014 03:00 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index e06c486..e6b04f2 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -902,4 +902,14 @@
> #size-cells = <0>;
> status = "disabled";
> };
> +
> + xhci: xhci at ee000000 {
The node name should be "usb at ee000000", according to section 2.2.2 of the
ePAPR standard [1]:
> + compatible = "renesas,xhci-r8a7790";
> + reg = <0 0xee000000 0 0xc00>;
> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
> + phys = <&usbphy 1 1>;
This part is dependent on the generic PHY support in the USB HCD in order
to work.
> + phy-names = "usb";
> + status = "disabled";
> + };
> };
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
2014-05-29 16:08 ` Sergei Shtylyov
(?)
@ 2014-05-30 12:14 ` Yoshihiro Shimoda
-1 siblings, 0 replies; 24+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-30 12:14 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
(2014/05/30 1:08), Sergei Shtylyov wrote:
> Hello.
>
> On 05/29/2014 03:00 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> index e06c486..e6b04f2 100644
>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -902,4 +902,14 @@
>> #size-cells = <0>;
>> status = "disabled";
>> };
>> +
>> + xhci: xhci@ee000000 {
>
> The node name should be "usb@ee000000", according to section 2.2.2 of the
> ePAPR standard [1]:
Thank you for the point! I will fix this and r8a7791's one.
>> + compatible = "renesas,xhci-r8a7790";
>> + reg = <0 0xee000000 0 0xc00>;
>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>> + phys = <&usbphy 1 1>;
>
> This part is dependent on the generic PHY support in the USB HCD in order
> to work.
This means that I should wait to add this parameter until the generic USB PHY Gen2
driver is supported in upstream?
Best regards,
Yoshihiro Shimoda
>> + phy-names = "usb";
>> + status = "disabled";
>> + };
>> };
>
> [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
>
> WBR, Sergei
>
--
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-30 12:14 ` Yoshihiro Shimoda
0 siblings, 0 replies; 24+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-30 12:14 UTC (permalink / raw)
To: Sergei Shtylyov, Simon Horman, SH-Linux, Rob Herring,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org
Cc: Magnus Damm, linux-arm-kernel@lists.infradead.org
Hello.
(2014/05/30 1:08), Sergei Shtylyov wrote:
> Hello.
>
> On 05/29/2014 03:00 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> index e06c486..e6b04f2 100644
>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -902,4 +902,14 @@
>> #size-cells = <0>;
>> status = "disabled";
>> };
>> +
>> + xhci: xhci@ee000000 {
>
> The node name should be "usb@ee000000", according to section 2.2.2 of the
> ePAPR standard [1]:
Thank you for the point! I will fix this and r8a7791's one.
>> + compatible = "renesas,xhci-r8a7790";
>> + reg = <0 0xee000000 0 0xc00>;
>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>> + phys = <&usbphy 1 1>;
>
> This part is dependent on the generic PHY support in the USB HCD in order
> to work.
This means that I should wait to add this parameter until the generic USB PHY Gen2
driver is supported in upstream?
Best regards,
Yoshihiro Shimoda
>> + phy-names = "usb";
>> + status = "disabled";
>> + };
>> };
>
> [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
>
> WBR, Sergei
>
--
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-30 12:14 ` Yoshihiro Shimoda
0 siblings, 0 replies; 24+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-30 12:14 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
(2014/05/30 1:08), Sergei Shtylyov wrote:
> Hello.
>
> On 05/29/2014 03:00 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> index e06c486..e6b04f2 100644
>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -902,4 +902,14 @@
>> #size-cells = <0>;
>> status = "disabled";
>> };
>> +
>> + xhci: xhci at ee000000 {
>
> The node name should be "usb at ee000000", according to section 2.2.2 of the
> ePAPR standard [1]:
Thank you for the point! I will fix this and r8a7791's one.
>> + compatible = "renesas,xhci-r8a7790";
>> + reg = <0 0xee000000 0 0xc00>;
>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>> + phys = <&usbphy 1 1>;
>
> This part is dependent on the generic PHY support in the USB HCD in order
> to work.
This means that I should wait to add this parameter until the generic USB PHY Gen2
driver is supported in upstream?
Best regards,
Yoshihiro Shimoda
>> + phy-names = "usb";
>> + status = "disabled";
>> + };
>> };
>
> [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
>
> WBR, Sergei
>
--
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
2014-05-30 12:14 ` Yoshihiro Shimoda
(?)
@ 2014-05-30 13:08 ` Sergei Shtylyov
-1 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2014-05-30 13:08 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 05/30/2014 04:14 PM, Yoshihiro Shimoda wrote:
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>> index e06c486..e6b04f2 100644
>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>> @@ -902,4 +902,14 @@
>>> #size-cells = <0>;
>>> status = "disabled";
>>> };
>>> +
>>> + xhci: xhci@ee000000 {
>> The node name should be "usb@ee000000", according to section 2.2.2 of the
>> ePAPR standard [1]:
> Thank you for the point! I will fix this and r8a7791's one.
>>> + compatible = "renesas,xhci-r8a7790";
>>> + reg = <0 0xee000000 0 0xc00>;
>>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>>> + phys = <&usbphy 1 1>;
>> This part is dependent on the generic PHY support in the USB HCD in order
>> to work.
Oops, I hadn't seen that you added generic PHY support to the xHCI driver
when writing this. I'm however for adding the generic PHY support to the
generic USB HCD code, so that we can use it for the PCI controllers.
> This means that I should wait to add this parameter until the generic USB PHY Gen2
> driver is supported in upstream?
At least describe that dependency.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-30 13:08 ` Sergei Shtylyov
0 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2014-05-30 13:08 UTC (permalink / raw)
To: Yoshihiro Shimoda, Simon Horman, SH-Linux, Rob Herring,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org
Cc: Magnus Damm, linux-arm-kernel@lists.infradead.org
Hello.
On 05/30/2014 04:14 PM, Yoshihiro Shimoda wrote:
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>> index e06c486..e6b04f2 100644
>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>> @@ -902,4 +902,14 @@
>>> #size-cells = <0>;
>>> status = "disabled";
>>> };
>>> +
>>> + xhci: xhci@ee000000 {
>> The node name should be "usb@ee000000", according to section 2.2.2 of the
>> ePAPR standard [1]:
> Thank you for the point! I will fix this and r8a7791's one.
>>> + compatible = "renesas,xhci-r8a7790";
>>> + reg = <0 0xee000000 0 0xc00>;
>>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>>> + phys = <&usbphy 1 1>;
>> This part is dependent on the generic PHY support in the USB HCD in order
>> to work.
Oops, I hadn't seen that you added generic PHY support to the xHCI driver
when writing this. I'm however for adding the generic PHY support to the
generic USB HCD code, so that we can use it for the PCI controllers.
> This means that I should wait to add this parameter until the generic USB PHY Gen2
> driver is supported in upstream?
At least describe that dependency.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-30 13:08 ` Sergei Shtylyov
0 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2014-05-30 13:08 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 05/30/2014 04:14 PM, Yoshihiro Shimoda wrote:
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>> index e06c486..e6b04f2 100644
>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>> @@ -902,4 +902,14 @@
>>> #size-cells = <0>;
>>> status = "disabled";
>>> };
>>> +
>>> + xhci: xhci at ee000000 {
>> The node name should be "usb at ee000000", according to section 2.2.2 of the
>> ePAPR standard [1]:
> Thank you for the point! I will fix this and r8a7791's one.
>>> + compatible = "renesas,xhci-r8a7790";
>>> + reg = <0 0xee000000 0 0xc00>;
>>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>>> + phys = <&usbphy 1 1>;
>> This part is dependent on the generic PHY support in the USB HCD in order
>> to work.
Oops, I hadn't seen that you added generic PHY support to the xHCI driver
when writing this. I'm however for adding the generic PHY support to the
generic USB HCD code, so that we can use it for the PCI controllers.
> This means that I should wait to add this parameter until the generic USB PHY Gen2
> driver is supported in upstream?
At least describe that dependency.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
2014-05-30 13:08 ` Sergei Shtylyov
(?)
@ 2014-05-30 13:38 ` Yoshihiro Shimoda
-1 siblings, 0 replies; 24+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-30 13:38 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
(2014/05/30 22:08), Sergei Shtylyov wrote:
> Hello.
>
> On 05/30/2014 04:14 PM, Yoshihiro Shimoda wrote:
>
>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>> ---
>>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>>>> 1 file changed, 10 insertions(+)
>
>>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>>> index e06c486..e6b04f2 100644
>>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>>> @@ -902,4 +902,14 @@
>>>> #size-cells = <0>;
>>>> status = "disabled";
>>>> };
>>>> +
>>>> + xhci: xhci@ee000000 {
>
>>> The node name should be "usb@ee000000", according to section 2.2.2 of the
>>> ePAPR standard [1]:
>
>> Thank you for the point! I will fix this and r8a7791's one.
>
>>>> + compatible = "renesas,xhci-r8a7790";
>>>> + reg = <0 0xee000000 0 0xc00>;
>>>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>>>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>>>> + phys = <&usbphy 1 1>;
>
>>> This part is dependent on the generic PHY support in the USB HCD in order
>>> to work.
>
> Oops, I hadn't seen that you added generic PHY support to the xHCI driver when writing this. I'm however for adding the generic PHY support to the generic USB HCD code, so that we can use it for the PCI controllers.
>
>> This means that I should wait to add this parameter until the generic USB PHY Gen2
>> driver is supported in upstream?
>
> At least describe that dependency.
Thank you for the reply! I will add such a describption in change log.
Best regards,
Yoshihiro Shimoda
>> Best regards,
>> Yoshihiro Shimoda
>
> WBR, Sergei
>
--
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-30 13:38 ` Yoshihiro Shimoda
0 siblings, 0 replies; 24+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-30 13:38 UTC (permalink / raw)
To: Sergei Shtylyov, Simon Horman, SH-Linux, Rob Herring,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org
Cc: Magnus Damm, linux-arm-kernel@lists.infradead.org
Hello.
(2014/05/30 22:08), Sergei Shtylyov wrote:
> Hello.
>
> On 05/30/2014 04:14 PM, Yoshihiro Shimoda wrote:
>
>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>> ---
>>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>>>> 1 file changed, 10 insertions(+)
>
>>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>>> index e06c486..e6b04f2 100644
>>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>>> @@ -902,4 +902,14 @@
>>>> #size-cells = <0>;
>>>> status = "disabled";
>>>> };
>>>> +
>>>> + xhci: xhci@ee000000 {
>
>>> The node name should be "usb@ee000000", according to section 2.2.2 of the
>>> ePAPR standard [1]:
>
>> Thank you for the point! I will fix this and r8a7791's one.
>
>>>> + compatible = "renesas,xhci-r8a7790";
>>>> + reg = <0 0xee000000 0 0xc00>;
>>>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>>>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>>>> + phys = <&usbphy 1 1>;
>
>>> This part is dependent on the generic PHY support in the USB HCD in order
>>> to work.
>
> Oops, I hadn't seen that you added generic PHY support to the xHCI driver when writing this. I'm however for adding the generic PHY support to the generic USB HCD code, so that we can use it for the PCI controllers.
>
>> This means that I should wait to add this parameter until the generic USB PHY Gen2
>> driver is supported in upstream?
>
> At least describe that dependency.
Thank you for the reply! I will add such a describption in change log.
Best regards,
Yoshihiro Shimoda
>> Best regards,
>> Yoshihiro Shimoda
>
> WBR, Sergei
>
--
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-30 13:38 ` Yoshihiro Shimoda
0 siblings, 0 replies; 24+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-30 13:38 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
(2014/05/30 22:08), Sergei Shtylyov wrote:
> Hello.
>
> On 05/30/2014 04:14 PM, Yoshihiro Shimoda wrote:
>
>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>> ---
>>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>>>> 1 file changed, 10 insertions(+)
>
>>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>>> index e06c486..e6b04f2 100644
>>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>>> @@ -902,4 +902,14 @@
>>>> #size-cells = <0>;
>>>> status = "disabled";
>>>> };
>>>> +
>>>> + xhci: xhci at ee000000 {
>
>>> The node name should be "usb at ee000000", according to section 2.2.2 of the
>>> ePAPR standard [1]:
>
>> Thank you for the point! I will fix this and r8a7791's one.
>
>>>> + compatible = "renesas,xhci-r8a7790";
>>>> + reg = <0 0xee000000 0 0xc00>;
>>>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>>>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>>>> + phys = <&usbphy 1 1>;
>
>>> This part is dependent on the generic PHY support in the USB HCD in order
>>> to work.
>
> Oops, I hadn't seen that you added generic PHY support to the xHCI driver when writing this. I'm however for adding the generic PHY support to the generic USB HCD code, so that we can use it for the PCI controllers.
>
>> This means that I should wait to add this parameter until the generic USB PHY Gen2
>> driver is supported in upstream?
>
> At least describe that dependency.
Thank you for the reply! I will add such a describption in change log.
Best regards,
Yoshihiro Shimoda
>> Best regards,
>> Yoshihiro Shimoda
>
> WBR, Sergei
>
--
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 24+ messages in thread