From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl
Subject: Re: [PATCH v3 3/3] smiapp: Implement the test pattern control
Date: Thu, 29 May 2014 18:14:06 +0300 [thread overview]
Message-ID: <53874EBE.9040108@linux.intel.com> (raw)
In-Reply-To: <2777039.3n5AP3eAS8@avalon>
Laurent Pinchart wrote:
>> @@ -543,6 +594,14 @@ static int smiapp_init_controls(struct smiapp_sensor
>> *sensor) goto error;
>> }
>>
>> + for (i = 0; i < ARRAY_SIZE(sensor->test_data); i++) {
>> + struct v4l2_ctrl *ctrl = sensor->test_data[i];
>> +
>> + ctrl->maximum =
>> + ctrl->default_value =
>> + ctrl->cur.val = (1 << sensor->csi_format->width) - 1;
>
> I think multiple assignments on the same line are discouraged.
>
> Furthermore, couldn't you move this above and use the right values directly
> when creating the controls ?
Good point. There might have been a reason to do this in a past version
of the patch but it no longer exists.
--
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2014-05-29 15:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 14:40 [PATCH v3 0/3] smiapp test pattern support Sakari Ailus
2014-05-29 14:40 ` [PATCH v3 1/3] v4l: Add test pattern colour component controls Sakari Ailus
2014-05-29 14:47 ` Laurent Pinchart
2014-05-29 14:58 ` Sakari Ailus
2014-05-29 15:01 ` Laurent Pinchart
2014-05-30 12:28 ` Hans Verkuil
2014-06-03 12:21 ` Laurent Pinchart
2014-06-03 12:27 ` Sakari Ailus
2014-06-03 12:42 ` Hans Verkuil
2014-06-10 12:15 ` Hans Verkuil
2014-05-29 14:40 ` [PATCH v3 2/3] smiapp: Add driver-specific test pattern menu item definitions Sakari Ailus
2014-05-29 14:48 ` Laurent Pinchart
2014-05-29 15:08 ` Sakari Ailus
2014-06-10 12:16 ` Hans Verkuil
2014-06-10 15:57 ` Prabhakar Lad
2014-06-11 6:34 ` Sakari Ailus
2014-06-11 6:36 ` [PATCH v3.1 2/4] " Sakari Ailus
2014-06-11 7:58 ` Prabhakar Lad
2014-05-29 14:40 ` [PATCH v3 3/3] smiapp: Implement the test pattern control Sakari Ailus
2014-05-29 14:54 ` Laurent Pinchart
2014-05-29 15:01 ` Sakari Ailus
2014-05-29 15:14 ` Sakari Ailus [this message]
2014-05-29 15:16 ` [PATCH v3.1 " Sakari Ailus
2014-07-10 14:16 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53874EBE.9040108@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.