All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawn.guo@freescale.com>, Tejun Heo <tj@kernel.org>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	linux-ide@vger.kernel.org,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] ahci: imx: manage only sata_ref_clk in imx_sata_enable[disable]
Date: Fri, 30 May 2014 09:55:10 +0200	[thread overview]
Message-ID: <5388395E.80500@redhat.com> (raw)
In-Reply-To: <CAOMZO5Az_JR58a3cwGYK1_vcJ_twz4sEq+NHXv2SZ6yuN=wjGQ@mail.gmail.com>

Hi,

On 05/28/2014 06:48 PM, Fabio Estevam wrote:
> On Wed, May 28, 2014 at 1:37 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> 
>> Ah yes I see, the ahci_imx suspend/resume handler now no longer
>> touches the controller, but the ata core is still trying to use it.
>>
>> Ok, in that case I agree that your original patch is the best
>> solution.
>>
>> Your original patch is:
>>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
> 
> I think you meant Shawn's patch, not mine :-)

Right, so to be extra clear, the patch titled:

"ahci: imx: manage only sata_ref_clk in imx_sata_enable[disable]"

is:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


WARNING: multiple messages have this Message-ID (diff)
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ahci: imx: manage only sata_ref_clk in imx_sata_enable[disable]
Date: Fri, 30 May 2014 09:55:10 +0200	[thread overview]
Message-ID: <5388395E.80500@redhat.com> (raw)
In-Reply-To: <CAOMZO5Az_JR58a3cwGYK1_vcJ_twz4sEq+NHXv2SZ6yuN=wjGQ@mail.gmail.com>

Hi,

On 05/28/2014 06:48 PM, Fabio Estevam wrote:
> On Wed, May 28, 2014 at 1:37 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> 
>> Ah yes I see, the ahci_imx suspend/resume handler now no longer
>> touches the controller, but the ata core is still trying to use it.
>>
>> Ok, in that case I agree that your original patch is the best
>> solution.
>>
>> Your original patch is:
>>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
> 
> I think you meant Shawn's patch, not mine :-)

Right, so to be extra clear, the patch titled:

"ahci: imx: manage only sata_ref_clk in imx_sata_enable[disable]"

is:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

  reply	other threads:[~2014-05-30  7:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-28 15:05 [PATCH] ahci: imx: manage only sata_ref_clk in imx_sata_enable[disable] Shawn Guo
2014-05-28 15:05 ` Shawn Guo
2014-05-28 15:36 ` Hans de Goede
2014-05-28 15:36   ` Hans de Goede
2014-05-28 15:59   ` Fabio Estevam
2014-05-28 15:59     ` Fabio Estevam
2014-05-28 16:37     ` Hans de Goede
2014-05-28 16:37       ` Hans de Goede
2014-05-28 16:48       ` Fabio Estevam
2014-05-28 16:48         ` Fabio Estevam
2014-05-30  7:55         ` Hans de Goede [this message]
2014-05-30  7:55           ` Hans de Goede
2014-05-28 15:52 ` Fabio Estevam
2014-05-28 15:52   ` Fabio Estevam
2014-06-19 14:15 ` Tejun Heo
2014-06-19 14:15   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5388395E.80500@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=shawn.guo@freescale.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.