From: Alexander Graf <agraf@suse.de>
To: Michael Neuling <mikey@neuling.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
kvm-ppc@vger.kernel.org,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: powerpc/pseries: Use new defines when calling h_set_mode
Date: Fri, 30 May 2014 09:44:53 +0000 [thread overview]
Message-ID: <53885315.2070004@suse.de> (raw)
In-Reply-To: <CAEjGV6ym8pX6eOzcPb+CY7U-wDUSp5wKBOBuW3m1ZmKzSdhyfg@mail.gmail.com>
On 30.05.14 11:44, Michael Neuling wrote:
>
>
> >>>
> >>> Which header are these coming from, and why aren't we including
> it? And is it
> >>> going to still build with CONFIG_KVM=n?
> >>
> >> From include/asm/hvcall.h in the h_set_mode patch set I sent before.
> >>
> >> And yes it compiles with CONFIG_KVM=n fine.
> >
> >
> > Please split that patch into one that adds the definitions and one
> that changes the KVM code to use those definitions. Both Ben and me
> can then apply the definition patch and our respective tree patch.
> >
>
> Why don't you just take the original h_set_mode patch and I'll repost
> this cleanup later to ben when yours is upstream. This cleanup patch
> is not critical to anything and it avoid more churn.
>
That works too, but please keep in mind that my path to upstream is much
longer than what you're used to ;).
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
kvm-ppc@vger.kernel.org
Subject: Re: powerpc/pseries: Use new defines when calling h_set_mode
Date: Fri, 30 May 2014 11:44:53 +0200 [thread overview]
Message-ID: <53885315.2070004@suse.de> (raw)
In-Reply-To: <CAEjGV6ym8pX6eOzcPb+CY7U-wDUSp5wKBOBuW3m1ZmKzSdhyfg@mail.gmail.com>
On 30.05.14 11:44, Michael Neuling wrote:
>
>
> >>>
> >>> Which header are these coming from, and why aren't we including
> it? And is it
> >>> going to still build with CONFIG_KVM=n?
> >>
> >> From include/asm/hvcall.h in the h_set_mode patch set I sent before.
> >>
> >> And yes it compiles with CONFIG_KVM=n fine.
> >
> >
> > Please split that patch into one that adds the definitions and one
> that changes the KVM code to use those definitions. Both Ben and me
> can then apply the definition patch and our respective tree patch.
> >
>
> Why don't you just take the original h_set_mode patch and I'll repost
> this cleanup later to ben when yours is upstream. This cleanup patch
> is not critical to anything and it avoid more churn.
>
That works too, but please keep in mind that my path to upstream is much
longer than what you're used to ;).
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Michael Neuling <mikey@neuling.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
kvm-ppc@vger.kernel.org,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: powerpc/pseries: Use new defines when calling h_set_mode
Date: Fri, 30 May 2014 11:44:53 +0200 [thread overview]
Message-ID: <53885315.2070004@suse.de> (raw)
In-Reply-To: <CAEjGV6ym8pX6eOzcPb+CY7U-wDUSp5wKBOBuW3m1ZmKzSdhyfg@mail.gmail.com>
On 30.05.14 11:44, Michael Neuling wrote:
>
>
> >>>
> >>> Which header are these coming from, and why aren't we including
> it? And is it
> >>> going to still build with CONFIG_KVM=n?
> >>
> >> From include/asm/hvcall.h in the h_set_mode patch set I sent before.
> >>
> >> And yes it compiles with CONFIG_KVM=n fine.
> >
> >
> > Please split that patch into one that adds the definitions and one
> that changes the KVM code to use those definitions. Both Ben and me
> can then apply the definition patch and our respective tree patch.
> >
>
> Why don't you just take the original h_set_mode patch and I'll repost
> this cleanup later to ben when yours is upstream. This cleanup patch
> is not critical to anything and it avoid more churn.
>
That works too, but please keep in mind that my path to upstream is much
longer than what you're used to ;).
Alex
next prev parent reply other threads:[~2014-05-30 9:44 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 12:17 [PATCH 0/3] New PAPR hypercall plus individual hypercall enables Paul Mackerras
2014-05-26 12:17 ` Paul Mackerras
2014-05-26 12:17 ` [PATCH 1/3] KVM: PPC: Book3S: Controls for in-kernel PAPR hypercall handling Paul Mackerras
2014-05-26 12:17 ` Paul Mackerras
2014-05-28 13:27 ` Alexander Graf
2014-05-28 13:27 ` Alexander Graf
2014-05-29 5:27 ` Paul Mackerras
2014-05-29 5:27 ` Paul Mackerras
2014-05-29 6:35 ` Alexander Graf
2014-05-29 6:35 ` Alexander Graf
2014-05-26 12:17 ` [PATCH 2/3] KVM: PPC: Book3S: Allow only implemented hcalls to be enabled or disabled Paul Mackerras
2014-05-26 12:17 ` Paul Mackerras
2014-05-28 13:30 ` Alexander Graf
2014-05-28 13:30 ` Alexander Graf
2014-05-26 12:17 ` [PATCH 3/3] KVM: PPC: Book3S HV: Add H_SET_MODE hcall handling Paul Mackerras
2014-05-26 12:17 ` Paul Mackerras
2014-05-28 13:35 ` Alexander Graf
2014-05-28 13:35 ` Alexander Graf
2014-05-29 5:47 ` Michael Neuling
2014-05-29 5:47 ` Michael Neuling
2014-05-29 6:22 ` [PATCH v2 " Michael Neuling
2014-05-29 6:22 ` Michael Neuling
2014-05-29 7:18 ` Alexander Graf
2014-05-29 7:18 ` Alexander Graf
2014-05-29 7:45 ` powerpc/pseries: Use new defines when calling h_set_mode Michael Neuling
2014-05-29 7:45 ` Michael Neuling
2014-05-29 7:45 ` Michael Neuling
2014-05-29 21:27 ` Alexander Graf
2014-05-29 21:27 ` Alexander Graf
2014-05-29 21:27 ` Alexander Graf
2014-05-29 21:52 ` Benjamin Herrenschmidt
2014-05-29 21:52 ` Benjamin Herrenschmidt
2014-05-29 21:52 ` Benjamin Herrenschmidt
2014-05-30 7:44 ` Alexander Graf
2014-05-30 7:44 ` Alexander Graf
2014-05-30 7:44 ` Alexander Graf
2014-05-30 8:56 ` Michael Ellerman
2014-05-30 8:56 ` Michael Ellerman
2014-05-30 8:56 ` Michael Ellerman
2014-05-30 9:10 ` Michael Neuling
2014-05-30 9:10 ` Michael Neuling
2014-05-30 9:10 ` Michael Neuling
2014-05-30 9:13 ` Alexander Graf
2014-05-30 9:13 ` Alexander Graf
2014-05-30 9:13 ` Alexander Graf
2014-05-30 9:44 ` Michael Neuling
2014-05-30 9:44 ` Michael Neuling
2014-05-30 9:44 ` Alexander Graf [this message]
2014-05-30 9:44 ` Alexander Graf
2014-05-30 9:44 ` Alexander Graf
2014-05-31 7:21 ` [PATCH 0/3] New PAPR hypercall plus individual hypercall enables, v2 Paul Mackerras
2014-05-31 7:21 ` Paul Mackerras
2014-05-31 7:21 ` [PATCH 1/3] KVM: PPC: Book3S: Controls for in-kernel PAPR hypercall handling Paul Mackerras
2014-05-31 7:21 ` Paul Mackerras
2014-06-01 9:55 ` Alexander Graf
2014-06-01 9:55 ` Alexander Graf
2014-05-31 7:21 ` [PATCH 2/3] KVM: PPC: Book3S: Allow only implemented hcalls to be enabled or disabled Paul Mackerras
2014-05-31 7:21 ` Paul Mackerras
2014-05-31 7:21 ` [PATCH 3/3] KVM: PPC: Book3S HV: Add H_SET_MODE hcall handling Paul Mackerras
2014-05-31 7:21 ` Paul Mackerras
2014-06-01 10:01 ` [PATCH 0/3] New PAPR hypercall plus individual hypercall enables, v2 Alexander Graf
2014-06-01 10:01 ` Alexander Graf
2014-06-02 1:02 ` [PATCH 0/3] New PAPR hypercall plus individual hypercall enables, v3 Paul Mackerras
2014-06-02 1:02 ` Paul Mackerras
2014-06-02 1:02 ` [PATCH 1/3] KVM: PPC: Book3S: Controls for in-kernel sPAPR hypercall handling Paul Mackerras
2014-06-02 1:02 ` Paul Mackerras
2014-06-02 1:03 ` [PATCH 2/3] KVM: PPC: Book3S: Allow only implemented hcalls to be enabled or disabled Paul Mackerras
2014-06-02 1:03 ` Paul Mackerras
2014-06-02 1:03 ` [PATCH 3/3] KVM: PPC: Book3S HV: Add H_SET_MODE hcall handling Paul Mackerras
2014-06-02 1:03 ` Paul Mackerras
2014-06-25 21:46 ` [PATCH 0/3] New PAPR hypercall plus individual hypercall enables, v3 Alexander Graf
2014-06-25 21:46 ` Alexander Graf
2014-06-25 23:08 ` Paul Mackerras
2014-06-25 23:08 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53885315.2070004@suse.de \
--to=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.