All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: SH-Linux <linux-sh@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] usb: host: xhci-plat: add optional PHY support
Date: Fri, 30 May 2014 13:48:20 +0000	[thread overview]
Message-ID: <53888C24.4070203@renesas.com> (raw)
In-Reply-To: <53876BB6.3040304@cogentembedded.com>

Hello.

(2014/05/30 2:17), Sergei Shtylyov wrote:
> Hello.
> 
> On 05/29/2014 05:32 AM, Yoshihiro Shimoda wrote:
> 
>> From: Gregory CLEMENT <gregory.clement@free-electrons.com>
> 
>> This commit extends the xhci-plat so that it can optionally be passed
>> a reference to a PHY through the Device Tree. It will be useful for
>> the Armada 375 SoCs. If no PHY is provided then the behavior of the
>> driver is unchanged.
> 
>> As for the clock, to achieve this, it adds a 'struct phy *' member in
>> xhci_hcd. While only used for now in xhci-plat, here again, it might
>> be used by other drivers in the future.
> 
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>>   drivers/usb/host/xhci-plat.c |   27 ++++++++++++++++++++++++++-
>>   drivers/usb/host/xhci.h      |    2 ++
>>   2 files changed, 28 insertions(+), 1 deletion(-)
> 
>     I've already posted a patch adding generic PHY support to all USB HCDs 
> about 1.5 months ago, which should make this patch unneeded.

Thank you for the point. So, I will not use this patch.
And, I could clean up xhci-rcar patch! (ioremap is not needed)

Best regards,
Yoshihiro Shimoda

> WBR, Sergei
> 

-- 
Yoshihiro Shimoda

WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: SH-Linux <linux-sh@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] usb: host: xhci-plat: add optional PHY support
Date: Fri, 30 May 2014 22:48:20 +0900	[thread overview]
Message-ID: <53888C24.4070203@renesas.com> (raw)
In-Reply-To: <53876BB6.3040304@cogentembedded.com>

Hello.

(2014/05/30 2:17), Sergei Shtylyov wrote:
> Hello.
> 
> On 05/29/2014 05:32 AM, Yoshihiro Shimoda wrote:
> 
>> From: Gregory CLEMENT <gregory.clement@free-electrons.com>
> 
>> This commit extends the xhci-plat so that it can optionally be passed
>> a reference to a PHY through the Device Tree. It will be useful for
>> the Armada 375 SoCs. If no PHY is provided then the behavior of the
>> driver is unchanged.
> 
>> As for the clock, to achieve this, it adds a 'struct phy *' member in
>> xhci_hcd. While only used for now in xhci-plat, here again, it might
>> be used by other drivers in the future.
> 
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>>   drivers/usb/host/xhci-plat.c |   27 ++++++++++++++++++++++++++-
>>   drivers/usb/host/xhci.h      |    2 ++
>>   2 files changed, 28 insertions(+), 1 deletion(-)
> 
>     I've already posted a patch adding generic PHY support to all USB HCDs 
> about 1.5 months ago, which should make this patch unneeded.

Thank you for the point. So, I will not use this patch.
And, I could clean up xhci-rcar patch! (ioremap is not needed)

Best regards,
Yoshihiro Shimoda

> WBR, Sergei
> 

-- 
Yoshihiro Shimoda

  reply	other threads:[~2014-05-30 13:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29  1:32 [PATCH v3 1/2] usb: host: xhci-plat: add optional PHY support Yoshihiro Shimoda
2014-05-29  1:32 ` Yoshihiro Shimoda
2014-05-29 17:17 ` Sergei Shtylyov
2014-05-29 17:17   ` Sergei Shtylyov
2014-05-30 13:48   ` Yoshihiro Shimoda [this message]
2014-05-30 13:48     ` Yoshihiro Shimoda
2016-01-13  2:00 ` [PATCH v3 1/2] usb: host: xhci-plat: add R-Car Gen2 and Gen3 fallback compatibility strings Simon Horman
2016-01-13 13:57 ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53888C24.4070203@renesas.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mathias.nyman@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.