All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neelesh Gupta <neelegup@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Guenter Roeck <linux@roeck-us.net>
Cc: sbhat@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
	jdelvare@suse.de, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH v2] powerpc/powernv: hwmon driver for power values, fan rpm and temperature
Date: Fri, 30 May 2014 14:17:30 +0000	[thread overview]
Message-ID: <5388902A.6050301@linux.vnet.ibm.com> (raw)
In-Reply-To: <1401262871.8262.22.camel@pasglop>


On 05/28/2014 01:11 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2014-05-28 at 00:23 -0700, Guenter Roeck wrote:
>> Consider using of_property_read_u32().
>>
>>> +             sdata[count].id = *sensor_id;
>>> +             sdata[count].type = type;
> Especially since this is broken for Little Endian !
>
> Neelesh, please make sure you test your patch on LE.
>
> Cheers,
> Ben.

Fixing it and will surely test on LE as well before posting.

- Neelesh


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Neelesh Gupta <neelegup@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Guenter Roeck <linux@roeck-us.net>
Cc: sbhat@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
	jdelvare@suse.de, lm-sensors@lm-sensors.org
Subject: Re: [PATCH v2] powerpc/powernv: hwmon driver for power values, fan rpm and temperature
Date: Fri, 30 May 2014 19:35:30 +0530	[thread overview]
Message-ID: <5388902A.6050301@linux.vnet.ibm.com> (raw)
In-Reply-To: <1401262871.8262.22.camel@pasglop>


On 05/28/2014 01:11 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2014-05-28 at 00:23 -0700, Guenter Roeck wrote:
>> Consider using of_property_read_u32().
>>
>>> +             sdata[count].id = *sensor_id;
>>> +             sdata[count].type = type;
> Especially since this is broken for Little Endian !
>
> Neelesh, please make sure you test your patch on LE.
>
> Cheers,
> Ben.

Fixing it and will surely test on LE as well before posting.

- Neelesh

  reply	other threads:[~2014-05-30 14:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 14:26 [PATCH v2] powerpc/powernv: hwmon driver for power values, fan rpm and temperature Neelesh Gupta
2014-05-19 14:38 ` [lm-sensors] " Neelesh Gupta
2014-05-26  6:22 ` Neelesh Gupta
2014-05-26  6:34   ` [lm-sensors] " Neelesh Gupta
2014-05-26 14:12   ` Guenter Roeck
2014-05-26 14:12     ` Guenter Roeck
2014-05-28  7:23 ` [lm-sensors] " Guenter Roeck
2014-05-28  7:23   ` Guenter Roeck
2014-05-28  7:41   ` [lm-sensors] " Benjamin Herrenschmidt
2014-05-28  7:41     ` Benjamin Herrenschmidt
2014-05-30 14:05     ` Neelesh Gupta [this message]
2014-05-30 14:17       ` [lm-sensors] " Neelesh Gupta
2014-06-09  8:15   ` Neelesh Gupta
2014-06-09  8:27     ` [lm-sensors] " Neelesh Gupta
2014-06-18  8:43   ` Neelesh Gupta
2014-06-18  8:55     ` [lm-sensors] " Neelesh Gupta
2014-06-18 13:05     ` Guenter Roeck
2014-06-18 13:05       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5388902A.6050301@linux.vnet.ibm.com \
    --to=neelegup@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=jdelvare@suse.de \
    --cc=linux@roeck-us.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=sbhat@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.