All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: "Manuel Schölling" <manuel.schoelling@gmx.de>, plagnioj@jcrosoft.com
Cc: tomi.valkeinen@ti.com, geert@linux-m68k.org, broonie@linaro.org,
	dh.herrmann@gmail.com, airlied@redhat.com, mtosatti@redhat.com,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] console: Add persistent scrollback buffers for all VGA consoles
Date: Fri, 30 May 2014 17:06:21 +0000	[thread overview]
Message-ID: <5388BA8D.3010707@infradead.org> (raw)
In-Reply-To: <1401456425-15931-1-git-send-email-manuel.schoelling@gmx.de>

On 05/30/2014 06:27 AM, Manuel Schölling wrote:
> ---
>  drivers/video/console/Kconfig  |    6 +-
>  drivers/video/console/vgacon.c |  124 ++++++++++++++++++++++++----------------
>  2 files changed, 79 insertions(+), 51 deletions(-)
> 
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index fe1cd01..d7ec96c 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -38,14 +38,14 @@ config VGACON_SOFT_SCROLLBACK
>  	 RAM to allocate for this buffer.  If unsure, say 'N'.
>  
>  config VGACON_SOFT_SCROLLBACK_SIZE
> -       int "Scrollback Buffer Size (in KB)"
> +       int "Scrollback Buffer Size per console (in KB)"
>         depends on VGACON_SOFT_SCROLLBACK
>         range 1 1024
>         default "64"
>         help
>           Enter the amount of System RAM to allocate for the scrollback
> -	 buffer.  Each 64KB will give you approximately 16 80x25
> -	 screenfuls of scrollback buffer
> +	 buffer for each VGA console. Each 64KB will give you approximately
> +	 16 80x25 screenfuls of scrollback buffer.

Nitpick: CodingStyle says to indent help text 1 tab + 2 spaces.

>  
>  config MDA_CONSOLE
>  	depends on !M68K && !PARISC && ISA

-- 
~Randy

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: "Manuel Schölling" <manuel.schoelling@gmx.de>, plagnioj@jcrosoft.com
Cc: tomi.valkeinen@ti.com, geert@linux-m68k.org, broonie@linaro.org,
	dh.herrmann@gmail.com, airlied@redhat.com, mtosatti@redhat.com,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] console: Add persistent scrollback buffers for all VGA consoles
Date: Fri, 30 May 2014 10:06:21 -0700	[thread overview]
Message-ID: <5388BA8D.3010707@infradead.org> (raw)
In-Reply-To: <1401456425-15931-1-git-send-email-manuel.schoelling@gmx.de>

On 05/30/2014 06:27 AM, Manuel Schölling wrote:
> ---
>  drivers/video/console/Kconfig  |    6 +-
>  drivers/video/console/vgacon.c |  124 ++++++++++++++++++++++++----------------
>  2 files changed, 79 insertions(+), 51 deletions(-)
> 
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index fe1cd01..d7ec96c 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -38,14 +38,14 @@ config VGACON_SOFT_SCROLLBACK
>  	 RAM to allocate for this buffer.  If unsure, say 'N'.
>  
>  config VGACON_SOFT_SCROLLBACK_SIZE
> -       int "Scrollback Buffer Size (in KB)"
> +       int "Scrollback Buffer Size per console (in KB)"
>         depends on VGACON_SOFT_SCROLLBACK
>         range 1 1024
>         default "64"
>         help
>           Enter the amount of System RAM to allocate for the scrollback
> -	 buffer.  Each 64KB will give you approximately 16 80x25
> -	 screenfuls of scrollback buffer
> +	 buffer for each VGA console. Each 64KB will give you approximately
> +	 16 80x25 screenfuls of scrollback buffer.

Nitpick: CodingStyle says to indent help text 1 tab + 2 spaces.

>  
>  config MDA_CONSOLE
>  	depends on !M68K && !PARISC && ISA

-- 
~Randy

  parent reply	other threads:[~2014-05-30 17:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30 13:27 [PATCH] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling
2014-05-30 13:27 ` Manuel Schölling
2014-05-30 14:28 ` Geert Uytterhoeven
2014-05-30 14:28   ` Geert Uytterhoeven
2014-05-30 14:57   ` Manuel Schoelling
2014-05-30 14:57     ` Manuel Schoelling
2014-05-30 17:06 ` Randy Dunlap [this message]
2014-05-30 17:06   ` Randy Dunlap
2014-05-30 22:26 ` Jakub Wilk
2014-05-30 22:26   ` Jakub Wilk
2014-05-31  9:49   ` Manuel Schoelling
2014-05-31  9:49     ` Manuel Schoelling
2016-04-23 10:07 ` Manuel Schölling
2016-04-23 10:07   ` Manuel Schölling
2016-05-02 17:59 ` Manuel Schölling
2016-05-02 17:59   ` Manuel Schölling
2016-05-09 10:39 ` Manuel Schölling
2016-05-09 10:39   ` Manuel Schölling
2016-05-16 11:25 ` Manuel Schölling
2016-05-16 11:25   ` Manuel Schölling
2016-05-23 21:07 ` Manuel Schölling
2016-05-23 21:07   ` Manuel Schölling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5388BA8D.3010707@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=airlied@redhat.com \
    --cc=broonie@linaro.org \
    --cc=dh.herrmann@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manuel.schoelling@gmx.de \
    --cc=mtosatti@redhat.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.