Re: [PATCH 2/3] exynos: fix G2D_DOUBLE_TO_FIXED

[Tomasz Figa <tomasz.figa@gmail.com>]

Hi Tobias,

First of all, thanks for spotting those issues and sending patches.

However looking at libdrm repo history, your patches don't seem to
follow formatting guidelines used there: they lack commit messages
(which should say what is changed and why) and your signed-off-by tags.

Also it is usually a good idea to include respective maintainers on Cc
list, although  unfortunately I'm not sure who would that be in case of
libdrm.

One more comment inline.

On 29.05.2014 23:58, Tobias Jakobi wrote:
> ---
>  exynos/fimg2d.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/exynos/fimg2d.h b/exynos/fimg2d.h
> index 1aac378..bc45ab5 100644
> --- a/exynos/fimg2d.h
> +++ b/exynos/fimg2d.h
> @@ -25,7 +25,7 @@
>  #define G2D_MAX_CMD_LIST_NR	64
>  #define G2D_PLANE_MAX_NR	2
>  
> -#define G2D_DOUBLE_TO_FIXED(d)		((unsigned int)(d) * 65536.0)
> +#define G2D_DOUBLE_TO_FIXED(d)		((unsigned int)(d * 65536.0))

You should also keep the parentheses around d, so that the macro
evaluates correctly even if an expression is passed as the argument.

Best regards,
Tomasz