[PATCH] backports: Avoid multiple definition of DEVICE_ATTR_RW for older kernels

[PATCH] backports: Avoid multiple definition of DEVICE_ATTR_RW for older kernels

[Emmanuel Grumbach]

From: Jonathan DE CESCO <jonathan.de.cesco@intel.com>

This definition may exists on non-vanilla kernels.

Change-Id: Ie72a291e7a5690d2509520a0440cca9926386a9c
Signed-off-by: Jonathan DE CESCO <jonathan.de.cesco@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
 backport/backport-include/linux/device.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/backport/backport-include/linux/device.h b/backport/backport-include/linux/device.h
index 3403896..e574d47 100644
--- a/backport/backport-include/linux/device.h
+++ b/backport/backport-include/linux/device.h
@@ -107,9 +107,11 @@ backport_device_release_driver(struct device *dev)
 #define DEVICE_ATTR_RO(_name) \
 struct device_attribute dev_attr_ ## _name = __ATTR_RO(_name);
 #endif
+#ifndef DEVICE_ATTR_RW
 #define DEVICE_ATTR_RW(_name) \
 struct device_attribute dev_attr_ ## _name = __ATTR_RW(_name)
 #endif
+#endif
 
 #define ATTRIBUTE_GROUPS_BACKPORT(_name) \
 static struct BP_ATTR_GRP_STRUCT _name##_dev_attrs[ARRAY_SIZE(_name##_attrs)];\
-- 
1.9.1

backports: define of NL80211_FEATURE_SK_TX_STATUS in /backport-include/linux/nl80211.h

[Vu Hai NGUYEN]

I'm using backport to compile driver ath10k. I used hostapd to set up AP mode and my interface wlan0 always set up an interface mon.wlan0 with wlan0.
This makes my AP refuse the connection with a station when my AP use a channel that employs DFS; because the monitor interface didn't respond the probe request from the station. 

I looked in the driver_nl80211.c and found that use_monitor relied on "poll_command_supported" and "data_tx_status". I printed these 2 parameters and saw that data_tx_status=0, it depends on NL80211_FEATURE_SK_TX_STATUS and this parameter was affected to the flags of wiphy->features, defined in /net/mac80211/main.c.I find this parameter was set = 0 in /backport-include/linux/nl80211.h
That's why montior mode was forced to used with AP mode. I set that parameter = 1 and no more monitor interface in AP mode, my AP works withDFS  now.
My question is why did this parameter is set to 0? It may be used for some purpose?
Thanks, 

NGUYEN Vu Hai
Acita-Sodielec
Route de Mayres - B.P. 9
12100 St GEORGES DE LUZENCON
FRANCE

Re: [PATCH] backports: Avoid multiple definition of DEVICE_ATTR_RW for older kernels

[Hauke Mehrtens]

On 05/26/2014 04:15 PM, Emmanuel Grumbach wrote:
> From: Jonathan DE CESCO <jonathan.de.cesco@intel.com>
> 
> This definition may exists on non-vanilla kernels.
> 
> Change-Id: Ie72a291e7a5690d2509520a0440cca9926386a9c
> Signed-off-by: Jonathan DE CESCO <jonathan.de.cesco@intel.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> ---
>  backport/backport-include/linux/device.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
Thank you for the patch, it was applied, pushed and is included in the
backports-20140501 release.

Hauke