All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 5/6] libxl: add libxl_vm_generation_id_set()
Date: Mon, 2 Jun 2014 10:25:44 +0100	[thread overview]
Message-ID: <538C4318.1040107@citrix.com> (raw)
In-Reply-To: <1401289017.10916.16.camel@kazak.uk.xensource.com>

On 28/05/14 15:56, Ian Campbell wrote:
> On Tue, 2014-05-27 at 18:31 +0100, David Vrabel wrote:
>> Add a function to allow a toolstack to set a domain's VM generation
>> ID.
>>
>> Although the specification requires that a ACPI Notify event is raised
>> if the generation ID is changed, in practice this appears not to be
>> necessary if the generation ID is changed while the Windows VM is
>> suspended.
> 
> Do we (or did Microsoft) envisage scenarios where the ID might change
> while the VM was not suspended?

I think the specification has been written to allow for this.  But when
running on Xen I would not anticipate this being necessary.

>> +    /*
>> +     * Update the ID in guest memory (if available).
> 
> Does "if available" here translate to "on restore"? (with on create
> being handled by hvmloader, IOW this is the cooperation I was wondering
> about on the docs patch)

Yes.

David

  reply	other threads:[~2014-06-02  9:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27 17:31 [PATCHv2 0/6] tools: rework VM Generation ID David Vrabel
2014-05-27 17:31 ` [PATCH 1/6] docs: update docs for the ~/platform/generation-id key David Vrabel
2014-05-28 14:44   ` Ian Campbell
2014-05-28 14:51     ` Andrew Cooper
2014-05-28 14:58       ` Ian Campbell
2014-05-27 17:31 ` [PATCH 2/6] hvm: add HVM_PARAM_VM_GENERATION_ID_ADDR David Vrabel
2014-05-27 17:31 ` [PATCH 3/6] tools/hvmloader: add helper functions to get/set HVM params David Vrabel
2014-05-27 17:31 ` [PATCH 4/6] libxc, libxl, hvmloader: strip out outdated VM generation ID implementation David Vrabel
2014-05-28 14:50   ` Ian Campbell
2014-06-02  9:23     ` David Vrabel
2014-05-27 17:31 ` [PATCH 5/6] libxl: add libxl_vm_generation_id_set() David Vrabel
2014-05-28 14:56   ` Ian Campbell
2014-06-02  9:25     ` David Vrabel [this message]
2014-05-27 17:31 ` [PATCH 6/6] xl: generate a new random VM generation ID if requested David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538C4318.1040107@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.