From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>, vijay.kilari@gmail.com
Cc: Prasun.Kapoor@caviumnetworks.com,
vijaya.kumar@caviumnetworks.com, xen-devel@lists.xen.org,
stefano.stabellini@citrix.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] xen/arm: remove check for generic timer support for arm64
Date: Mon, 02 Jun 2014 12:13:40 +0100 [thread overview]
Message-ID: <538C5C64.3080805@linaro.org> (raw)
In-Reply-To: <1401707388.11045.6.camel@kazak.uk.xensource.com>
On 06/02/2014 12:09 PM, Ian Campbell wrote:
> On Mon, 2014-06-02 at 14:07 +0530, vijay.kilari@gmail.com wrote:
>> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>>
>> arm64 always supports generic timer. So check is not required
>> for arm64. For platforms which supports only aarch64 mode this
>> check always passes and panics
>
> Ah, because the relevant feature flag/register is 32-bit only.
>
> I'd prefer to see this done in the cpufeature header as:
> #ifdef CONFIG_ARM_32
> #define cpu_has_gentimer (boot_cpu_feature32(gentimer) == 1)
> #else
> #define cpu_has_gentimer (1)
> #endif
> rather than adding #ifdef to the common code. Likewise for any similar
> "always on for aarch64" features.
AFAIU, the feature flag exists on ARMv8 platform with aarch32 support.
So an ifdef may not be the correct solution here.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-06-02 11:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 8:37 [PATCH] xen/arm: remove check for generic timer support for arm64 vijay.kilari
2014-06-02 11:06 ` Julien Grall
2014-06-02 11:09 ` Ian Campbell
2014-06-02 11:13 ` Julien Grall [this message]
2014-06-02 13:03 ` Ian Campbell
2014-06-02 13:23 ` Julien Grall
2014-06-02 13:30 ` Ian Campbell
2014-06-02 13:39 ` Julien Grall
2014-06-02 13:59 ` Vijay Kilari
2014-06-02 14:02 ` Ian Campbell
2014-06-02 14:08 ` Vijay Kilari
2014-06-02 14:11 ` Ian Campbell
2014-06-02 14:13 ` Julien Grall
2014-06-02 14:21 ` Ian Campbell
2014-06-02 14:10 ` Julien Grall
2014-06-02 14:12 ` Ian Campbell
2014-06-02 14:01 ` Ian Campbell
2014-06-02 14:48 ` Ian Campbell
2014-06-02 14:50 ` Julien Grall
2014-06-02 14:53 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538C5C64.3080805@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=vijay.kilari@gmail.com \
--cc=vijaya.kumar@caviumnetworks.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.