All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>,
	Fabio Estevam <festevam@gmail.com>
Subject: Re: Failed to set cache compression type
Date: Mon, 02 Jun 2014 16:10:11 +0200	[thread overview]
Message-ID: <538C85C3.5020808@metafoo.de> (raw)
In-Reply-To: <538C840A.2000307@linux.intel.com>

On 06/02/2014 04:02 PM, Jarkko Nikula wrote:
> On 06/02/2014 04:43 PM, Fabio Estevam wrote:
>> Hi,
>>
>> I am booting linux-next 20140602 on a mx6qsabresd and I get the following
>> probe
>> error:
>>
>> wm8962 0-001a: customer id 0 revision D
>> wm8962 0-001a: ASoC: Failed to set cache compression type: -22
>> imx-wm8962 sound: snd_soc_register_card failed (-22)
>> imx-wm8962: probe of sound failed with error -22
>>
>> What is the proper way to fix it?
>>
> I was looking at this too and it was introduced by the commit b59dce53ef61
> ("ASoC: cache: Fix possible ZERO_SIZE_PTR pointer dereferencing error.").

I think snd_soc_cache_init() should return 0 rather than -EINVAL if reg_size 
is 0.

>
> If I understood commit 657254714ad2 ("ASoC: io: Remove support for ASoC
> cache in conjunction with regmap") right should we remove remaining
> soc-cache use? All codec drivers seems to include regmap.h although some of
> them are still calling soc_cache_sync().

Yes, ASoC level support for caching is going to be removed, hopefully sooner 
than later. If a driver still uses soc_cache_sync() even though it has 
switched to regmap for IO that's a bug.

- Lars

  reply	other threads:[~2014-06-02 14:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02 13:43 Failed to set cache compression type Fabio Estevam
2014-06-02 14:02 ` Jarkko Nikula
2014-06-02 14:10   ` Lars-Peter Clausen [this message]
2014-06-02 14:13     ` Fabio Estevam
2014-06-02 14:10   ` Mark Brown
2014-06-02 15:09   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538C85C3.5020808@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=jarkko.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.