From: Waiman Long <waiman.long@hp.com>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Mikulas Patocka <mpatocka@redhat.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
John David Anglin <dave.anglin@bell.net>,
Parisc List <linux-parisc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
"Vinod, Chegu" <chegu_vinod@hp.com>,
Thomas Gleixner <tglx@linutronix.de>,
Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Anvin <hpa@zytor.com>, Andi Kleen <andi@firstfloor.org>,
"Chandramouleeswaran, Aswin" <aswin@hp.com>,
"Norton, Scott J" <scott.norton@hp.com>,
Jason Low <jason.low2@hp.com>
Subject: Re: [PATCH v2] introduce atomic_pointer to fix a race condition in cancelable mcs spinlocks
Date: Mon, 02 Jun 2014 13:42:34 -0400 [thread overview]
Message-ID: <538CB78A.8090500@hp.com> (raw)
In-Reply-To: <1401729145.5185.5.camel@buesod1.americas.hpqcorp.net>
On 06/02/2014 01:12 PM, Davidlohr Bueso wrote:
> On Mon, 2014-06-02 at 10:09 -0700, Linus Torvalds wrote:
>> On Mon, Jun 2, 2014 at 9:25 AM, Peter Zijlstra<peterz@infradead.org> wrote:
>>> And I can't say I'm a particular fan of these ops either, as alternative
>>> I'm almost inclined to just exclude parisc from using opt spinning.
>> Please do.
> I agree, this is the best way out of this mess. Furthermore, it would
> also be nice to consolidate opt spinning in a common CONFIG option --
> right now mutexes and rwsems create their own dependencies.
>
I would suggest adding a RWSEM_SPIN_ON_OWNER to control opt spinning in
rwsem. Currently MUTEX_SPIN_ON_OWNER is doing that for mutex, and it is
disabled when mutex debugging is turned on. So I think it is better to
allow them to be disabled separately.
-Longman
next prev parent reply other threads:[~2014-06-02 17:42 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 17:53 [PATCH] fix a race condition in cancelable mcs spinlocks Mikulas Patocka
2014-06-01 19:20 ` Peter Zijlstra
2014-06-01 20:46 ` John David Anglin
2014-06-01 21:30 ` Peter Zijlstra
2014-06-01 21:46 ` Paul E. McKenney
2014-06-02 9:19 ` Mikulas Patocka
2014-06-02 13:24 ` Paul E. McKenney
2014-06-02 15:57 ` Mikulas Patocka
2014-06-02 16:39 ` Paul E. McKenney
2014-06-02 19:56 ` James Bottomley
2014-06-03 7:56 ` Peter Zijlstra
2014-06-04 12:53 ` Mikulas Patocka
2014-06-02 13:58 ` Mikulas Patocka
2014-06-02 14:02 ` Mikulas Patocka
2014-06-02 15:39 ` John David Anglin
2014-06-02 10:34 ` Mikulas Patocka
2014-06-02 14:14 ` Waiman Long
2014-06-02 15:27 ` Jason Low
2014-06-02 16:00 ` [PATCH v2] introduce atomic_pointer to " Mikulas Patocka
2014-06-02 16:25 ` Peter Zijlstra
2014-06-02 16:30 ` Peter Zijlstra
2014-06-02 16:46 ` Paul E. McKenney
2014-06-02 17:33 ` Waiman Long
2014-06-02 20:05 ` Peter Zijlstra
2014-06-02 20:22 ` Linus Torvalds
2014-06-02 21:02 ` Paul E. McKenney
2014-06-02 21:12 ` Linus Torvalds
2014-06-02 22:08 ` Paul E. McKenney
2014-06-02 22:44 ` Eric Dumazet
2014-06-02 23:17 ` Paul E. McKenney
2014-06-02 23:53 ` Eric Dumazet
2014-06-03 0:28 ` Paul E. McKenney
2014-06-02 22:55 ` Linus Torvalds
2014-06-03 16:48 ` Paul E. McKenney
2014-06-03 7:54 ` Peter Zijlstra
2014-06-02 20:24 ` James Bottomley
2014-06-02 16:43 ` Paul E. McKenney
2014-06-02 17:14 ` James Bottomley
2014-06-02 17:29 ` Waiman Long
2014-06-02 17:09 ` Linus Torvalds
2014-06-02 17:12 ` Davidlohr Bueso
2014-06-02 17:42 ` Waiman Long [this message]
2014-06-02 20:46 ` Mikulas Patocka
2014-06-02 20:53 ` Linus Torvalds
2014-06-02 21:12 ` Mikulas Patocka
2014-06-03 7:36 ` Peter Zijlstra
2014-06-03 11:14 ` Mikulas Patocka
2014-06-03 13:24 ` Peter Zijlstra
2014-06-03 14:18 ` Mikulas Patocka
2014-06-03 14:07 ` Paul E. McKenney
2014-06-03 15:09 ` Peter Zijlstra
2014-06-03 15:56 ` Paul E. McKenney
2014-06-03 7:20 ` Peter Zijlstra
2014-06-02 21:03 ` Paul E. McKenney
2014-06-06 15:06 ` Peter Zijlstra
2014-06-06 15:15 ` Paul E. McKenney
2014-06-06 15:42 ` Davidlohr Bueso
2014-06-02 16:50 ` Jason Low
2014-06-02 17:03 ` Paul E. McKenney
2014-06-02 17:25 ` Waiman Long
2014-06-02 17:38 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CB78A.8090500@hp.com \
--to=waiman.long@hp.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=aswin@hp.com \
--cc=chegu_vinod@hp.com \
--cc=dave.anglin@bell.net \
--cc=davidlohr@hp.com \
--cc=deller@gmx.de \
--cc=hpa@zytor.com \
--cc=jason.low2@hp.com \
--cc=jejb@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.