From: Georgi Djakov <gdjakov@mm-sol.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: mturquette@linaro.org, linux@arm.linux.org.uk,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rdunlap@infradead.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/4] clk: qcom: Add APQ8084 Global Clock Controller support
Date: Mon, 02 Jun 2014 22:47:38 +0300 [thread overview]
Message-ID: <538CD4DA.10403@mm-sol.com> (raw)
In-Reply-To: <20140602193603.GM20486@codeaurora.org>
On 02.06.14, 22:36, Stephen Boyd wrote:
> On 05/31, Georgi Djakov wrote:
>> +
>> +static const struct qcom_reset_map gcc_apq8084_resets[] = {
>
>> + [GCC_VENUS0_BCR] = { 0x1020 },
>
>> + [GCC_VPU_BCR] = { 0x1400 },
>
>> + [GCC_MDSS_BCR] = { 0x2300 },
>> + [GCC_AVSYNC_BCR] = { 0x2400 },
>> + [GCC_OXILI_BCR] = { 0x4020 },
>> + [GCC_OXILICX_BCR] = { 0x4030 },
>> + [GCC_OCMEMCX_BCR] = { 0x4050 },
>
> These aren't in global clock control (looks like mmcc).
>
Will remove it!
>> +#define GCC_VENUS0_BCR 56
>
>> +#define GCC_VPU_BCR 76
>
>
>> +#define GCC_MDSS_BCR 93
>> +#define GCC_AVSYNC_BCR 94
>> +#define GCC_OXILI_BCR 95
>> +#define GCC_OXILICX_BCR 96
>> +#define GCC_OCMEMCX_BCR 97
>
> Ditto
>
Thank you for reviewing the patches!
WARNING: multiple messages have this Message-ID (diff)
From: gdjakov@mm-sol.com (Georgi Djakov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] clk: qcom: Add APQ8084 Global Clock Controller support
Date: Mon, 02 Jun 2014 22:47:38 +0300 [thread overview]
Message-ID: <538CD4DA.10403@mm-sol.com> (raw)
In-Reply-To: <20140602193603.GM20486@codeaurora.org>
On 02.06.14, 22:36, Stephen Boyd wrote:
> On 05/31, Georgi Djakov wrote:
>> +
>> +static const struct qcom_reset_map gcc_apq8084_resets[] = {
>
>> + [GCC_VENUS0_BCR] = { 0x1020 },
>
>> + [GCC_VPU_BCR] = { 0x1400 },
>
>> + [GCC_MDSS_BCR] = { 0x2300 },
>> + [GCC_AVSYNC_BCR] = { 0x2400 },
>> + [GCC_OXILI_BCR] = { 0x4020 },
>> + [GCC_OXILICX_BCR] = { 0x4030 },
>> + [GCC_OCMEMCX_BCR] = { 0x4050 },
>
> These aren't in global clock control (looks like mmcc).
>
Will remove it!
>> +#define GCC_VENUS0_BCR 56
>
>> +#define GCC_VPU_BCR 76
>
>
>> +#define GCC_MDSS_BCR 93
>> +#define GCC_AVSYNC_BCR 94
>> +#define GCC_OXILI_BCR 95
>> +#define GCC_OXILICX_BCR 96
>> +#define GCC_OCMEMCX_BCR 97
>
> Ditto
>
Thank you for reviewing the patches!
next prev parent reply other threads:[~2014-06-02 19:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 15:45 [PATCH v2 0/4] clk: qcom: Add APQ8084 Global Clock Controller support Georgi Djakov
2014-05-31 15:45 ` Georgi Djakov
2014-05-31 15:45 ` [PATCH v2 1/4] clk: qcom: Add APQ8084 Global Clock Controller documentation Georgi Djakov
2014-05-31 15:45 ` Georgi Djakov
2014-06-02 19:41 ` Stephen Boyd
2014-06-02 19:41 ` Stephen Boyd
2014-05-31 15:45 ` [PATCH v2 2/4] clk: qcom: Add APQ8084 Global Clock Controller support Georgi Djakov
2014-05-31 15:45 ` Georgi Djakov
2014-06-02 19:36 ` Stephen Boyd
2014-06-02 19:36 ` Stephen Boyd
2014-06-02 19:47 ` Georgi Djakov [this message]
2014-06-02 19:47 ` Georgi Djakov
2014-05-31 15:45 ` [PATCH v2 3/4] ARM: dts: qcom: Add APQ8084 Global Clock Controller DT node Georgi Djakov
2014-05-31 15:45 ` Georgi Djakov
2014-06-02 19:43 ` Stephen Boyd
2014-06-02 19:43 ` Stephen Boyd
2014-06-02 20:41 ` Kumar Gala
2014-06-02 20:41 ` Kumar Gala
2014-06-02 20:49 ` Georgi Djakov
2014-06-02 20:49 ` Georgi Djakov
2014-05-31 15:45 ` [PATCH v2 4/4] ARM: dts: qcom: Add APQ8084 serial port " Georgi Djakov
2014-05-31 15:45 ` Georgi Djakov
2014-06-02 19:41 ` Stephen Boyd
2014-06-02 19:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CD4DA.10403@mm-sol.com \
--to=gdjakov@mm-sol.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.