From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PULL 2/2] vhost: replace rcu with mutex
Date: Tue, 03 Jun 2014 14:48:34 +0200 [thread overview]
Message-ID: <538DC422.1050303@redhat.com> (raw)
In-Reply-To: <1401746280.3645.187.camel@edumazet-glaptop2.roam.corp.google.com>
Il 02/06/2014 23:58, Eric Dumazet ha scritto:
> This looks dubious
>
> What about using kfree_rcu() instead ?
It would lead to unbound allocation from userspace.
> translate_desc() still uses rcu_read_lock(), its not clear if the mutex
> is really held.
Yes, vhost_get_vq_desc must be called with the vq mutex held.
The rcu_read_lock/unlock in translate_desc is unnecessary.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PULL 2/2] vhost: replace rcu with mutex
Date: Tue, 03 Jun 2014 14:48:34 +0200 [thread overview]
Message-ID: <538DC422.1050303@redhat.com> (raw)
In-Reply-To: <1401746280.3645.187.camel@edumazet-glaptop2.roam.corp.google.com>
Il 02/06/2014 23:58, Eric Dumazet ha scritto:
> This looks dubious
>
> What about using kfree_rcu() instead ?
It would lead to unbound allocation from userspace.
> translate_desc() still uses rcu_read_lock(), its not clear if the mutex
> is really held.
Yes, vhost_get_vq_desc must be called with the vq mutex held.
The rcu_read_lock/unlock in translate_desc is unnecessary.
Paolo
next prev parent reply other threads:[~2014-06-03 12:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 21:30 [PULL 0/2] vhost enhancements for 3.16 Michael S. Tsirkin
2014-06-02 21:30 ` Michael S. Tsirkin
2014-06-02 21:30 ` [PULL 1/2] vhost-net: extend device allocation to vmalloc Michael S. Tsirkin
2014-06-02 21:30 ` Michael S. Tsirkin
2014-06-02 21:30 ` [PULL 2/2] vhost: replace rcu with mutex Michael S. Tsirkin
2014-06-02 21:30 ` Michael S. Tsirkin
2014-06-02 21:58 ` Eric Dumazet
2014-06-02 21:58 ` Eric Dumazet
2014-06-03 12:48 ` Paolo Bonzini [this message]
2014-06-03 12:48 ` Paolo Bonzini
2014-06-03 13:35 ` Vlad Yasevich
2014-06-03 13:35 ` Vlad Yasevich
2014-06-03 13:55 ` Paolo Bonzini
2014-06-03 13:55 ` Paolo Bonzini
2014-06-03 13:57 ` Eric Dumazet
2014-06-03 13:57 ` Eric Dumazet
2014-06-03 14:20 ` Paolo Bonzini
2014-06-03 14:20 ` Paolo Bonzini
2014-06-04 19:51 ` Michael S. Tsirkin
2014-06-04 19:51 ` Michael S. Tsirkin
2014-06-05 10:45 ` Michael S. Tsirkin
2014-06-05 10:45 ` Michael S. Tsirkin
2014-06-04 18:12 ` Michael S. Tsirkin
2014-06-04 18:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538DC422.1050303@redhat.com \
--to=pbonzini@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.