All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Joe Perches <joe@perches.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [RFC 2/4] ath10k:  save firmware debug log messages.
Date: Tue, 03 Jun 2014 09:49:57 -0700	[thread overview]
Message-ID: <538DFCB5.2060208@candelatech.com> (raw)
In-Reply-To: <1401813944.18833.6.camel@joe-AO725>

On 06/03/2014 09:45 AM, Joe Perches wrote:
> On Tue, 2014-06-03 at 09:25 -0700, greearb@candelatech.com wrote:
>> They may be dumped through the firmware dump debugfs
>> file.
> []
>> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
> []
>> @@ -1084,11 +1084,14 @@ static void ath10k_wmi_event_echo(struct ath10k *ar, struct sk_buff *skb)
>>  
>>  static int ath10k_wmi_event_debug_mesg(struct ath10k *ar, struct sk_buff *skb)
>>  {
>> +	u32 *m = (u32 *)(skb->data);
>>  	ath10k_dbg(ATH10K_DBG_WMI, "wmi event debug mesg len %d\n",
>>  		   skb->len);
>>  
>>  	trace_ath10k_wmi_dbglog(skb->data, skb->len);
>>  
>> +	ath10k_dbg_save_fw_dbg_buffer(ar, (u8 *)(&(m[1])), skb->len - 4);
>> +
>>  	return 0;
>>  }
>>  
> 
> That last line looks an overly complicated way of writing
> 
> 	ath10k_dbg_save_fw_dbg_buffer(ar, skb->data + 4, skb->len - 4);
> 
> btw: why skip the first 4 bytes?

First 4 bytes is a counter meaning something like 'messages lost due to overflow',
and is not really part of the debug messages.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Joe Perches <joe@perches.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/4] ath10k:  save firmware debug log messages.
Date: Tue, 03 Jun 2014 09:49:57 -0700	[thread overview]
Message-ID: <538DFCB5.2060208@candelatech.com> (raw)
In-Reply-To: <1401813944.18833.6.camel@joe-AO725>

On 06/03/2014 09:45 AM, Joe Perches wrote:
> On Tue, 2014-06-03 at 09:25 -0700, greearb@candelatech.com wrote:
>> They may be dumped through the firmware dump debugfs
>> file.
> []
>> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
> []
>> @@ -1084,11 +1084,14 @@ static void ath10k_wmi_event_echo(struct ath10k *ar, struct sk_buff *skb)
>>  
>>  static int ath10k_wmi_event_debug_mesg(struct ath10k *ar, struct sk_buff *skb)
>>  {
>> +	u32 *m = (u32 *)(skb->data);
>>  	ath10k_dbg(ATH10K_DBG_WMI, "wmi event debug mesg len %d\n",
>>  		   skb->len);
>>  
>>  	trace_ath10k_wmi_dbglog(skb->data, skb->len);
>>  
>> +	ath10k_dbg_save_fw_dbg_buffer(ar, (u8 *)(&(m[1])), skb->len - 4);
>> +
>>  	return 0;
>>  }
>>  
> 
> That last line looks an overly complicated way of writing
> 
> 	ath10k_dbg_save_fw_dbg_buffer(ar, skb->data + 4, skb->len - 4);
> 
> btw: why skip the first 4 bytes?

First 4 bytes is a counter meaning something like 'messages lost due to overflow',
and is not really part of the debug messages.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2014-06-03 16:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 16:25 [RFC 1/4] ath10k: provide firmware crash info via debugfs greearb
2014-06-03 16:25 ` greearb
2014-06-03 16:25 ` [RFC 2/4] ath10k: save firmware debug log messages greearb
2014-06-03 16:25   ` greearb
2014-06-03 16:45   ` Joe Perches
2014-06-03 16:45     ` Joe Perches
2014-06-03 16:49     ` Ben Greear [this message]
2014-06-03 16:49       ` Ben Greear
2014-06-03 16:25 ` [RFC 3/4] ath10k: save firmware stack upon firmware crash greearb
2014-06-03 16:25   ` greearb
2014-06-03 16:25 ` [RFC 4/4] ath10k: Dump exception stack contents on " greearb
2014-06-03 16:25   ` greearb
2014-06-04  9:04 ` [RFC 1/4] ath10k: provide firmware crash info via debugfs Michal Kazior
2014-06-04  9:04   ` Michal Kazior
2014-06-04 16:48   ` Ben Greear
2014-06-04 16:48     ` Ben Greear
2014-06-05 11:29     ` Kalle Valo
2014-06-05 11:29       ` Kalle Valo
2014-06-05 15:49       ` Ben Greear
2014-06-05 15:49         ` Ben Greear
2014-06-06  6:13         ` Kalle Valo
2014-06-06  6:13           ` Kalle Valo
2014-06-04 17:11   ` Ben Greear
2014-06-04 17:11     ` Ben Greear
2014-06-05 11:33   ` Kalle Valo
2014-06-05 11:33     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538DFCB5.2060208@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=joe@perches.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.