From: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
Cc: Michal Marek <mmarek-AlSwsSmVLrQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mitchel Humpherys
<mitchelh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Gilles Muller <Gilles.Muller-L2FTfq7BK8M@public.gmane.org>,
Nicolas Palix <nicolas.palix-wMUr/XMoy4A@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] coccinelle: Check for missing NULL terminators in of_device_id tables
Date: Tue, 03 Jun 2014 10:45:37 -0700 [thread overview]
Message-ID: <538E09C1.30200@codeaurora.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1406031208380.2036-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
On 06/03/14 03:15, Julia Lawall wrote:
> Failure to terminate an of_device_id table can lead to confusing
> failures depending on where the compiler places the array. Add a
> check to make sure these tables are terminated. Thanks to Mitchel
> Humpherys for coming up with the pattern initially.
>
> Cc: Mitchel Humpherys <mitchelh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Cc: Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
> Cc: Gilles Muller <Gilles.Muller-L2FTfq7BK8M@public.gmane.org>
> Cc: Nicolas Palix <nicolas.palix-wMUr/XMoy4A@public.gmane.org>
> Cc: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Signed-off-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Acked-by: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Signed-off-by: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
>
> ---
>
> v3: Removed unneeded rule bad_of_table. Placed * in context rule on the
> closing brace; putting it on the field caused all fields to be marked.
>
These seem like only minor changes. Why was my authorship removed?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Michal Marek <mmarek@suse.cz>,
linux-kernel@vger.kernel.org,
Mitchel Humpherys <mitchelh@codeaurora.org>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] coccinelle: Check for missing NULL terminators in of_device_id tables
Date: Tue, 03 Jun 2014 10:45:37 -0700 [thread overview]
Message-ID: <538E09C1.30200@codeaurora.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1406031208380.2036@localhost6.localdomain6>
On 06/03/14 03:15, Julia Lawall wrote:
> Failure to terminate an of_device_id table can lead to confusing
> failures depending on where the compiler places the array. Add a
> check to make sure these tables are terminated. Thanks to Mitchel
> Humpherys for coming up with the pattern initially.
>
> Cc: Mitchel Humpherys <mitchelh@codeaurora.org>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
> Cc: Gilles Muller <Gilles.Muller@lip6.fr>
> Cc: Nicolas Palix <nicolas.palix@imag.fr>
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Acked-by: Grant Likely <grant.likely@linaro.org>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>
> ---
>
> v3: Removed unneeded rule bad_of_table. Placed * in context rule on the
> closing brace; putting it on the field caused all fields to be marked.
>
These seem like only minor changes. Why was my authorship removed?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-06-03 17:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 18:04 [PATCH v2] coccinelle: Check for missing NULL terminators in of_device_id tables Stephen Boyd
2014-05-27 18:04 ` Stephen Boyd
2014-06-03 9:24 ` Grant Likely
2014-06-03 10:15 ` Julia Lawall
[not found] ` <alpine.DEB.2.02.1406031208380.2036-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2014-06-03 17:45 ` Stephen Boyd [this message]
2014-06-03 17:45 ` Stephen Boyd
[not found] ` <538E09C1.30200-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-06-03 18:14 ` Julia Lawall
2014-06-03 18:14 ` Julia Lawall
[not found] ` <alpine.DEB.2.02.1406032013150.2009-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2014-06-03 18:19 ` Stephen Boyd
2014-06-03 18:19 ` Stephen Boyd
[not found] ` <538E119D.8010304-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-06-03 18:25 ` Julia Lawall
2014-06-03 18:25 ` Julia Lawall
2014-06-09 21:47 ` Michal Marek
2014-06-09 21:50 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538E09C1.30200@codeaurora.org \
--to=sboyd-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=Gilles.Muller-L2FTfq7BK8M@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=julia.lawall-L2FTfq7BK8M@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mitchelh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=mmarek-AlSwsSmVLrQ@public.gmane.org \
--cc=nicolas.palix-wMUr/XMoy4A@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.