From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: David Miller <davem@davemloft.net>
Cc: sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: fix SH7619/771x support
Date: Wed, 04 Jun 2014 02:20:33 +0000 [thread overview]
Message-ID: <538E8271.6040406@renesas.com> (raw)
In-Reply-To: <20140603.190229.1248289002649714904.davem@davemloft.net>
Hi David,
(2014/06/04 11:02), David Miller wrote:
> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Date: Wed, 4 Jun 2014 09:34:56 +0900
>
>> (2014/06/04 4:42), Sergei Shtylyov wrote:
>>> Commit 4a55530f38e4 (net: sh_eth: modify the definitions of register) managed
>>> to leave out the E-DMAC register entries in sh_eth_offset_fast_sh3_sh2[], thus
>>> totally breaking SH7619/771x support. Add the missing entries using the data
>>> from before that commit.
>>>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ...
>> I checked sh7710 and sh7619 datasheet, but they don't have RPADIR register.
>> Since I would like to check a datasheet you looked into, would you tell me about this?
>
> I think what Sergei simply did is take what was used for register offsets
> before the mentioned commits.
>
> The RPADIR register write is guarded by "mdp->cd->rpadir" being non-zero,
> so his change is very safe.
Thank you for the reply. I understood it.
Since I checked all of the registers offset in this patch and they are good:
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: David Miller <davem@davemloft.net>
Cc: <sergei.shtylyov@cogentembedded.com>, <netdev@vger.kernel.org>,
<linux-sh@vger.kernel.org>
Subject: Re: [PATCH] sh_eth: fix SH7619/771x support
Date: Wed, 4 Jun 2014 11:20:33 +0900 [thread overview]
Message-ID: <538E8271.6040406@renesas.com> (raw)
In-Reply-To: <20140603.190229.1248289002649714904.davem@davemloft.net>
Hi David,
(2014/06/04 11:02), David Miller wrote:
> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Date: Wed, 4 Jun 2014 09:34:56 +0900
>
>> (2014/06/04 4:42), Sergei Shtylyov wrote:
>>> Commit 4a55530f38e4 (net: sh_eth: modify the definitions of register) managed
>>> to leave out the E-DMAC register entries in sh_eth_offset_fast_sh3_sh2[], thus
>>> totally breaking SH7619/771x support. Add the missing entries using the data
>>> from before that commit.
>>>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ...
>> I checked sh7710 and sh7619 datasheet, but they don't have RPADIR register.
>> Since I would like to check a datasheet you looked into, would you tell me about this?
>
> I think what Sergei simply did is take what was used for register offsets
> before the mentioned commits.
>
> The RPADIR register write is guarded by "mdp->cd->rpadir" being non-zero,
> so his change is very safe.
Thank you for the reply. I understood it.
Since I checked all of the registers offset in this patch and they are good:
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2014-06-04 2:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 19:42 [PATCH] sh_eth: fix SH7619/771x support Sergei Shtylyov
2014-06-03 19:42 ` Sergei Shtylyov
2014-06-04 0:34 ` Yoshihiro Shimoda
2014-06-04 0:34 ` Yoshihiro Shimoda
2014-06-04 2:02 ` David Miller
2014-06-04 2:02 ` David Miller
2014-06-04 2:20 ` Yoshihiro Shimoda [this message]
2014-06-04 2:20 ` Yoshihiro Shimoda
2014-06-04 12:37 ` Sergei Shtylyov
2014-06-04 12:37 ` Sergei Shtylyov
2014-06-04 2:29 ` David Miller
2014-06-04 2:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538E8271.6040406@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.