From: Daniel Borkmann <dborkman@redhat.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next] net: remove some useless list_del()
Date: Wed, 04 Jun 2014 10:26:22 +0200 [thread overview]
Message-ID: <538ED82E.7070407@redhat.com> (raw)
In-Reply-To: <CAADnVQK+JUp63oETwazjkmouyQqn8ph9Ssbe=B6qhChcHgcgrw@mail.gmail.com>
On 06/04/2014 04:18 AM, Alexei Starovoitov wrote:
> On Tue, Jun 3, 2014 at 5:43 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On Tue, 2014-06-03 at 17:11 -0700, Cong Wang wrote:
>>> "list_kill" is allocated on stack and it's a list head,
>>> it is pointless to call list_del(&kill_list) especially
>>> after unregister_netdevice_many().
>>
>> How pointless exactly ? Explain more please.
>>
>> I suggest you read various commits adding these list_del()
>>
>> f87e6f47933e3ebeced9bb12615e830a72cedce4 is a good start.
>
> Interesting thread. Thanks guys!
> detailed explanation by Linus:
> https://lkml.org/lkml/2011/2/17/267
Indeed, thanks for the pointer. On that note, if you grep for
unregister_netdevice_many() invocations, you'll see many more
such cases that would need a list_del() actually.
next prev parent reply other threads:[~2014-06-04 8:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 0:11 [Patch net-next] net: remove some unless free on failure in alloc_netdev_mqs() Cong Wang
2014-06-04 0:11 ` [Patch net-next] net: remove some useless list_del() Cong Wang
2014-06-04 0:24 ` David Miller
2014-06-04 0:43 ` Eric Dumazet
2014-06-04 2:18 ` Alexei Starovoitov
2014-06-04 8:26 ` Daniel Borkmann [this message]
2014-06-06 6:40 ` Cong Wang
2014-06-06 13:17 ` Eric Dumazet
2014-06-06 13:44 ` [PATCH net-next] net: force a list_del() in unregister_netdevice_many() Eric Dumazet
2014-06-06 15:54 ` Alexei Starovoitov
2014-06-08 21:15 ` David Miller
2014-06-09 1:27 ` Gao feng
2014-06-09 5:48 ` Eric Dumazet
2014-06-09 5:58 ` [Patch net-next] net: remove some useless list_del() Cong Wang
2014-06-04 2:19 ` [Patch net-next] net: remove some unless free on failure in alloc_netdev_mqs() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538ED82E.7070407@redhat.com \
--to=dborkman@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.