From: Larry Finger <Larry.Finger@lwfinger.net>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
dwmw2@infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Add firmware for r8723au
Date: Wed, 04 Jun 2014 11:11:44 -0500 [thread overview]
Message-ID: <538F4540.9080002@lwfinger.net> (raw)
In-Reply-To: <1401833651.2412.35.camel@deadeye.wl.decadent.org.uk>
On 06/03/2014 05:14 PM, Ben Hutchings wrote:
> On Sun, 2014-01-19 at 23:35 +0000, Ben Hutchings wrote:
>> On Thu, 2014-01-02 at 18:42 -0600, Larry Finger wrote:
>>> This firmware is for a driver that will soon be submitted to the kernel.
>>> It occurs as data statements in Realtek driver rtl8723A_WiFi_linux_v4.1.3_6044.20121224.
>>>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>> ---
>>> WHENCE | 13 +++++++++++++
>>> rtlwifi/rtl8723aufw_A.bin | Bin 0 -> 22172 bytes
>>> rtlwifi/rtl8723aufw_B.bin | Bin 0 -> 24118 bytes
>>> rtlwifi/rtl8723aufw_B_NoBT.bin | Bin 0 -> 19200 bytes
>>> 4 files changed, 13 insertions(+)
>>> create mode 100644 rtlwifi/rtl8723aufw_A.bin
>>> create mode 100644 rtlwifi/rtl8723aufw_B.bin
>>> create mode 100644 rtlwifi/rtl8723aufw_B_NoBT.bin
>> [...]
>>
>> Applied, thanks.
>
> I just noticed that the driver in Linux 3.15 seems to ask for
> rtlwifi/rtl8723aufw.bin and not rtlwifi/rtl8723aufw_A.bin. You'll need
> to change the filename on one side or the other.
Jes,
As Ben points out, I messed up the firmware names, and one of them needs to be
changed. Keeping the name "rtlwifi/rtl8723aufw_A.bin" would retain a certain
amount of symmetry, but is may be easier to retain "rtlwifi/rtl8723aufw.bin" in
the code. A third option would be to try for one of the names and fall back to
the other if it fails. What do you think?
In any case, we need additional MODULE_FIRMWARE macros for the other two
firmware files.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: Jes Sorensen <Jes.Sorensen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] rtlwifi: Add firmware for r8723au
Date: Wed, 04 Jun 2014 11:11:44 -0500 [thread overview]
Message-ID: <538F4540.9080002@lwfinger.net> (raw)
In-Reply-To: <1401833651.2412.35.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
On 06/03/2014 05:14 PM, Ben Hutchings wrote:
> On Sun, 2014-01-19 at 23:35 +0000, Ben Hutchings wrote:
>> On Thu, 2014-01-02 at 18:42 -0600, Larry Finger wrote:
>>> This firmware is for a driver that will soon be submitted to the kernel.
>>> It occurs as data statements in Realtek driver rtl8723A_WiFi_linux_v4.1.3_6044.20121224.
>>>
>>> Signed-off-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
>>> ---
>>> WHENCE | 13 +++++++++++++
>>> rtlwifi/rtl8723aufw_A.bin | Bin 0 -> 22172 bytes
>>> rtlwifi/rtl8723aufw_B.bin | Bin 0 -> 24118 bytes
>>> rtlwifi/rtl8723aufw_B_NoBT.bin | Bin 0 -> 19200 bytes
>>> 4 files changed, 13 insertions(+)
>>> create mode 100644 rtlwifi/rtl8723aufw_A.bin
>>> create mode 100644 rtlwifi/rtl8723aufw_B.bin
>>> create mode 100644 rtlwifi/rtl8723aufw_B_NoBT.bin
>> [...]
>>
>> Applied, thanks.
>
> I just noticed that the driver in Linux 3.15 seems to ask for
> rtlwifi/rtl8723aufw.bin and not rtlwifi/rtl8723aufw_A.bin. You'll need
> to change the filename on one side or the other.
Jes,
As Ben points out, I messed up the firmware names, and one of them needs to be
changed. Keeping the name "rtlwifi/rtl8723aufw_A.bin" would retain a certain
amount of symmetry, but is may be easier to retain "rtlwifi/rtl8723aufw.bin" in
the code. A third option would be to try for one of the names and fall back to
the other if it fails. What do you think?
In any case, we need additional MODULE_FIRMWARE macros for the other two
firmware files.
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-04 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1388709729-28496-1-git-send-email-Larry.Finger@lwfinger.net>
2014-01-19 23:35 ` [PATCH] rtlwifi: Add firmware for r8723au Ben Hutchings
2014-06-03 22:14 ` Ben Hutchings
2014-06-04 16:11 ` Larry Finger [this message]
2014-06-04 16:11 ` Larry Finger
2014-06-05 6:43 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F4540.9080002@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Jes.Sorensen@redhat.com \
--cc=ben@decadent.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.