From: David Daney <ddaney@caviumnetworks.com>
To: Alex Smith <alex.smith@imgtec.com>
Cc: Aaro Koskinen <aaro.koskinen@nsn.com>,
David Daney <david.daney@cavium.com>, <linux-mips@linux-mips.org>
Subject: Re: [1/3] MIPS: octeon: Add interface mode detection for Octeon II
Date: Wed, 4 Jun 2014 10:12:39 -0700 [thread overview]
Message-ID: <538F5387.8000200@caviumnetworks.com> (raw)
In-Reply-To: <538F420A.60007@imgtec.com>
On 06/04/2014 08:58 AM, Alex Smith wrote:
> On 04/06/14 15:47, Aaro Koskinen wrote:
>> On Thu, May 29, 2014 at 11:10:01AM +0100, Alex Smith wrote:
>>> Add interface mode detection for Octeon II. This is necessary to detect
>>> the interface modes correctly on the UBNT E200 board. Code is taken
>>> from the UBNT GPL source release, with some alterations: SRIO, ILK and
>>> RXAUI interface modes are removed and instead return disabled as these
>>> modes are not currently supported.
>>>
>>> Tested-by: David Daney <david.daney@cavium.com>
>>> Signed-off-by: Alex Smith <alex.smith@imgtec.com>
>>
>> I tried booting ebb6800 board with these patches.
There seem to be problems (I think in the interrupt controller code) for
cn68xx based systems in the kernel.org kernel. So I couldn't get it to
boot on my ebb6800 even to the point it tries to initialize the
networking hardware.
Therefore ...
>>
>> It hangs somewhere in __cvmx_helper_xaui_enable() with XAUI port. Looking
>> at the UBNT GPL package, xaui init is quite different with 68XX specific
>> code paths. Maybe those bits should be added too, or then disable XAUI
>> support as well?
>
> Probably the best thing to do for now would be to disable it. Does it
> boot successfully for you if you switch CVMX_HELPER_INTERFACE_MODE_XAUI
> to disabled?
... I don't think it matters. The patch Alex et al. came up with is an
improvement over what is already there. The fact that there are still
some configurations that don't work can be addressed with follow-on patches.
If I misunderstand the situation, please let me know, and we can work
towards something better.
David Daney
>
> Alex
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Alex Smith <alex.smith@imgtec.com>
Cc: Aaro Koskinen <aaro.koskinen@nsn.com>,
David Daney <david.daney@cavium.com>,
linux-mips@linux-mips.org
Subject: Re: [1/3] MIPS: octeon: Add interface mode detection for Octeon II
Date: Wed, 4 Jun 2014 10:12:39 -0700 [thread overview]
Message-ID: <538F5387.8000200@caviumnetworks.com> (raw)
Message-ID: <20140604171239._nRfYvz2bjog4lDvmyXfMthVop2vclMeRqRiIhmhRFo@z> (raw)
In-Reply-To: <538F420A.60007@imgtec.com>
On 06/04/2014 08:58 AM, Alex Smith wrote:
> On 04/06/14 15:47, Aaro Koskinen wrote:
>> On Thu, May 29, 2014 at 11:10:01AM +0100, Alex Smith wrote:
>>> Add interface mode detection for Octeon II. This is necessary to detect
>>> the interface modes correctly on the UBNT E200 board. Code is taken
>>> from the UBNT GPL source release, with some alterations: SRIO, ILK and
>>> RXAUI interface modes are removed and instead return disabled as these
>>> modes are not currently supported.
>>>
>>> Tested-by: David Daney <david.daney@cavium.com>
>>> Signed-off-by: Alex Smith <alex.smith@imgtec.com>
>>
>> I tried booting ebb6800 board with these patches.
There seem to be problems (I think in the interrupt controller code) for
cn68xx based systems in the kernel.org kernel. So I couldn't get it to
boot on my ebb6800 even to the point it tries to initialize the
networking hardware.
Therefore ...
>>
>> It hangs somewhere in __cvmx_helper_xaui_enable() with XAUI port. Looking
>> at the UBNT GPL package, xaui init is quite different with 68XX specific
>> code paths. Maybe those bits should be added too, or then disable XAUI
>> support as well?
>
> Probably the best thing to do for now would be to disable it. Does it
> boot successfully for you if you switch CVMX_HELPER_INTERFACE_MODE_XAUI
> to disabled?
... I don't think it matters. The patch Alex et al. came up with is an
improvement over what is already there. The fact that there are still
some configurations that don't work can be addressed with follow-on patches.
If I misunderstand the situation, please let me know, and we can work
towards something better.
David Daney
>
> Alex
next prev parent reply other threads:[~2014-06-04 17:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 10:10 [PATCH 0/3] Ubiquiti EdgeRouter/EdgeRouter Pro support Alex Smith
2014-05-29 10:10 ` Alex Smith
2014-05-29 10:10 ` [PATCH 1/3] MIPS: octeon: Add interface mode detection for Octeon II Alex Smith
2014-05-29 10:10 ` Alex Smith
2014-06-04 14:47 ` [1/3] " Aaro Koskinen
2014-06-04 15:58 ` Alex Smith
2014-06-04 15:58 ` Alex Smith
2014-06-04 17:12 ` David Daney [this message]
2014-06-04 17:12 ` David Daney
2014-06-04 18:53 ` Aaro Koskinen
2014-05-29 10:10 ` [PATCH 2/3] staging: octeon-ethernet: Move PHY activation to .ndo_open() Alex Smith
2014-05-29 10:10 ` Alex Smith
2014-05-29 10:10 ` [PATCH 3/3] usb host/MIPS: Remove hard-coded OCTEON platform information Alex Smith
2014-05-29 10:10 ` Alex Smith
2014-05-29 15:03 ` Alan Stern
2014-05-29 15:03 ` Alan Stern
2014-05-29 16:55 ` Florian Fainelli
2014-05-29 17:37 ` Greg KH
2014-05-29 17:59 ` David Daney
2014-05-29 20:55 ` Alan Stern
2014-05-29 21:26 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F5387.8000200@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=aaro.koskinen@nsn.com \
--cc=alex.smith@imgtec.com \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.