Re: [Qemu-devel] [PATCH v5 29/30] spapr_hcall: Split h_set_mode()

[Tom Musta <tommusta@gmail.com>]

On 6/4/2014 7:51 AM, Alexey Kardashevskiy wrote:
> This moves H_SET_MODE_RESOURCE_LE handler to a separate function
> as there are other "resources" coming and this is going to become ugly.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> Changes:
> v2:
> * s/becode/become/ in commit log
> ---
>  hw/ppc/spapr_hcall.c | 67 +++++++++++++++++++++++++++-------------------------
>  1 file changed, 35 insertions(+), 32 deletions(-)
> 
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index a7460ab..cff3b0f 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -712,46 +712,49 @@ static target_ulong h_logical_dcbf(PowerPCCPU *cpu, sPAPREnvironment *spapr,
>      return H_SUCCESS;
>  }
>  
> +static target_ulong h_set_mode_resouce_le(PowerPCCPU *cpu,
> +                                          target_ulong mflags,
> +                                          target_ulong value1,
> +                                          target_ulong value2)
> +{
> +    CPUState *cs;
> +
> +    if (value1) {
> +        return H_P3;
> +    }
> +    if (value2) {
> +        return H_P4;
> +    }
> +
> +    switch (mflags) {
> +    case H_SET_MODE_ENDIAN_BIG:
> +        CPU_FOREACH(cs) {
> +            set_spr(cs, SPR_LPCR, 0, LPCR_ILE);
> +        }
> +        return H_SUCCESS;
> +
> +    case H_SET_MODE_ENDIAN_LITTLE:
> +        CPU_FOREACH(cs) {
> +            set_spr(cs, SPR_LPCR, LPCR_ILE, LPCR_ILE);
> +        }
> +        return H_SUCCESS;
> +    }
> +
> +    return H_UNSUPPORTED_FLAG;
> +}
> +
>  static target_ulong h_set_mode(PowerPCCPU *cpu, sPAPREnvironment *spapr,
>                                 target_ulong opcode, target_ulong *args)
>  {
> -    CPUState *cs;
> -    target_ulong mflags = args[0];
>      target_ulong resource = args[1];
> -    target_ulong value1 = args[2];
> -    target_ulong value2 = args[3];
>      target_ulong ret = H_P2;
>  
> -    if (resource == H_SET_MODE_RESOURCE_LE) {
> -        if (value1) {
> -            ret = H_P3;
> -            goto out;
> -        }
> -        if (value2) {
> -            ret = H_P4;
> -            goto out;
> -        }
> -        switch (mflags) {
> -        case H_SET_MODE_ENDIAN_BIG:
> -            CPU_FOREACH(cs) {
> -                set_spr(cs, SPR_LPCR, 0, LPCR_ILE);
> -            }
> -            ret = H_SUCCESS;
> -            break;
> -
> -        case H_SET_MODE_ENDIAN_LITTLE:
> -            CPU_FOREACH(cs) {
> -                set_spr(cs, SPR_LPCR, LPCR_ILE, LPCR_ILE);
> -            }
> -            ret = H_SUCCESS;
> -            break;
> -
> -        default:
> -            ret = H_UNSUPPORTED_FLAG;
> -        }
> +    switch (resource) {
> +    case H_SET_MODE_RESOURCE_LE:
> +        ret = h_set_mode_resouce_le(cpu, args[0], args[2], args[3]);
> +        break;
>      }
>  
> -out:
>      return ret;
>  }
>  
> 
Reviewed-by: Tom Musta <tommusta@gmail.com>