Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

[Peter Lieven <pl@kamp.de>]

On 30.05.2014 11:05, Paolo Bonzini wrote:
> Il 30/05/2014 11:04, Peter Lieven ha scritto:
>> Am 30.05.2014 07:50, schrieb Paolo Bonzini:
>>> Il 29/05/2014 22:25, Peter Lieven ha scritto:
>>>> Am 29.05.2014 21:17, schrieb Paolo Bonzini:
>>>>> Il 29/05/2014 20:41, Peter Lieven ha scritto:
>>>>>> static inline unsigned geo_rand_range(double m, double n) {
>>>>>>     return exp((log(m) + (double)rand() /
>>>>>>                (RAND_MAX / (log(n) - log(m) + log(1)) + log(1))));
>>>>>> }
>>>>>
>>>>> Yes, exactly (except that log(1) is zero, and was only needed in your case because you were using integers).
>>>>
>>>> Regarding aio_timer_new vs. aio_timer_init. Shall we really have the complete QEMU_TIMER struct in each
>>>> iTask? We need this retry_timer only in the really rare case of a BUSY.
>>>
>>> Ok, makes sense.  Though the overall cost of IscsiTasks should be less than 4k per block device with a separate QemuTimer, and 8k if you embed it.
>>>
>>> Otherwise the patch looks good, thanks!
>>
>> Okay, when are you preparing the next pull request?
>
> After the dataplane patches go in.  But you can send the patch now, I'll rebase.

It might be that we need a LIBS+= -lm to the Makefile in the root directory. I had strange problems when linking qemu-img/qemu-io/qemu-nbd.

Peter