Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

[Peter Lieven <pl@kamp.de>]

On 05.06.2014 11:44, Paolo Bonzini wrote:
> Il 05/06/2014 11:29, Peter Lieven ha scritto:
>>
>> It might be that we need a LIBS+= -lm to the Makefile in the root
>> directory. I had strange problems when linking qemu-img/qemu-io/qemu-nbd.
>
> cat > $TMPC << EOF
> #include <math.h>
> int main(void) { return isnan(sin(0.0)); }
> EOF
> if compile_prog "" "" ; then
>   :
> elif compile_prog "" "-lm" ; then
>   LIBS="-lm $LIBS"
>   libs_qga="-lm $libs_qga"
> else
>   error_exit "libm check failed"
> fi
>
>
> Shouldn't be necessary, should it?

I don't know actually. On my workstation it compiles, but on my build system I need to add this here

diff --git a/Makefile b/Makefile
index 423e373..69e1022 100644
--- a/Makefile
+++ b/Makefile
@@ -74,6 +74,10 @@ $(call set-vpath, $(SRC_PATH))

  LIBS+=-lz $(LIBS_TOOLS)

+ifndef CONFIG_HAIKU
+LIBS+=-lm
+endif
+
  HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)

  ifdef BUILD_DOCS

Otherwise I get unresolved references to log and exp...

I found that the above is only in /x86_64-softmmu/Makefile, but  not in /Makefile

Peter