Re: [PATCH 1/2] ALSA: soundcore: coding style fixes

[Daniel Mack <daniel@zonque.org>]

On 06/05/2014 03:53 PM, Takashi Iwai wrote:
> At Thu,  5 Jun 2014 14:12:25 +0200,
> Daniel Mack wrote:
>>
>> sound/sounc_core.c has a larger number of style issues. Fix them to make the
>> code more readable. No functional change.
>>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
> 
> Thanks for the patches, but are you going to fix anything in these
> codes along with them?  Such coding style fixes just stir git history,
> which make often annoying for backporting or reviewing.  So, basically
> I'd take such cleanup patches only if the real fixes will come
> together.

Yeah, I know that code is legacy. I was just skimming over the sources
to trace a bug report on alsa-user, and stumbled over so many style
issues that made reading the code harder than necessary that I couldn't
resist fixing them :)

Hence, I don't know yet. Maybe there will be a fix as well at some late
point. Feel free to ignore the patches for now. I'll stash and resend
them along with real fixes in case there are any.


Thanks,
Daniel