Re: [PATCH v10 5/5] libxl: network buffering cmdline switch

[Hongyang Yang <yanghy@cn.fujitsu.com>]

On 06/06/2014 01:30 AM, Ian Jackson wrote:
> Yang Hongyang writes ("[PATCH v10 5/5] libxl: network buffering cmdline switch"):
>> Command line switch to 'xl remus' command, to enable network buffering.
>> Pass on this flag to libxl so that it can act accordingly.
>
> You provide a global option to control the script, but no per-domain
> config option.  Why ?
>
> A similar question arises about the network buffering boolean.
>
> Wouldn't it be better if these were options on the devices, in the
> domain configuration ?

Do you mean we make "-n -N" options into domain configuration?
I think these options are only related to remus and may not be used that
often because we provided a default network script which would be suitable
for most cases. these options are sort of second choices for users, may not
worth to be set in the domain configuration.

>
> Feel free to tell me I'm wrong and it is better this way, if that's
> true - just explain it.
>
>> +     * TODO: Split-Brain check.
>
> What are your plans for the split brain check ?

It's hard to do the split brain check under current implementation because
there's only one remus connection between the two domain. We may need to add
a heardbeat module to do this.

>
> Thanks,
> Ian.
> .
>

-- 
Thanks,
Yang.